Re: [PATCH v5 3/6] iio: adc: adi-axi-adc: add interface type

David Lechner
2024-11-01T19:26:25Z

On 11/1/24 6:23 AM, Antoniu Miclaus wrote:
> Add support for getting the interface (CMOS or LVDS) used by the AXI ADC
> IP.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---

Reviewed-by: David Lechner <dlechner@baylibre.com>

> changes in v5:
> - use IIO_BACKEND_INTERFACE_SERIAL_CMOS and IIO_BACKEND_INTERFACE_SERIAL_LVDS
> drivers/iio/adc/adi-axi-adc.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/drivers/iio/adc/adi-axi-adc.c b/drivers/iio/adc/adi-axi-adc.c
> index 5c8c87eb36d1..f6475bc93796 100644
> --- a/drivers/iio/adc/adi-axi-adc.c
> +++ b/drivers/iio/adc/adi-axi-adc.c
> @@ -39,6 +39,9 @@
> #define ADI_AXI_REG_RSTN_MMCM_RSTN BIT(1)
> #define ADI_AXI_REG_RSTN_RSTN BIT(0)
>
> +#define ADI_AXI_ADC_REG_CONFIG 0x000c
> +#define ADI_AXI_ADC_REG_CONFIG_CMOS_OR_LVDS_N BIT(7)
> +
> #define ADI_AXI_ADC_REG_CTRL 0x0044
> #define ADI_AXI_ADC_CTRL_DDR_EDGESEL_MASK BIT(1)
>
> @@ -290,6 +293,25 @@ static int axi_adc_chan_disable(struct iio_backend *back, unsigned int chan)
> ADI_AXI_REG_CHAN_CTRL_ENABLE);
> }
>
> +static int axi_adc_interface_type_get(struct iio_backend *back,
> + enum iio_backend_interface_type *type)
> +{
> + struct adi_axi_adc_state *st = iio_backend_get_priv(back);
> + unsigned int val;
> + int ret;
> +
> + ret = regmap_read(st->regmap, ADI_AXI_ADC_REG_CONFIG, &val);
> + if (ret)
> + return ret;
> +
> + if (val & ADI_AXI_ADC_REG_CONFIG_CMOS_OR_LVDS_N)

FIELD_GET() also works here.

> + *type = IIO_BACKEND_INTERFACE_SERIAL_CMOS;
> + else
> + *type = IIO_BACKEND_INTERFACE_SERIAL_LVDS;
> +
> + return 0;
> +}
> +
> static struct iio_buffer *axi_adc_request_buffer(struct iio_backend *back,
> struct iio_dev *indio_dev)
> {
> @@ -337,6 +359,7 @@ static const struct iio_backend_ops adi_axi_adc_ops = {
> .iodelay_set = axi_adc_iodelays_set,
> .test_pattern_set = axi_adc_test_pattern_set,
> .chan_status = axi_adc_chan_status,
> + .interface_type_get = axi_adc_interface_type_get,
> .debugfs_reg_access = iio_backend_debugfs_ptr(axi_adc_reg_access),
> .debugfs_print_chan_status = iio_backend_debugfs_ptr(axi_adc_debugfs_print_chan_status),
> };