From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01B8316EB7A; Thu, 1 Aug 2024 14:17:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722521862; cv=none; b=RsJMS+oL2pDqB/GpAasA2+y3/KUmvuy2Z9Jz1hVcVRwjHl2nq4+d84KXU4uXdxLtdkp2hg2aqnhIL1JPNPX9e21oLxzqIKvTJ40I+OxylOyynI5QbR/NAEJNT0977ObgoCYVgf1tEhk8YcDQ52OZ6oFWxRNoOJ/fLtBzVdzOLUc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722521862; c=relaxed/simple; bh=lpPeXtSbqltUVioPGDfAyN59eLIBOGKeuSb8kFCREq8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ebtoIIKzHFBwqWxhL5a1o5hSG+LPM4cPMPlsBdA8H3743OnN8i1oWHXD4hXUm9ee2LygjEGcN5X+P3wav2t9n67aaP2h4p/INM0sCuz/K3o6uHYRlq3QS2oaixH0XwA670arrOpN4vzYPT+DW9ywp4NQ5/nYHsZfWG/bFMG+fxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nlecLEh6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nlecLEh6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C7D59C4AF0A; Thu, 1 Aug 2024 14:17:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722521861; bh=lpPeXtSbqltUVioPGDfAyN59eLIBOGKeuSb8kFCREq8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=nlecLEh6xOfPCoH24WEwH0w19PZxMiV50gnMlInfkSI74LSp6+RelAd9gSM6PxAnx SZJ+oQfWBWfxoCOmwuQDHmxbRydYA6pQXtdkGsQ5LxWunLgCw+wG5trSUnuIBn7tf2 yaHLwWlOKPQWMNYsGtKhRtkDkfnDkfpvNWrrhl56AAjHarWHFdXHR9iDFnlBqtfYwJ eZWwieH3r72yCvaK8OSVRyGhT+He8haiCZ3b5ZluOKPYKOBiYNd++/q1dZo7iq0eHM vz62bwSzEbXdhboF2qj7RZyyaXppw30A4hsvCsbn3NCqdvwVnMyKwhy+UAqLHaHnlg Sl7a/A9KWBXBA== Message-ID: <2c9099b1-f742-4092-90d0-24aba51fc198@kernel.org> Date: Thu, 1 Aug 2024 16:17:30 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] drm/bridge: synopsys: Add DW HDMI QP TX Controller driver To: Cristian Ciocaltea , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Heiko_St=C3=BCbner?= , Andy Yan , Alexandre ARNOUD , Luis de Arquer , Algea Cao References: <20240801-dw-hdmi-qp-tx-v1-0-148f542de5fd@collabora.com> <20240801-dw-hdmi-qp-tx-v1-2-148f542de5fd@collabora.com> <19af747f-0911-4896-afba-b63c585554d4@kernel.org> <274a023a-de27-49e7-aa03-7fd60ddfcb87@collabora.com> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <274a023a-de27-49e7-aa03-7fd60ddfcb87@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 01/08/2024 11:43, Cristian Ciocaltea wrote: > On 8/1/24 11:50 AM, Krzysztof Kozlowski wrote: >> On 01/08/2024 04:05, Cristian Ciocaltea wrote: >>> The Synopsys DesignWare HDMI 2.1 Quad-Pixel (QP) TX Controller supports >>> the following features, among others: >> >> ... >> >>> + >>> +void dw_hdmi_qp_unbind(struct dw_hdmi_qp *hdmi) >>> +{ >>> +} >>> +EXPORT_SYMBOL_GPL(dw_hdmi_qp_unbind); >> >> This looks like quite useless export. Drop. >> >> >>> + >>> +void dw_hdmi_qp_resume(struct device *dev, struct dw_hdmi_qp *hdmi) >>> +{ >>> + dw_hdmi_qp_init_hw(hdmi); >>> +} >>> +EXPORT_SYMBOL_GPL(dw_hdmi_qp_resume); >>> + >>> +MODULE_AUTHOR("Algea Cao "); >>> +MODULE_AUTHOR("Cristian Ciocaltea "); >>> +MODULE_DESCRIPTION("DW HDMI QP transmitter driver"); >>> +MODULE_LICENSE("GPL"); >>> +MODULE_ALIAS("platform:dw-hdmi-qp"); >> >> That's not a platform driver. That does not look like driver at all, >> just some helper code without any user > > This is actually used to provide RK3588 HDMI output support: > > https://lore.kernel.org/lkml/20240801-b4-rk3588-bridge-upstream-v2-3-9fa657a4e15b@collabora.com/ That is supposed to be in one patchset, so we can see how you use the introduced functions. Best regards, Krzysztof