Re: [PATCH 04/13] arm64: dts: qcom: msm8916-samsung-a2015: Add sound and modem

[Konrad Dybcio <konrad.dybcio@linaro.org>]

On 26.09.2023 18:51, Stephan Gerhold wrote:
> Enable sound and modem for the Samsung A2015 based devices (A3, A5, E5,
> E7, Grand Max). The setup is similar to most MSM8916 devices, i.e.:
> 
>  - QDSP6 audio
>  - Earpiece/headphones/microphones via digital/analog codec in
>    MSM8916/PM8916
>  - WWAN Internet via BAM-DMUX
> 
> except:
> 
>  - NXP TFA9895 codec for speaker on Quaternary MI2S
>  - Samsung-specific audio jack detection (not supported yet)
> 
> [Lin: Add e2015 and grandmax]
> Co-developed-by: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
> Signed-off-by: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
>  .../dts/qcom/msm8916-samsung-a2015-common.dtsi     | 55 ++++++++++++++++++++++
>  .../dts/qcom/msm8916-samsung-e2015-common.dtsi     |  4 ++
>  .../boot/dts/qcom/msm8916-samsung-grandmax.dts     |  4 ++
>  3 files changed, 63 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
> index 0b29132b74e1..f71b18d89bf9 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916-samsung-a2015-common.dtsi
> @@ -1,10 +1,13 @@
>  // SPDX-License-Identifier: GPL-2.0-only
>  
>  #include "msm8916-pm8916.dtsi"
> +#include "msm8916-modem-qdsp6.dtsi"
> +
>  #include <dt-bindings/gpio/gpio.h>
>  #include <dt-bindings/input/input.h>
>  #include <dt-bindings/interrupt-controller/irq.h>
>  #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> +#include <dt-bindings/sound/apq8016-lpass.h>
>  
>  / {
>  	aliases {
> @@ -196,6 +199,18 @@ vibrator: vibrator {
>  	};
>  };
>  
> +&blsp_i2c1 {
> +	status = "okay";
> +
> +	speaker_codec: audio-codec@34 {
> +		compatible = "nxp,tfa9895";
> +		reg = <0x34>;
> +		vddd-supply = <&pm8916_l5>;
> +		sound-name-prefix = "Speaker";
> +		#sound-dai-cells = <0>;
> +	};
> +};
> +
>  &blsp_i2c2 {
>  	status = "okay";
>  
> @@ -243,6 +258,13 @@ &gpu {
>  	status = "okay";
>  };
>  
> +&lpass {
> +	dai-link@3 {
> +		reg = <MI2S_QUATERNARY>;
> +		qcom,playback-sd-lines = <1>;
> +	};
> +};
Is that not status = reserved?

Konrad