From: Dinh Nguyen <dinguyen@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [RESEND, third time][PATCH] arm64: dts: intel: socfpga_agilex_socdk: align LED node names with dtschema
Date: Wed, 26 Jan 2022 14:26:29 -0600 [thread overview]
Message-ID: <2cb2bbd9-1ff7-2a5e-a425-29a502080290@kernel.org> (raw)
In-Reply-To: <20220126174157.288111-1-krzysztof.kozlowski@canonical.com>
On 1/26/22 11:41, Krzysztof Kozlowski wrote:
> From: Krzysztof Kozlowski <krzk@kernel.org>
>
> Align the LED node names with dtschema to silence dtbs_check warnings
> like:
>
> leds: 'hps0', 'hps1', 'hps2' do not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> ---
>
> This patch waits for a year. Dinh, you previously acked it but can you
> apply it?
> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> index ea37ba7ccff9..26cd3c121757 100644
> --- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
> @@ -21,17 +21,17 @@ chosen {
>
> leds {
> compatible = "gpio-leds";
> - hps0 {
> + led0 {
> label = "hps_led0";
> gpios = <&portb 20 GPIO_ACTIVE_HIGH>;
> };
>
> - hps1 {
> + led1 {
> label = "hps_led1";
> gpios = <&portb 19 GPIO_ACTIVE_HIGH>;
> };
>
> - hps2 {
> + led2 {
> label = "hps_led2";
> gpios = <&portb 21 GPIO_ACTIVE_HIGH>;
> };
Apologies for missing this the first 2 times.
Applied, thanks!
Dinh
prev parent reply other threads:[~2022-01-26 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 17:41 [RESEND, third time][PATCH] arm64: dts: intel: socfpga_agilex_socdk: align LED node names with dtschema Krzysztof Kozlowski
2022-01-26 20:26 ` Dinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cb2bbd9-1ff7-2a5e-a425-29a502080290@kernel.org \
--to=dinguyen@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox