From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A97E1D015B; Wed, 2 Oct 2024 12:23:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727871792; cv=none; b=dhBVV8ASIHqPMK6HlyaNi0eISDSRREmMdgvvBlIbPYrR4QJHqyWto1X41/rdrWaaEb+YXInnKdHAsufkgfQT+eq+/iQT5rRDwrSoBEKhqmY5yosnzx6xs69Nm2SNPCG2u9Kp25BMtE8/KZPR/QV6as6xPCGUwU4BYyELEpCB1AM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727871792; c=relaxed/simple; bh=MBzPicWBaX1VECfS2Sb+6T+LhbGJCQzrzg25zWYToqY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VyE3vpX/V6YX6tOnZ90hi+HaNXwt/7qYQ6/Darx5UJ5GzbEBRv8mw4oW/IlTJ5goVa1pC4X/yPc0VTDKGDJyiXMnHlGQAJ5nWQLG6sqRi9R6fWPfgWTjW1NcSAL7Ah7OQdkLaLE1T+aF3tnNjctDeohZRo6fAj5LxZ415nD3wqo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=o8OU0Wey; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="o8OU0Wey" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B382AC4AF54; Wed, 2 Oct 2024 12:23:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727871792; bh=MBzPicWBaX1VECfS2Sb+6T+LhbGJCQzrzg25zWYToqY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=o8OU0WeyUr5LJaHaYvyCE9iQyh+v14KhtDciwVMbiE3HOPITGfHeUIyxCNJKgX5KS Uj8EEyaXaTWjoxgOD5H9xIGA2Ev5e/6jmsPCz/O/KfueyF8oJ985W/+RWLKy9EBJcb FR18THU+2Toj52tO9NA04XKZMa8Oo7fgO8mk0RvpbJFlB0heUrtF8MuR7tz4enn+VT BXRSfzxFfaHh/2of4wBkpHsRiq1H/N+RokgkQD9QQabz1lnOOSpv15AkMI/2D/z+Gm M41/1Y6V3spgBL3r/Pbkbjpl1BddEdqCegwVHbLW30SKPVLjLnnRCKIPZ59X0qgL1n IyIbKBMyWaShA== Message-ID: <2ceaffdd-198b-44b2-8e8a-414e981f53e2@kernel.org> Date: Wed, 2 Oct 2024 14:23:05 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] arm64: dts: qcom: add Linksys EA9350 V3 To: Karl Chan , linux-arm-msm@vger.kernel.org Cc: andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241002120804.25068-1-exxxxkc@getgoogleoff.me> <20241002120804.25068-2-exxxxkc@getgoogleoff.me> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20241002120804.25068-2-exxxxkc@getgoogleoff.me> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 02/10/2024 14:08, Karl Chan wrote: > Add device tree source for Linksys EA9350 V3 which is a WiFi router based on the IPQ5018 SoC. > > As of now , only the UART,USB,USB LED,buttons is working.The front PWM LED require the IPQ PWM driver.Therefore the PWM LED isn't configed in the tree. > > Also The original firmware from Linksys can only boot ARM32 kernels. > > As of now There seems to be no way to boot ARM64 kernels on those device. > > However, it is possible to use this device tree by compiling an ARM32 kernel instead. > > Signed-off-by: Karl Chan > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/ipq5018-linksys-jamaica.dts | 114 ++++++++++++++++++ > 2 files changed, 115 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-linksys-jamaica.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index ae002c7cf126..9ddc1b695478 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb > dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq5018-rdp432-c2.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq5018-tplink-archer-ax55-v1.dtb > +dtb-$(CONFIG_ARCH_QCOM) += ipq5018-linksys-jamaica.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp441.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp442.dtb > dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp468.dtb > diff --git a/arch/arm64/boot/dts/qcom/ipq5018-linksys-jamaica.dts b/arch/arm64/boot/dts/qcom/ipq5018-linksys-jamaica.dts > new file mode 100644 > index 000000000000..b6cb88884193 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/ipq5018-linksys-jamaica.dts > @@ -0,0 +1,114 @@ > +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause > + > +/dts-v1/; > + > +/* > + * NOTE: The original firmware from Linksys can only boot ARM32 kernels. > + * > + * As of now There seems to be no way to boot ARM64 kernels on those device. > + * > + * However, it is possible to use this device tree by compiling an ARM32 kernel > + * instead. For clarity and build testing this device tree is maintained next > + * to the other IPQ5018 device trees. However, it is actually used through > + * arch/arm/boot/dts/qcom/qcom-ipq5018-linksys-jamaica.dts > + */ > + > +#include "ipq5018.dtsi" > +#include > +#include > +#include > + > + Just one blank line. > +/ { > + model = "Linksys EA9350 V3"; > + compatible = "linksys,jamaica", "qcom,ipq5018"; Please put bindings patch before users. > + > + aliases { > + serial0 = &blsp1_uart1; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + leds { > + compatible = "gpio-leds"; > + pinctrl-0 = <&led_pins>; > + pinctrl-names = "default"; > + > + led-0 { > + color = ; > + function = LED_FUNCTION_USB; > + gpios = <&tlmm 19 GPIO_ACTIVE_HIGH>; > + }; > + Drop blank line. > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-0 = <&button_pins>; > + pinctrl-names = "default"; > + > + button-0 { > + label = "reset"; > + linux,code = ; > + gpios = <&tlmm 28 GPIO_ACTIVE_LOW>; > + debounce-interval = <60>; > + }; > + > + button-1 { > + label = "wps"; > + linux,code = ; > + gpios = <&tlmm 27 GPIO_ACTIVE_LOW>; > + debounce-interval = <60>; > + }; > + }; > + Drop blank line. > +}; > + > +&blsp1_uart1 { > + pinctrl-0 = <&uart1_pins>; > + pinctrl-names = "default"; > + status = "okay"; > +}; > + > +&sleep_clk { > + clock-frequency = <32000>; > +}; > + > +&usbphy0 { > + status = "okay"; > +}; > + > +&usb { > + status = "okay"; > +}; > + > +&usb_dwc { > + dr_mode = "host"; > +}; > + > +&tlmm { Keep alphabetical order (or tlmm goes to the end). > + button_pins: button-pins-state { > + pins = "gpio27", "gpio28"; > + function = "gpio"; > + drive-strength = <8>; > + bias-pull-up; > + }; > + > + led_pins: led-pins-state { > + pins = "gpio19"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > + Drop blank line. > +}; > + > +&sleep_clk { > + clock-frequency = <32000>; > +}; > + > +&xo_board_clk { > + clock-frequency = <24000000>; > +}; Best regards, Krzysztof