* RE: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk [not found] ` <42476475-3de1-49e8-4cfe-a9b3d98df8be@kernel.org> @ 2023-04-12 11:10 ` Stanley Chang[昌育德] 2023-04-12 14:16 ` Krzysztof Kozlowski 0 siblings, 1 reply; 5+ messages in thread From: Stanley Chang[昌育德] @ 2023-04-12 11:10 UTC (permalink / raw) To: Krzysztof Kozlowski, Thinh Nguyen Cc: linux-usb@vger.kernel.org, Greg Kroah-Hartman, Rob Herring, Felipe Balbi, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org > On 11/04/2023 07:35, Stanley Chang wrote: > > Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for > > disable the high-speed parkmode. > > > > Signed-off-by: Stanley Chang <stanley_chang@realtek.com> > > --- > > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > NAK, so Greg won't pick it up too fast. :) > > Please use scripts/get_maintainers.pl to get a list of necessary people and lists > to CC. It might happen, that command when run on an older kernel, gives > you outdated entries. Therefore please be sure you base your patches on > recent Linux kernel. > > Best regards, > Krzysztof > CC more maintainers by using scripts/get_maintainers.pl Thanks, Stanley ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk 2023-04-12 11:10 ` [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk Stanley Chang[昌育德] @ 2023-04-12 14:16 ` Krzysztof Kozlowski 0 siblings, 0 replies; 5+ messages in thread From: Krzysztof Kozlowski @ 2023-04-12 14:16 UTC (permalink / raw) To: Stanley Chang[昌育德], Thinh Nguyen Cc: linux-usb@vger.kernel.org, Greg Kroah-Hartman, Rob Herring, Felipe Balbi, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org On 12/04/2023 13:10, Stanley Chang[昌育德] wrote: >> On 11/04/2023 07:35, Stanley Chang wrote: >>> Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for >>> disable the high-speed parkmode. >>> >>> Signed-off-by: Stanley Chang <stanley_chang@realtek.com> >>> --- >>> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >> >> NAK, so Greg won't pick it up too fast. :) >> >> Please use scripts/get_maintainers.pl to get a list of necessary people and lists >> to CC. It might happen, that command when run on an older kernel, gives >> you outdated entries. Therefore please be sure you base your patches on >> recent Linux kernel. >> >> Best regards, >> Krzysztof >> > > CC more maintainers by using scripts/get_maintainers.pl > This does not work like this. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk [not found] ` <20230411053550.16360-2-stanley_chang@realtek.com> [not found] ` <42476475-3de1-49e8-4cfe-a9b3d98df8be@kernel.org> @ 2023-04-13 3:03 ` Stanley Chang 2023-04-13 7:34 ` Krzysztof Kozlowski 1 sibling, 1 reply; 5+ messages in thread From: Stanley Chang @ 2023-04-13 3:03 UTC (permalink / raw) To: Thinh Nguyen Cc: linux-usb, Stanley Chang, Greg Kroah-Hartman, Rob Herring, Felipe Balbi, devicetree, linux-kernel, Krzysztof Kozlowski Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for disable the high-speed parkmode. Signed-off-by: Stanley Chang <stanley_chang@realtek.com> --- Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml index be36956af53b..45ca967b8d14 100644 --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml @@ -232,6 +232,11 @@ properties: When set, all SuperSpeed bus instances in park mode are disabled. type: boolean + snps,parkmode-disable-hs-quirk: + description: + When set, all HighSpeed bus instances in park mode are disabled. + type: boolean + snps,dis_metastability_quirk: description: When set, disable metastability workaround. CAUTION! Use only if you are -- 2.34.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk 2023-04-13 3:03 ` Stanley Chang @ 2023-04-13 7:34 ` Krzysztof Kozlowski 2023-04-13 8:04 ` Stanley Chang[昌育德] 0 siblings, 1 reply; 5+ messages in thread From: Krzysztof Kozlowski @ 2023-04-13 7:34 UTC (permalink / raw) To: Stanley Chang, Thinh Nguyen Cc: linux-usb, Greg Kroah-Hartman, Rob Herring, Felipe Balbi, devicetree, linux-kernel On 13/04/2023 05:03, Stanley Chang wrote: > Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for > disable the high-speed parkmode. Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. It's the second time I am writing it. I don't understand why you keep ignoring it. Your commit msg does not explain why do we need it. > > Signed-off-by: Stanley Chang <stanley_chang@realtek.com> > --- > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > index be36956af53b..45ca967b8d14 100644 > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > @@ -232,6 +232,11 @@ properties: > When set, all SuperSpeed bus instances in park mode are disabled. > type: boolean > > + snps,parkmode-disable-hs-quirk: > + description: > + When set, all HighSpeed bus instances in park mode are disabled. Why? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk 2023-04-13 7:34 ` Krzysztof Kozlowski @ 2023-04-13 8:04 ` Stanley Chang[昌育德] 0 siblings, 0 replies; 5+ messages in thread From: Stanley Chang[昌育德] @ 2023-04-13 8:04 UTC (permalink / raw) To: Krzysztof Kozlowski, Thinh Nguyen Cc: linux-usb@vger.kernel.org, Greg Kroah-Hartman, Rob Herring, Felipe Balbi, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org > On 13/04/2023 05:03, Stanley Chang wrote: > > Add a new 'snps,parkmode-disable-hs-quirk' DT quirk to dwc3 core for > > disable the high-speed parkmode. > > Please use scripts/get_maintainers.pl to get a list of necessary people and lists > to CC. It might happen, that command when run on an older kernel, gives > you outdated entries. Therefore please be sure you base your patches on > recent Linux kernel. > > It's the second time I am writing it. I don't understand why you keep ignoring > it. Sorry for the confusion. In the beginning I didn't have cc all maintainers. I'll resubmit a new review thread. Please ignore this email. > Your commit msg does not explain why do we need it. I will add it at new patch. > > > > Signed-off-by: Stanley Chang <stanley_chang@realtek.com> > > --- > > Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > index be36956af53b..45ca967b8d14 100644 > > --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > @@ -232,6 +232,11 @@ properties: > > When set, all SuperSpeed bus instances in park mode are disabled. > > type: boolean > > > > + snps,parkmode-disable-hs-quirk: > > + description: > > + When set, all HighSpeed bus instances in park mode are disabled. > > Why? > For some USB wifi devices, if enable this feature it will reduce the performance. Therefore, add an option for disabling HS park mode by device-tree. Thanks, Stanley ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-04-13 8:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230411053550.16360-1-stanley_chang@realtek.com>
[not found] ` <20230411053550.16360-2-stanley_chang@realtek.com>
[not found] ` <42476475-3de1-49e8-4cfe-a9b3d98df8be@kernel.org>
2023-04-12 11:10 ` [PATCH v2 2/2] dt-bindings: usb: snps,dwc3: Add 'snps,parkmode-disable-hs-quirk' quirk Stanley Chang[昌育德]
2023-04-12 14:16 ` Krzysztof Kozlowski
2023-04-13 3:03 ` Stanley Chang
2023-04-13 7:34 ` Krzysztof Kozlowski
2023-04-13 8:04 ` Stanley Chang[昌育德]
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).