[PATCH] ARM: dts: BCM5301X: Enable USB 3 PHY on Luxul XWR-3150

[PATCH] ARM: dts: BCM5301X: Enable USB 3 PHY on Luxul XWR-3150

[Rafał Miłecki]

From: Rafał Miłecki <rafal@milecki.pl>

This device has a functional USB 3 port so PHY is required.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts b/arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts
index 4d5c5aa7dc42..1a6b9f56d67a 100644
--- a/arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts
+++ b/arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts
@@ -71,6 +71,10 @@ &usb3 {
 	vcc-gpio = <&chipcommon 18 GPIO_ACTIVE_HIGH>;
 };
 
+&usb3_phy {
+	status = "okay";
+}
+
 &spi_nor {
 	status = "okay";
 };
-- 
2.27.0

Re: [PATCH] ARM: dts: BCM5301X: Enable USB 3 PHY on Luxul XWR-3150

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1691 bytes --]

Hi "Rafał,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on v5.10-rc3 next-20201113]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/ARM-dts-BCM5301X-Enable-USB-3-PHY-on-Luxul-XWR-3150/20201113-175236
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-randconfig-r036-20201113 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1f7742592f638fdb90b7270d80d0c797e243ada7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Rafa-Mi-ecki/ARM-dts-BCM5301X-Enable-USB-3-PHY-on-Luxul-XWR-3150/20201113-175236
        git checkout 1f7742592f638fdb90b7270d80d0c797e243ada7
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts:78.1-9 syntax error
   FATAL ERROR: Unable to parse input tree

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33513 bytes --]

Re: [PATCH] ARM: dts: BCM5301X: Enable USB 3 PHY on Luxul XWR-3150

[Rafał Miłecki]

Hey,

On 2020-11-13 14:41, kernel test robot wrote:
> [auto build test ERROR on robh/for-next]
> [also build test ERROR on v5.10-rc3 next-20201113]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:
> https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/ARM-dts-BCM5301X-Enable-USB-3-PHY-on-Luxul-XWR-3150/20201113-175236
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git 
> for-next
> config: arm-randconfig-r036-20201113 (attached as .config)
> compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         #
> https://github.com/0day-ci/linux/commit/1f7742592f638fdb90b7270d80d0c797e243ada7
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review
> Rafa-Mi-ecki/ARM-dts-BCM5301X-Enable-USB-3-PHY-on-Luxul-XWR-3150/20201113-175236
>         git checkout 1f7742592f638fdb90b7270d80d0c797e243ada7
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross 
> ARCH=arm
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>>> Error: arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts:78.1-9 syntax 
>>> error
>    FATAL ERROR: Unable to parse input tree

Is there a problem with bot or GitHub? I can't access any:

https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/ARM-dts-BCM5301X-Enable-USB-3-PHY-on-Luxul-XWR-3150/20201113-175236
https://github.com/0day-ci/linux/commit/1f7742592f638fdb90b7270d80d0c797e243ada7

Re: [PATCH] ARM: dts: BCM5301X: Enable USB 3 PHY on Luxul XWR-3150

[Florian Fainelli]

On Fri, 13 Nov 2020 10:50:12 +0100, Rafał Miłecki <zajec5@gmail.com> wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This device has a functional USB 3 port so PHY is required.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---

Applied to devicetree/next, thanks!
--
Florian

Re: [PATCH] ARM: dts: BCM5301X: Enable USB 3 PHY on Luxul XWR-3150

[Florian Fainelli]

On 11/13/20 3:12 PM, Florian Fainelli wrote:
> On Fri, 13 Nov 2020 10:50:12 +0100, Rafał Miłecki <zajec5@gmail.com> wrote:
>> From: Rafał Miłecki <rafal@milecki.pl>
>>
>> This device has a functional USB 3 port so PHY is required.
>>
>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>> ---
> 
> Applied to devicetree/next, thanks!


After fixing it up so it builds:

diff --git a/arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts
b/arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts
index 1a6b9f56d67a..a361aa8627d3 100644
--- a/arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts
+++ b/arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts
@@ -73,7 +73,7 @@ &usb3 {

 &usb3_phy {
        status = "okay";
-}
+};

 &spi_nor {
        status = "okay";
-- 
Florian

Re: [PATCH] ARM: dts: BCM5301X: Enable USB 3 PHY on Luxul XWR-3150

[Rafał Miłecki]

On Sat, 14 Nov 2020 at 00:17, Florian Fainelli <f.fainelli@gmail.com> wrote:
> On 11/13/20 3:12 PM, Florian Fainelli wrote:
> > On Fri, 13 Nov 2020 10:50:12 +0100, Rafał Miłecki <zajec5@gmail.com> wrote:
> >> From: Rafał Miłecki <rafal@milecki.pl>
> >>
> >> This device has a functional USB 3 port so PHY is required.
> >>
> >> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> >> ---
> >
> > Applied to devicetree/next, thanks!
>
>
> After fixing it up so it builds:

Oops. Sorry and thanks!

Re: [kbuild-all] Re: [PATCH] ARM: dts: BCM5301X: Enable USB 3 PHY on Luxul XWR-3150

[Rong Chen]

On 11/13/20 9:51 PM, Rafał Miłecki wrote:
> Hey,
>
> On 2020-11-13 14:41, kernel test robot wrote:
>> [auto build test ERROR on robh/for-next]
>> [also build test ERROR on v5.10-rc3 next-20201113]
>> [If your patch is applied to the wrong git tree, kindly drop us a note.
>> And when submitting patch, we suggest to use '--base' as documented in
>> https://git-scm.com/docs/git-format-patch]
>>
>> url:
>> https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/ARM-dts-BCM5301X-Enable-USB-3-PHY-on-Luxul-XWR-3150/20201113-175236 
>>
>> base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git 
>> for-next
>> config: arm-randconfig-r036-20201113 (attached as .config)
>> compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
>> reproduce (this is a W=1 build):
>>         wget
>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>> -O ~/bin/make.cross
>>         chmod +x ~/bin/make.cross
>>         #
>> https://github.com/0day-ci/linux/commit/1f7742592f638fdb90b7270d80d0c797e243ada7 
>>
>>         git remote add linux-review https://github.com/0day-ci/linux
>>         git fetch --no-tags linux-review
>> Rafa-Mi-ecki/ARM-dts-BCM5301X-Enable-USB-3-PHY-on-Luxul-XWR-3150/20201113-175236 
>>
>>         git checkout 1f7742592f638fdb90b7270d80d0c797e243ada7
>>         # save the attached .config to linux build tree
>>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 
>> make.cross ARCH=arm
>>
>> If you fix the issue, kindly add following tag as appropriate
>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> All errors (new ones prefixed by >>):
>>
>>>> Error: arch/arm/boot/dts/bcm47094-luxul-xwr-3150-v1.dts:78.1-9 
>>>> syntax error
>>    FATAL ERROR: Unable to parse input tree
>
> Is there a problem with bot or GitHub? I can't access any:
>
> https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/ARM-dts-BCM5301X-Enable-USB-3-PHY-on-Luxul-XWR-3150/20201113-175236 
>
> https://github.com/0day-ci/linux/commit/1f7742592f638fdb90b7270d80d0c797e243ada7 
>
>

Hi Rafał ,

The git push service was busy at that time and the branch
has been uploaded to github at 2020-11-14 03:22:56 +0800.

Best Regards,
Rong Chen