Re: [PATCH v5 2/4] thermal: qoriq: add i.MX93 tmu support

[Daniel Baluta <daniel.baluta@oss.nxp.com>]

On 4/21/26 10:42, Jacky Bai wrote:
> For Thermal monitor unit(TMU) used on i.MX93, the HW revision info read
> from the ID register is the same the one used on some of the QorIQ
> platform, but the config has some slight differance. Add i.MX93 compatible
> string and corresponding code for it.
> 
> Signed-off-by: Alice Guo <alice.guo@nxp.com>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Signed-off-by: Jacky Bai <ping.bai@nxp.com>
> ---
>  - v5 changes:
>   - drop the unnecessary GET_TEUMR0 helper macro
>   - add drvdata for each of the platforms
> 
>  - v4 changes:
>   - no
> 
>  - v3 changes:
>   - use the drv data struct for match data and refine the code
>   - update the copyright
> 
>  - v2 changes:
>   - use the compatible match data to identify the i.MX93 TMU variant
> ---
>  drivers/thermal/qoriq_thermal.c | 33 ++++++++++++++++++++++++++++++---
>  1 file changed, 30 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c
> index 01b58be0dcc64d14ca5e4bba654eed8f15e827fc..297a855311f3d6a8d527794abe17ac86c47bf152 100644
> --- a/drivers/thermal/qoriq_thermal.c
> +++ b/drivers/thermal/qoriq_thermal.c
> @@ -1,6 +1,7 @@
>  // SPDX-License-Identifier: GPL-2.0
>  //
>  // Copyright 2016 Freescale Semiconductor, Inc.
> +// Copyright 2025 NXP
>  
>  #include <linux/clk.h>
>  #include <linux/err.h>
> @@ -24,6 +25,7 @@
>  #define TMTMIR_DEFAULT	0x0000000f
>  #define TIER_DISABLE	0x0
>  #define TEUMR0_V2		0x51009c00
> +#define TEUMR0_V21		0x55000c00
>  #define TMSARA_V2		0xe
>  #define TMU_VER1		0x1
>  #define TMU_VER2		0x2
> @@ -73,12 +75,17 @@ struct qoriq_sensor {
>  	int				id;
>  };
>  
> +struct tmu_drvdata {
> +	u32 teumr0;
> +};
> +
>  struct qoriq_tmu_data {
>  	int ver;
>  	u32 ttrcr[NUM_TTRCR_MAX];
>  	struct regmap *regmap;
>  	struct clk *clk;
>  	struct qoriq_sensor	sensor[SITES_MAX];
> +	const struct tmu_drvdata *drvdata;
>  };
>  
>  static struct qoriq_tmu_data *qoriq_sensor_to_data(struct qoriq_sensor *s)
> @@ -225,6 +232,8 @@ static int qoriq_tmu_calibration(struct device *dev,
>  
>  static void qoriq_tmu_init_device(struct qoriq_tmu_data *data)
>  {
> +	u32 teumr0_val;

No need for this here you can just use directly: data->drvdata->teumr0

> +
>  	/* Disable interrupt, using polling instead */
>  	regmap_write(data->regmap, REGS_TIER, TIER_DISABLE);
>  
> @@ -234,7 +243,8 @@ static void qoriq_tmu_init_device(struct qoriq_tmu_data *data)
>  		regmap_write(data->regmap, REGS_TMTMIR, TMTMIR_DEFAULT);
>  	} else {
>  		regmap_write(data->regmap, REGS_V2_TMTMIR, TMTMIR_DEFAULT);
> -		regmap_write(data->regmap, REGS_V2_TEUMR(0), TEUMR0_V2);
> +		teumr0_val = data->drvdata->teumr0;
> +		regmap_write(data->regmap, REGS_V2_TEUMR(0), teumr0_val);
>  	}