* [PATCH v4 0/3] riscv: sophgo: add thermal sensor support for cv180x/sg200x SoCs
@ 2024-07-16 9:40 Haylen Chu
2024-07-16 9:42 ` [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal Haylen Chu
` (2 more replies)
0 siblings, 3 replies; 23+ messages in thread
From: Haylen Chu @ 2024-07-16 9:40 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen Wang,
Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Jisheng Zhang
Cc: linux-pm, devicetree, linux-kernel, linux-riscv, Haylen Chu
This series implements driver for Sophgo cv180x/sg200x on-chip thermal
sensor and adds thermal zones for CV1800B SoCs.
Changed from v3:
1. style improvments
2. drop unnecessary dt parameters for simplicity
Changed from v2:
1. style and code improvements
2. use human-readable value for sensor parameters
Changed from v1:
1. style and code improvements
2. make sample parameters configurable
3. generalize document temperature calculating formula
Haylen Chu (3):
dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal
riscv: dts: sophgo: cv18xx: Add sensor device and thermal zone
thermal: cv180x: Add cv180x thermal driver support
.../thermal/sophgo,cv1800-thermal.yaml | 55 ++++
arch/riscv/boot/dts/sophgo/cv1800b.dtsi | 30 +++
arch/riscv/boot/dts/sophgo/cv18xx.dtsi | 8 +
drivers/thermal/Kconfig | 6 +
drivers/thermal/Makefile | 1 +
drivers/thermal/cv180x_thermal.c | 241 ++++++++++++++++++
6 files changed, 341 insertions(+)
create mode 100644 Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml
create mode 100644 drivers/thermal/cv180x_thermal.c
--
2.45.2
^ permalink raw reply [flat|nested] 23+ messages in thread* [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal 2024-07-16 9:40 [PATCH v4 0/3] riscv: sophgo: add thermal sensor support for cv180x/sg200x SoCs Haylen Chu @ 2024-07-16 9:42 ` Haylen Chu 2024-07-16 12:43 ` Chen Wang 2024-07-16 15:56 ` Krzysztof Kozlowski 2024-07-16 9:42 ` [PATCH v4 2/3] riscv: dts: sophgo: cv18xx: Add sensor device and thermal zone Haylen Chu 2024-07-16 9:42 ` [PATCH v4 3/3] thermal: cv180x: Add cv180x thermal driver support Haylen Chu 2 siblings, 2 replies; 23+ messages in thread From: Haylen Chu @ 2024-07-16 9:42 UTC (permalink / raw) To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen Wang, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang Cc: linux-pm, devicetree, linux-kernel, linux-riscv, Haylen Chu Add devicetree binding documentation for thermal sensors integrated in Sophgo CV180X SoCs. Signed-off-by: Haylen Chu <heylenay@outlook.com> --- .../thermal/sophgo,cv1800-thermal.yaml | 55 +++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml diff --git a/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml new file mode 100644 index 000000000000..58bd4432cd10 --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/thermal/sophgo,cv1800-thermal.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Sophgo CV1800 on-SoC Thermal Sensor + +maintainers: + - Haylen Chu <heylenay@outlook.com> + +description: Sophgo CV1800 on-SoC thermal sensor + +properties: + compatible: + enum: + - sophgo,cv1800-thermal + + reg: + maxItems: 1 + + clocks: + description: The thermal sensor clock + + interrupts: + maxItems: 1 + + sample-rate-hz: + minimum: 1 + maximum: 1908 + default: 1 + + '#thermal-sensor-cells': + const: 0 + +required: + - compatible + - reg + - clocks + - interrupts + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/sophgo,cv1800.h> + #include <dt-bindings/interrupt-controller/irq.h> + thermal-sensor@30e0000 { + compatible = "sophgo,cv1800-thermal"; + reg = <0x30e0000 0x100>; + clocks = <&clk CLK_TEMPSEN>; + interrupts = <16 IRQ_TYPE_LEVEL_HIGH>; + #thermal-sensor-cells = <0>; + }; +... -- 2.45.2 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal 2024-07-16 9:42 ` [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal Haylen Chu @ 2024-07-16 12:43 ` Chen Wang 2024-07-16 15:48 ` Conor Dooley 2024-07-16 15:56 ` Krzysztof Kozlowski 1 sibling, 1 reply; 23+ messages in thread From: Chen Wang @ 2024-07-16 12:43 UTC (permalink / raw) To: Haylen Chu, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang Cc: linux-pm, devicetree, linux-kernel, linux-riscv On 2024/7/16 17:42, Haylen Chu wrote: > Add devicetree binding documentation for thermal sensors integrated in > Sophgo CV180X SoCs. > > Signed-off-by: Haylen Chu <heylenay@outlook.com> > --- > .../thermal/sophgo,cv1800-thermal.yaml | 55 +++++++++++++++++++ I see sometimes you call it cv1800, and in patch 3, the file name is cv180x_thermal.c, and for dts changes, you changed cv18xx.dtsi. Please unify it. I think sg200x is new name for cv181x serias, so if you want to cover cv180x/sg200x, is cv18xx better? > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > new file mode 100644 > index 000000000000..58bd4432cd10 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/sophgo,cv1800-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sophgo CV1800 on-SoC Thermal Sensor > + > +maintainers: > + - Haylen Chu <heylenay@outlook.com> > + > +description: Sophgo CV1800 on-SoC thermal sensor > + > +properties: > + compatible: > + enum: > + - sophgo,cv1800-thermal cv18xx-thermal ? > + > + reg: > + maxItems: 1 > + > + clocks: > + description: The thermal sensor clock > + > + interrupts: > + maxItems: 1 > + > + sample-rate-hz: > + minimum: 1 > + maximum: 1908 > + default: 1 > + > + '#thermal-sensor-cells': > + const: 0 > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/sophgo,cv1800.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + thermal-sensor@30e0000 { > + compatible = "sophgo,cv1800-thermal"; > + reg = <0x30e0000 0x100>; > + clocks = <&clk CLK_TEMPSEN>; > + interrupts = <16 IRQ_TYPE_LEVEL_HIGH>; > + #thermal-sensor-cells = <0>; > + }; > +... ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal 2024-07-16 12:43 ` Chen Wang @ 2024-07-16 15:48 ` Conor Dooley 2024-07-17 0:05 ` Chen Wang 0 siblings, 1 reply; 23+ messages in thread From: Conor Dooley @ 2024-07-16 15:48 UTC (permalink / raw) To: Chen Wang Cc: Haylen Chu, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang, linux-pm, devicetree, linux-kernel, linux-riscv [-- Attachment #1: Type: text/plain, Size: 2728 bytes --] On Tue, Jul 16, 2024 at 08:43:19PM +0800, Chen Wang wrote: > > On 2024/7/16 17:42, Haylen Chu wrote: > > Add devicetree binding documentation for thermal sensors integrated in > > Sophgo CV180X SoCs. > > > > Signed-off-by: Haylen Chu <heylenay@outlook.com> > > --- > > .../thermal/sophgo,cv1800-thermal.yaml | 55 +++++++++++++++++++ > > I see sometimes you call it cv1800, and in patch 3, the file name is > cv180x_thermal.c, and for dts changes, you changed cv18xx.dtsi. Please unify > it. > > I think sg200x is new name for cv181x serias, so if you want to cover > cv180x/sg200x, is cv18xx better? > > > 1 file changed, 55 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > > > diff --git a/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > new file mode 100644 > > index 000000000000..58bd4432cd10 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > @@ -0,0 +1,55 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/thermal/sophgo,cv1800-thermal.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Sophgo CV1800 on-SoC Thermal Sensor > > + > > +maintainers: > > + - Haylen Chu <heylenay@outlook.com> > > + > > +description: Sophgo CV1800 on-SoC thermal sensor > > + > > +properties: > > + compatible: > > + enum: > > + - sophgo,cv1800-thermal > cv18xx-thermal ? Please, no wildcards in compatibles :/ > > + > > + reg: > > + maxItems: 1 > > + > > + clocks: > > + description: The thermal sensor clock > > + > > + interrupts: > > + maxItems: 1 > > + > > + sample-rate-hz: > > + minimum: 1 > > + maximum: 1908 > > + default: 1 I still don't think this belongs in the devicetree, but is actually software policy. Cheers, Conor. > > + > > + '#thermal-sensor-cells': > > + const: 0 > > + > > +required: > > + - compatible > > + - reg > > + - clocks > > + - interrupts > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/clock/sophgo,cv1800.h> > > + #include <dt-bindings/interrupt-controller/irq.h> > > + thermal-sensor@30e0000 { > > + compatible = "sophgo,cv1800-thermal"; > > + reg = <0x30e0000 0x100>; > > + clocks = <&clk CLK_TEMPSEN>; > > + interrupts = <16 IRQ_TYPE_LEVEL_HIGH>; > > + #thermal-sensor-cells = <0>; > > + }; > > +... [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal 2024-07-16 15:48 ` Conor Dooley @ 2024-07-17 0:05 ` Chen Wang 2024-07-17 1:27 ` Inochi Amaoto 2024-07-17 5:19 ` Haylen Chu 0 siblings, 2 replies; 23+ messages in thread From: Chen Wang @ 2024-07-17 0:05 UTC (permalink / raw) To: Conor Dooley, Haylen Chu Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang, linux-pm, devicetree, linux-kernel, linux-riscv On 2024/7/16 23:48, Conor Dooley wrote: > On Tue, Jul 16, 2024 at 08:43:19PM +0800, Chen Wang wrote: >> On 2024/7/16 17:42, Haylen Chu wrote: >>> Add devicetree binding documentation for thermal sensors integrated in >>> Sophgo CV180X SoCs. >>> >>> Signed-off-by: Haylen Chu <heylenay@outlook.com> >>> --- >>> .../thermal/sophgo,cv1800-thermal.yaml | 55 +++++++++++++++++++ >> I see sometimes you call it cv1800, and in patch 3, the file name is >> cv180x_thermal.c, and for dts changes, you changed cv18xx.dtsi. Please unify >> it. >> >> I think sg200x is new name for cv181x serias, so if you want to cover >> cv180x/sg200x, is cv18xx better? >> >>> 1 file changed, 55 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml >>> new file mode 100644 >>> index 000000000000..58bd4432cd10 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml >>> @@ -0,0 +1,55 @@ >>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/thermal/sophgo,cv1800-thermal.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Sophgo CV1800 on-SoC Thermal Sensor >>> + >>> +maintainers: >>> + - Haylen Chu <heylenay@outlook.com> >>> + >>> +description: Sophgo CV1800 on-SoC thermal sensor >>> + >>> +properties: >>> + compatible: >>> + enum: >>> + - sophgo,cv1800-thermal >> cv18xx-thermal ? > Please, no wildcards in compatibles :/ Sorry for my confusion. Haylen, so you want a compatible that matches an actual SoC and use it everywhere? Or we can add ones for each SoC and have a fallback to cv1800. [......] ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal 2024-07-17 0:05 ` Chen Wang @ 2024-07-17 1:27 ` Inochi Amaoto 2024-07-17 2:14 ` Chen Wang 2024-07-17 5:19 ` Haylen Chu 1 sibling, 1 reply; 23+ messages in thread From: Inochi Amaoto @ 2024-07-17 1:27 UTC (permalink / raw) To: Chen Wang, Conor Dooley, Haylen Chu Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang, linux-pm, devicetree, linux-kernel, linux-riscv On Wed, Jul 17, 2024 at 08:05:10AM GMT, Chen Wang wrote: > > On 2024/7/16 23:48, Conor Dooley wrote: > > On Tue, Jul 16, 2024 at 08:43:19PM +0800, Chen Wang wrote: > > > On 2024/7/16 17:42, Haylen Chu wrote: > > > > Add devicetree binding documentation for thermal sensors integrated in > > > > Sophgo CV180X SoCs. > > > > > > > > Signed-off-by: Haylen Chu <heylenay@outlook.com> > > > > --- > > > > .../thermal/sophgo,cv1800-thermal.yaml | 55 +++++++++++++++++++ > > > I see sometimes you call it cv1800, and in patch 3, the file name is > > > cv180x_thermal.c, and for dts changes, you changed cv18xx.dtsi. Please unify > > > it. > > > > > > I think sg200x is new name for cv181x serias, so if you want to cover > > > cv180x/sg200x, is cv18xx better? > > > > > > > 1 file changed, 55 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > > > new file mode 100644 > > > > index 000000000000..58bd4432cd10 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > > > @@ -0,0 +1,55 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/thermal/sophgo,cv1800-thermal.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Sophgo CV1800 on-SoC Thermal Sensor > > > > + > > > > +maintainers: > > > > + - Haylen Chu <heylenay@outlook.com> > > > > + > > > > +description: Sophgo CV1800 on-SoC thermal sensor > > > > + > > > > +properties: > > > > + compatible: > > > > + enum: > > > > + - sophgo,cv1800-thermal > > > cv18xx-thermal ? > > Please, no wildcards in compatibles :/ > > Sorry for my confusion. > > Haylen, so you want a compatible that matches an actual SoC and use it > everywhere? > This should depend. If this peripheral is SoC specific, it is OK for using SoC specific compatible. Otherwise, it should be series specific. For thermal sensors, I suggest using series-based compatible name as this peripheral is the same across the whole series IIRC. > Or we can add ones for each SoC and have a fallback to cv1800. SoC specific compatible means most of the SoC have different part for this peripheral. For safety, it may not use the fallback generic compatible. Regards, Inochi ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal 2024-07-17 1:27 ` Inochi Amaoto @ 2024-07-17 2:14 ` Chen Wang 2024-07-17 2:27 ` Inochi Amaoto 0 siblings, 1 reply; 23+ messages in thread From: Chen Wang @ 2024-07-17 2:14 UTC (permalink / raw) To: Inochi Amaoto, Conor Dooley, Haylen Chu Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang, linux-pm, devicetree, linux-kernel, linux-riscv On 2024/7/17 9:27, Inochi Amaoto wrote: > On Wed, Jul 17, 2024 at 08:05:10AM GMT, Chen Wang wrote: >> On 2024/7/16 23:48, Conor Dooley wrote: >>> On Tue, Jul 16, 2024 at 08:43:19PM +0800, Chen Wang wrote: >>>> On 2024/7/16 17:42, Haylen Chu wrote: >>>>> Add devicetree binding documentation for thermal sensors integrated in >>>>> Sophgo CV180X SoCs. >>>>> >>>>> Signed-off-by: Haylen Chu <heylenay@outlook.com> >>>>> --- >>>>> .../thermal/sophgo,cv1800-thermal.yaml | 55 +++++++++++++++++++ >>>> I see sometimes you call it cv1800, and in patch 3, the file name is >>>> cv180x_thermal.c, and for dts changes, you changed cv18xx.dtsi. Please unify >>>> it. >>>> >>>> I think sg200x is new name for cv181x serias, so if you want to cover >>>> cv180x/sg200x, is cv18xx better? >>>> >>>>> 1 file changed, 55 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml >>>>> new file mode 100644 >>>>> index 000000000000..58bd4432cd10 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml >>>>> @@ -0,0 +1,55 @@ >>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>>> +%YAML 1.2 >>>>> +--- >>>>> +$id: http://devicetree.org/schemas/thermal/sophgo,cv1800-thermal.yaml# >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>>> + >>>>> +title: Sophgo CV1800 on-SoC Thermal Sensor >>>>> + >>>>> +maintainers: >>>>> + - Haylen Chu <heylenay@outlook.com> >>>>> + >>>>> +description: Sophgo CV1800 on-SoC thermal sensor >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + enum: >>>>> + - sophgo,cv1800-thermal >>>> cv18xx-thermal ? >>> Please, no wildcards in compatibles :/ >> Sorry for my confusion. >> >> Haylen, so you want a compatible that matches an actual SoC and use it >> everywhere? >> > This should depend. If this peripheral is SoC specific, it is OK > for using SoC specific compatible. Otherwise, it should be series > specific. > > For thermal sensors, I suggest using series-based compatible name > as this peripheral is the same across the whole series IIRC. What's the "series-based compatible name" do you mean? Can you give an example? And allow me clarify, what I said "a compatible that matches an actual SoC and use it everywhere" means to define "sophgo,cv1800-thermal" just as Haylen did and use it for all cv18xx SoC chips. Anyway, as Conor suggested, we'd better not use wildcards (char 'x') in compatibles. Thanks, Chen >> Or we can add ones for each SoC and have a fallback to cv1800. > SoC specific compatible means most of the SoC have different part > for this peripheral. For safety, it may not use the fallback > generic compatible. > > Regards, > Inochi ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal 2024-07-17 2:14 ` Chen Wang @ 2024-07-17 2:27 ` Inochi Amaoto 2024-07-17 5:30 ` Haylen Chu 0 siblings, 1 reply; 23+ messages in thread From: Inochi Amaoto @ 2024-07-17 2:27 UTC (permalink / raw) To: Chen Wang, Inochi Amaoto, Conor Dooley, Haylen Chu Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang, linux-pm, devicetree, linux-kernel, linux-riscv On Wed, Jul 17, 2024 at 10:14:46AM GMT, Chen Wang wrote: > > On 2024/7/17 9:27, Inochi Amaoto wrote: > > On Wed, Jul 17, 2024 at 08:05:10AM GMT, Chen Wang wrote: > > > On 2024/7/16 23:48, Conor Dooley wrote: > > > > On Tue, Jul 16, 2024 at 08:43:19PM +0800, Chen Wang wrote: > > > > > On 2024/7/16 17:42, Haylen Chu wrote: > > > > > > Add devicetree binding documentation for thermal sensors integrated in > > > > > > Sophgo CV180X SoCs. > > > > > > > > > > > > Signed-off-by: Haylen Chu <heylenay@outlook.com> > > > > > > --- > > > > > > .../thermal/sophgo,cv1800-thermal.yaml | 55 +++++++++++++++++++ > > > > > I see sometimes you call it cv1800, and in patch 3, the file name is > > > > > cv180x_thermal.c, and for dts changes, you changed cv18xx.dtsi. Please unify > > > > > it. > > > > > > > > > > I think sg200x is new name for cv181x serias, so if you want to cover > > > > > cv180x/sg200x, is cv18xx better? > > > > > > > > > > > 1 file changed, 55 insertions(+) > > > > > > create mode 100644 Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > > > > > new file mode 100644 > > > > > > index 000000000000..58bd4432cd10 > > > > > > --- /dev/null > > > > > > +++ b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > > > > > @@ -0,0 +1,55 @@ > > > > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > > > > +%YAML 1.2 > > > > > > +--- > > > > > > +$id: http://devicetree.org/schemas/thermal/sophgo,cv1800-thermal.yaml# > > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > > + > > > > > > +title: Sophgo CV1800 on-SoC Thermal Sensor > > > > > > + > > > > > > +maintainers: > > > > > > + - Haylen Chu <heylenay@outlook.com> > > > > > > + > > > > > > +description: Sophgo CV1800 on-SoC thermal sensor > > > > > > + > > > > > > +properties: > > > > > > + compatible: > > > > > > + enum: > > > > > > + - sophgo,cv1800-thermal > > > > > cv18xx-thermal ? > > > > Please, no wildcards in compatibles :/ > > > Sorry for my confusion. > > > > > > Haylen, so you want a compatible that matches an actual SoC and use it > > > everywhere? > > > > > This should depend. If this peripheral is SoC specific, it is OK > > for using SoC specific compatible. Otherwise, it should be series > > specific. > > > > For thermal sensors, I suggest using series-based compatible name > > as this peripheral is the same across the whole series IIRC. > > What's the "series-based compatible name" do you mean? Can you give an > example? > You can take clk as an exmaple. "cv1800-clk", "cv1810-clk" and "sg2000-clk". As you already know, sophgo use the same clk tree for the same series. > And allow me clarify, what I said "a compatible that matches an actual SoC > and use it everywhere" means to define "sophgo,cv1800-thermal" just as > Haylen did and use it for all cv18xx SoC chips. > I know it. But there may be something like the pinctrl. They share the same logic, but have different data and layout. In fact, I am sure the thermal is not suitable for this case. > Anyway, as Conor suggested, we'd better not use wildcards (char 'x') in > compatibles. > Yeah, I agree. > Thanks, > > Chen > > > > Or we can add ones for each SoC and have a fallback to cv1800. > > SoC specific compatible means most of the SoC have different part > > for this peripheral. For safety, it may not use the fallback > > generic compatible. > > > > Regards, > > Inochi ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal 2024-07-17 2:27 ` Inochi Amaoto @ 2024-07-17 5:30 ` Haylen Chu 0 siblings, 0 replies; 23+ messages in thread From: Haylen Chu @ 2024-07-17 5:30 UTC (permalink / raw) To: Inochi Amaoto, Chen Wang, Conor Dooley Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang, linux-pm, devicetree, linux-kernel, linux-riscv On Wed, Jul 17, 2024 at 10:27:35AM +0800, Inochi Amaoto wrote: > > And allow me clarify, what I said "a compatible that matches an actual SoC > > and use it everywhere" means to define "sophgo,cv1800-thermal" just as > > Haylen did and use it for all cv18xx SoC chips. > > > > I know it. But there may be something like the pinctrl. They share the same > logic, but have different data and layout. In fact, I am sure the thermal > is not suitable for this case. But for the thermal sensor, they are exactly the same, I don't think it's worth to add compatible strings for each SoC. Even though later SoCs do come with a different design, we could add a new one with little pain. Best regards, Haylen > > Anyway, as Conor suggested, we'd better not use wildcards (char 'x') in > > compatibles. > > > > Yeah, I agree. > > > Thanks, > > > > Chen > > > > > > Or we can add ones for each SoC and have a fallback to cv1800. > > > SoC specific compatible means most of the SoC have different part > > > for this peripheral. For safety, it may not use the fallback > > > generic compatible. > > > > > > Regards, > > > Inochi ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal 2024-07-17 0:05 ` Chen Wang 2024-07-17 1:27 ` Inochi Amaoto @ 2024-07-17 5:19 ` Haylen Chu 2024-07-17 9:12 ` Krzysztof Kozlowski 1 sibling, 1 reply; 23+ messages in thread From: Haylen Chu @ 2024-07-17 5:19 UTC (permalink / raw) To: Chen Wang, Conor Dooley Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang, linux-pm, devicetree, linux-kernel, linux-riscv On Wed, Jul 17, 2024 at 08:05:10AM +0800, Chen Wang wrote: > Haylen, so you want a compatible that matches an actual SoC and use it > everywhere? > > Or we can add ones for each SoC and have a fallback to cv1800. I would prefer "sophgo,cv1800-thermal" and use it everywhere. I don't see any difference on thermal sensors between cv18xx-series SoCs. Best regards, Haylen ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal 2024-07-17 5:19 ` Haylen Chu @ 2024-07-17 9:12 ` Krzysztof Kozlowski 2024-07-18 7:04 ` Haylen Chu 0 siblings, 1 reply; 23+ messages in thread From: Krzysztof Kozlowski @ 2024-07-17 9:12 UTC (permalink / raw) To: Haylen Chu, Chen Wang, Conor Dooley Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang, linux-pm, devicetree, linux-kernel, linux-riscv On 17/07/2024 07:19, Haylen Chu wrote: > On Wed, Jul 17, 2024 at 08:05:10AM +0800, Chen Wang wrote: >> Haylen, so you want a compatible that matches an actual SoC and use it >> everywhere? >> >> Or we can add ones for each SoC and have a fallback to cv1800. > > I would prefer "sophgo,cv1800-thermal" and use it everywhere. I don't > see any difference on thermal sensors between cv18xx-series SoCs. Please use proper fallbacks - there is a very specific rule, repeated many times: https://elixir.bootlin.com/linux/v6.10-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 Best regards, Krzysztof ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal 2024-07-17 9:12 ` Krzysztof Kozlowski @ 2024-07-18 7:04 ` Haylen Chu 2024-07-18 10:53 ` Krzysztof Kozlowski 0 siblings, 1 reply; 23+ messages in thread From: Haylen Chu @ 2024-07-18 7:04 UTC (permalink / raw) To: Krzysztof Kozlowski, Chen Wang, Conor Dooley Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang, linux-pm, devicetree, linux-kernel, linux-riscv On Wed, Jul 17, 2024 at 11:12:52AM +0200, Krzysztof Kozlowski wrote: > On 17/07/2024 07:19, Haylen Chu wrote: > > On Wed, Jul 17, 2024 at 08:05:10AM +0800, Chen Wang wrote: > >> Haylen, so you want a compatible that matches an actual SoC and use it > >> everywhere? > >> > >> Or we can add ones for each SoC and have a fallback to cv1800. > > > > I would prefer "sophgo,cv1800-thermal" and use it everywhere. I don't > > see any difference on thermal sensors between cv18xx-series SoCs. > > Please use proper fallbacks - there is a very specific rule, repeated > many times: > > https://elixir.bootlin.com/linux/v6.10-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 Just in case I misunderstood, You would prefer different SoC-specific compatible strings like "sophgo,cv1800-thermal" "sophgo,sg2002-thermal" added to the driver, and each thermal-sensor node contains two compatible strings, one matches the SoC exactly and one is "sophgo,cv1800-thermal" just as a fallback, right? Best regards, Haylen Chu ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal 2024-07-18 7:04 ` Haylen Chu @ 2024-07-18 10:53 ` Krzysztof Kozlowski 0 siblings, 0 replies; 23+ messages in thread From: Krzysztof Kozlowski @ 2024-07-18 10:53 UTC (permalink / raw) To: Haylen Chu, Chen Wang, Conor Dooley Cc: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang, linux-pm, devicetree, linux-kernel, linux-riscv On 18/07/2024 09:04, Haylen Chu wrote: > On Wed, Jul 17, 2024 at 11:12:52AM +0200, Krzysztof Kozlowski wrote: >> On 17/07/2024 07:19, Haylen Chu wrote: >>> On Wed, Jul 17, 2024 at 08:05:10AM +0800, Chen Wang wrote: >>>> Haylen, so you want a compatible that matches an actual SoC and use it >>>> everywhere? >>>> >>>> Or we can add ones for each SoC and have a fallback to cv1800. >>> >>> I would prefer "sophgo,cv1800-thermal" and use it everywhere. I don't >>> see any difference on thermal sensors between cv18xx-series SoCs. >> >> Please use proper fallbacks - there is a very specific rule, repeated >> many times: >> >> https://elixir.bootlin.com/linux/v6.10-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 > > Just in case I misunderstood, > > You would prefer different SoC-specific compatible strings like > "sophgo,cv1800-thermal" "sophgo,sg2002-thermal" added to the driver, There is nothing in above - comment or guideline - mentioning drivers. > and each thermal-sensor node contains two compatible strings, one > matches the SoC exactly and one is "sophgo,cv1800-thermal" just as a > fallback, right? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal 2024-07-16 9:42 ` [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal Haylen Chu 2024-07-16 12:43 ` Chen Wang @ 2024-07-16 15:56 ` Krzysztof Kozlowski 1 sibling, 0 replies; 23+ messages in thread From: Krzysztof Kozlowski @ 2024-07-16 15:56 UTC (permalink / raw) To: Haylen Chu, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen Wang, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang Cc: linux-pm, devicetree, linux-kernel, linux-riscv On 16/07/2024 11:42, Haylen Chu wrote: > Add devicetree binding documentation for thermal sensors integrated in > Sophgo CV180X SoCs. > > Signed-off-by: Haylen Chu <heylenay@outlook.com> > --- > .../thermal/sophgo,cv1800-thermal.yaml | 55 +++++++++++++++++++ > 1 file changed, 55 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > new file mode 100644 > index 000000000000..58bd4432cd10 > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > @@ -0,0 +1,55 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/sophgo,cv1800-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sophgo CV1800 on-SoC Thermal Sensor > + > +maintainers: > + - Haylen Chu <heylenay@outlook.com> > + > +description: Sophgo CV1800 on-SoC thermal sensor > + Missing $ref to thermal-sensor.yaml > +properties: > + compatible: > + enum: > + - sophgo,cv1800-thermal > + > + reg: > + maxItems: 1 > + > + clocks: > + description: The thermal sensor clock Description is useless. You miss constraints on the other hand, so maxItems. > + > + interrupts: > + maxItems: 1 > + > + sample-rate-hz: > + minimum: 1 > + maximum: 1908 > + default: 1 > + > + '#thermal-sensor-cells': > + const: 0 > + > +required: > + - compatible > + - reg > + - clocks > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/sophgo,cv1800.h> > + #include <dt-bindings/interrupt-controller/irq.h> Use 4 spaces for example indentation. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH v4 2/3] riscv: dts: sophgo: cv18xx: Add sensor device and thermal zone 2024-07-16 9:40 [PATCH v4 0/3] riscv: sophgo: add thermal sensor support for cv180x/sg200x SoCs Haylen Chu 2024-07-16 9:42 ` [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal Haylen Chu @ 2024-07-16 9:42 ` Haylen Chu 2024-07-16 12:31 ` Chen Wang 2024-07-16 15:56 ` Krzysztof Kozlowski 2024-07-16 9:42 ` [PATCH v4 3/3] thermal: cv180x: Add cv180x thermal driver support Haylen Chu 2 siblings, 2 replies; 23+ messages in thread From: Haylen Chu @ 2024-07-16 9:42 UTC (permalink / raw) To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen Wang, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang Cc: linux-pm, devicetree, linux-kernel, linux-riscv, Haylen Chu Add common sensor device Sophgo CV18xx SoCs and thermal zone for CV1800b SoCs. Signed-off-by: Haylen Chu <heylenay@outlook.com> --- arch/riscv/boot/dts/sophgo/cv1800b.dtsi | 30 +++++++++++++++++++++++++ arch/riscv/boot/dts/sophgo/cv18xx.dtsi | 8 +++++++ 2 files changed, 38 insertions(+) diff --git a/arch/riscv/boot/dts/sophgo/cv1800b.dtsi b/arch/riscv/boot/dts/sophgo/cv1800b.dtsi index ec9530972ae2..0b5c7bc94b05 100644 --- a/arch/riscv/boot/dts/sophgo/cv1800b.dtsi +++ b/arch/riscv/boot/dts/sophgo/cv1800b.dtsi @@ -12,6 +12,34 @@ memory@80000000 { device_type = "memory"; reg = <0x80000000 0x4000000>; }; + + thermal-zones { + soc-thermal { + polling-delay-passive = <1000>; + polling-delay = <1000>; + thermal-sensors = <&soc_temp>; + + trips { + soc_passive: soc-passive { + temperature = <75000>; + hysteresis = <5000>; + type = "passive"; + }; + + soc_hot: soc-hot { + temperature = <85000>; + hysteresis = <5000>; + type = "hot"; + }; + + soc_critical: soc-critical { + temperature = <100000>; + hysteresis = <0>; + type = "critical"; + }; + }; + }; + }; }; &plic { @@ -25,3 +53,5 @@ &clint { &clk { compatible = "sophgo,cv1800-clk"; }; + + diff --git a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi index 891932ae470f..76b02cc279aa 100644 --- a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi +++ b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi @@ -310,5 +310,13 @@ clint: timer@74000000 { reg = <0x74000000 0x10000>; interrupts-extended = <&cpu0_intc 3>, <&cpu0_intc 7>; }; + + soc_temp: thermal-sensor@30e0000 { + compatible = "sophgo,cv1800-thermal"; + reg = <0x30e0000 0x100>; + clocks = <&clk CLK_TEMPSEN>; + interrupts = <16 IRQ_TYPE_LEVEL_HIGH>; + #thermal-sensor-cells = <0>; + }; }; }; -- 2.45.2 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH v4 2/3] riscv: dts: sophgo: cv18xx: Add sensor device and thermal zone 2024-07-16 9:42 ` [PATCH v4 2/3] riscv: dts: sophgo: cv18xx: Add sensor device and thermal zone Haylen Chu @ 2024-07-16 12:31 ` Chen Wang 2024-07-16 15:56 ` Krzysztof Kozlowski 1 sibling, 0 replies; 23+ messages in thread From: Chen Wang @ 2024-07-16 12:31 UTC (permalink / raw) To: Haylen Chu, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang Cc: linux-pm, devicetree, linux-kernel, linux-riscv On 2024/7/16 17:42, Haylen Chu wrote: > Add common sensor device Sophgo CV18xx SoCs and thermal zone for > CV1800b SoCs. > > Signed-off-by: Haylen Chu <heylenay@outlook.com> > --- > arch/riscv/boot/dts/sophgo/cv1800b.dtsi | 30 +++++++++++++++++++++++++ > arch/riscv/boot/dts/sophgo/cv18xx.dtsi | 8 +++++++ > 2 files changed, 38 insertions(+) > > diff --git a/arch/riscv/boot/dts/sophgo/cv1800b.dtsi b/arch/riscv/boot/dts/sophgo/cv1800b.dtsi > index ec9530972ae2..0b5c7bc94b05 100644 > --- a/arch/riscv/boot/dts/sophgo/cv1800b.dtsi > +++ b/arch/riscv/boot/dts/sophgo/cv1800b.dtsi > @@ -12,6 +12,34 @@ memory@80000000 { > device_type = "memory"; > reg = <0x80000000 0x4000000>; > }; > + > + thermal-zones { > + soc-thermal { > + polling-delay-passive = <1000>; > + polling-delay = <1000>; > + thermal-sensors = <&soc_temp>; > + > + trips { > + soc_passive: soc-passive { > + temperature = <75000>; > + hysteresis = <5000>; > + type = "passive"; > + }; > + > + soc_hot: soc-hot { > + temperature = <85000>; > + hysteresis = <5000>; > + type = "hot"; > + }; > + > + soc_critical: soc-critical { > + temperature = <100000>; > + hysteresis = <0>; > + type = "critical"; > + }; > + }; > + }; > + }; > }; > > &plic { > @@ -25,3 +53,5 @@ &clint { > &clk { > compatible = "sophgo,cv1800-clk"; > }; > + > + > diff --git a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi > index 891932ae470f..76b02cc279aa 100644 > --- a/arch/riscv/boot/dts/sophgo/cv18xx.dtsi > +++ b/arch/riscv/boot/dts/sophgo/cv18xx.dtsi > @@ -310,5 +310,13 @@ clint: timer@74000000 { > reg = <0x74000000 0x10000>; > interrupts-extended = <&cpu0_intc 3>, <&cpu0_intc 7>; > }; > + > + soc_temp: thermal-sensor@30e0000 { Nodes on any bus, thus using unit addresses for children, shall be ordered by unit address in ascending order. See https://docs.kernel.org/devicetree/bindings/dts-coding-style.html. > + compatible = "sophgo,cv1800-thermal"; > + reg = <0x30e0000 0x100>; > + clocks = <&clk CLK_TEMPSEN>; > + interrupts = <16 IRQ_TYPE_LEVEL_HIGH>; > + #thermal-sensor-cells = <0>; > + }; > }; > }; ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4 2/3] riscv: dts: sophgo: cv18xx: Add sensor device and thermal zone 2024-07-16 9:42 ` [PATCH v4 2/3] riscv: dts: sophgo: cv18xx: Add sensor device and thermal zone Haylen Chu 2024-07-16 12:31 ` Chen Wang @ 2024-07-16 15:56 ` Krzysztof Kozlowski 1 sibling, 0 replies; 23+ messages in thread From: Krzysztof Kozlowski @ 2024-07-16 15:56 UTC (permalink / raw) To: Haylen Chu, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen Wang, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang Cc: linux-pm, devicetree, linux-kernel, linux-riscv On 16/07/2024 11:42, Haylen Chu wrote: > + soc_critical: soc-critical { > + temperature = <100000>; > + hysteresis = <0>; > + type = "critical"; > + }; > + }; > + }; > + }; > }; > > &plic { > @@ -25,3 +53,5 @@ &clint { > &clk { > compatible = "sophgo,cv1800-clk"; > }; > + > + Why? Drop. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH v4 3/3] thermal: cv180x: Add cv180x thermal driver support 2024-07-16 9:40 [PATCH v4 0/3] riscv: sophgo: add thermal sensor support for cv180x/sg200x SoCs Haylen Chu 2024-07-16 9:42 ` [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal Haylen Chu 2024-07-16 9:42 ` [PATCH v4 2/3] riscv: dts: sophgo: cv18xx: Add sensor device and thermal zone Haylen Chu @ 2024-07-16 9:42 ` Haylen Chu 2024-07-16 12:48 ` Chen Wang 2024-07-17 6:22 ` Inochi Amaoto 2 siblings, 2 replies; 23+ messages in thread From: Haylen Chu @ 2024-07-16 9:42 UTC (permalink / raw) To: Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen Wang, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang Cc: linux-pm, devicetree, linux-kernel, linux-riscv, Haylen Chu Add support for cv180x SoCs integrated thermal sensors. Signed-off-by: Haylen Chu <heylenay@outlook.com> --- drivers/thermal/Kconfig | 6 + drivers/thermal/Makefile | 1 + drivers/thermal/cv180x_thermal.c | 241 +++++++++++++++++++++++++++++++ 3 files changed, 248 insertions(+) create mode 100644 drivers/thermal/cv180x_thermal.c diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 204ed89a3ec9..f53c973a361d 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -514,4 +514,10 @@ config LOONGSON2_THERMAL is higher than the high temperature threshold or lower than the low temperature threshold, the interrupt will occur. +config CV180X_THERMAL + tristate "Temperature sensor driver for Sophgo CV180X" + help + If you say yes here you get support for thermal sensor integrated in + Sophgo CV180X SoCs. + endif diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile index 5cdf7d68687f..5b59bde8a579 100644 --- a/drivers/thermal/Makefile +++ b/drivers/thermal/Makefile @@ -65,3 +65,4 @@ obj-$(CONFIG_AMLOGIC_THERMAL) += amlogic_thermal.o obj-$(CONFIG_SPRD_THERMAL) += sprd_thermal.o obj-$(CONFIG_KHADAS_MCU_FAN_THERMAL) += khadas_mcu_fan.o obj-$(CONFIG_LOONGSON2_THERMAL) += loongson2_thermal.o +obj-$(CONFIG_CV180X_THERMAL) += cv180x_thermal.o diff --git a/drivers/thermal/cv180x_thermal.c b/drivers/thermal/cv180x_thermal.c new file mode 100644 index 000000000000..8b726c0ad848 --- /dev/null +++ b/drivers/thermal/cv180x_thermal.c @@ -0,0 +1,241 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Copyright (C) 2021 Sophgo Inc. + * Copyright (C) 2024 Haylen Chu <heylenay@outlook.com> + */ + +#include <linux/bits.h> +#include <linux/clk.h> +#include <linux/io.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/platform_device.h> +#include <linux/thermal.h> + +#define TEMPSEN_VERSION 0x0 +#define TEMPSEN_CTRL 0x4 +#define TEMPSEN_CTRL_EN BIT(0) +#define TEMPSEN_CTRL_SEL_MASK GENMASK(7, 4) +#define TEMPSEN_CTRL_SEL_OFFSET 4 +#define TEMPSEN_STATUS 0x8 +#define TEMPSEN_SET 0xc +#define TEMPSEN_SET_CHOPSEL_MASK GENMASK(5, 4) +#define TEMPSEN_SET_CHOPSEL_OFFSET 4 +#define TEMPSEN_SET_CHOPSEL_128T 0 +#define TEMPSEN_SET_CHOPSEL_256T 1 +#define TEMPSEN_SET_CHOPSEL_512T 2 +#define TEMPSEN_SET_CHOPSEL_1024T 3 +#define TEMPSEN_SET_ACCSEL_MASK GENMASK(7, 6) +#define TEMPSEN_SET_ACCSEL_OFFSET 6 +#define TEMPSEN_SET_ACCSEL_512T 0 +#define TEMPSEN_SET_ACCSEL_1024T 1 +#define TEMPSEN_SET_ACCSEL_2048T 2 +#define TEMPSEN_SET_ACCSEL_4096T 3 +#define TEMPSEN_SET_CYC_CLKDIV_MASK GENMASK(15, 8) +#define TEMPSEN_SET_CYC_CLKDIV_OFFSET 8 +#define TEMPSEN_INTR_EN 0x10 +#define TEMPSEN_INTR_CLR 0x14 +#define TEMPSEN_INTR_STA 0x18 +#define TEMPSEN_INTR_RAW 0x1c +#define TEMPSEN_RESULT(n) (0x20 + (n) * 4) +#define TEMPSEN_RESULT_RESULT_MASK GENMASK(12, 0) +#define TEMPSEN_RESULT_MAX_RESULT_MASK GENMASK(28, 16) +#define TEMPSEN_RESULT_CLR_MAX_RESULT BIT(31) +#define TEMPSEN_AUTO_PERIOD 0x64 +#define TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_MASK GENMASK(23, 0) +#define TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_OFFSET 0 + +struct cv180x_thermal_zone { + struct device *dev; + void __iomem *base; + struct clk *clk_tempsen; + u32 sample_cycle; +}; + +static void cv180x_thermal_init(struct cv180x_thermal_zone *ctz) +{ + void __iomem *base = ctz->base; + u32 regval; + + writel(readl(base + TEMPSEN_INTR_RAW), base + TEMPSEN_INTR_CLR); + writel(TEMPSEN_RESULT_CLR_MAX_RESULT, base + TEMPSEN_RESULT(0)); + + regval = readl(base + TEMPSEN_SET); + regval &= ~TEMPSEN_SET_CHOPSEL_MASK; + regval &= ~TEMPSEN_SET_ACCSEL_MASK; + regval &= ~TEMPSEN_SET_CYC_CLKDIV_MASK; + regval |= TEMPSEN_SET_CHOPSEL_1024T << TEMPSEN_SET_CHOPSEL_OFFSET; + regval |= TEMPSEN_SET_ACCSEL_2048T << TEMPSEN_SET_ACCSEL_OFFSET; + regval |= 0x31 << TEMPSEN_SET_CYC_CLKDIV_OFFSET; + writel(regval, base + TEMPSEN_SET); + + regval = readl(base + TEMPSEN_AUTO_PERIOD); + regval &= ~TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_MASK; + regval |= ctz->sample_cycle << TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_OFFSET; + writel(regval, base + TEMPSEN_AUTO_PERIOD); + + regval = readl(base + TEMPSEN_CTRL); + regval &= ~TEMPSEN_CTRL_SEL_MASK; + regval |= 1 << TEMPSEN_CTRL_SEL_OFFSET; + regval |= TEMPSEN_CTRL_EN; + writel(regval, base + TEMPSEN_CTRL); +} + +static void cv180x_thermal_deinit(struct cv180x_thermal_zone *ct) +{ + void __iomem *base = ct->base; + u32 regval; + + regval = readl(base + TEMPSEN_CTRL); + regval &= ~(TEMPSEN_CTRL_SEL_MASK | TEMPSEN_CTRL_EN); + writel(regval, base + TEMPSEN_CTRL); + + writel(readl(base + TEMPSEN_INTR_RAW), base + TEMPSEN_INTR_CLR); +} + +/* + * Raw register value to temperature (mC) formula: + * + * read_val * 1000 * 716 + * Temperature = ----------------------- - 273000 + * divider + * + * where divider should be ticks number of accumulation period, + * e.g. 2048 for TEMPSEN_CTRL_ACCSEL_2048T + */ +static int cv180x_calc_temp(struct cv180x_thermal_zone *ctz, u32 result) +{ + return (result * 1000) * 716 / 2048 - 273000; +} + +static int cv180x_get_temp(struct thermal_zone_device *tdev, int *temperature) +{ + struct cv180x_thermal_zone *ctz = thermal_zone_device_priv(tdev); + void __iomem *base = ctz->base; + u32 result; + + result = readl(base + TEMPSEN_RESULT(0)) & TEMPSEN_RESULT_RESULT_MASK; + *temperature = cv180x_calc_temp(ctz, result); + + return 0; +} + +static const struct thermal_zone_device_ops cv180x_thermal_ops = { + .get_temp = cv180x_get_temp, +}; + +static const struct of_device_id cv180x_thermal_of_match[] = { + { .compatible = "sophgo,cv1800-thermal" }, + {}, +}; +MODULE_DEVICE_TABLE(of, cv180x_thermal_of_match); + +static int +cv180x_parse_dt(struct cv180x_thermal_zone *ctz) +{ + struct device_node *np = ctz->dev->of_node; + u32 tmp; + + if (of_property_read_u32(np, "sample-rate-hz", &tmp)) { + ctz->sample_cycle = 1000000; + } else { + /* sample cycle should be at least 524us */ + if (tmp > 1000000 / 524) { + dev_err(ctz->dev, "invalid sample rate %d\n", tmp); + return -EINVAL; + } + + ctz->sample_cycle = 1000000 / tmp; + } + + return 0; +} + +static int cv180x_thermal_probe(struct platform_device *pdev) +{ + struct cv180x_thermal_zone *ctz; + struct thermal_zone_device *tz; + struct resource *res; + int ret; + + ctz = devm_kzalloc(&pdev->dev, sizeof(*ctz), GFP_KERNEL); + if (!ctz) + return -ENOMEM; + + ctz->dev = &pdev->dev; + + ret = cv180x_parse_dt(ctz); + if (ret) + return dev_err_probe(&pdev->dev, ret, "failed to parse dt\n"); + + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + ctz->base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(ctz->base)) + return dev_err_probe(&pdev->dev, PTR_ERR(ctz->base), + "failed to map tempsen registers\n"); + + ctz->clk_tempsen = devm_clk_get_enabled(&pdev->dev, NULL); + if (IS_ERR(ctz->clk_tempsen)) + return dev_err_probe(&pdev->dev, PTR_ERR(ctz->clk_tempsen), + "failed to get clk_tempsen\n"); + + cv180x_thermal_init(ctz); + + tz = devm_thermal_of_zone_register(&pdev->dev, 0, ctz, + &cv180x_thermal_ops); + if (IS_ERR(tz)) + return dev_err_probe(&pdev->dev, PTR_ERR(tz), + "failed to register thermal zone\n"); + + platform_set_drvdata(pdev, ctz); + + return 0; +} + +static int cv180x_thermal_remove(struct platform_device *pdev) +{ + struct cv180x_thermal_zone *ctz = platform_get_drvdata(pdev); + + cv180x_thermal_deinit(ctz); + + return 0; +} + +static int __maybe_unused cv180x_thermal_suspend(struct device *dev) +{ + struct cv180x_thermal_zone *ctz = dev_get_drvdata(dev); + + cv180x_thermal_deinit(ctz); + clk_disable_unprepare(ctz->clk_tempsen); + + return 0; +} + +static int __maybe_unused cv180x_thermal_resume(struct device *dev) +{ + struct cv180x_thermal_zone *ctz = dev_get_drvdata(dev); + + clk_prepare_enable(ctz->clk_tempsen); + cv180x_thermal_init(ctz); + + return 0; +} + +static SIMPLE_DEV_PM_OPS(cv180x_thermal_pm_ops, + cv180x_thermal_suspend, cv180x_thermal_resume); + +static struct platform_driver cv180x_thermal_driver = { + .probe = cv180x_thermal_probe, + .remove = cv180x_thermal_remove, + .driver = { + .name = "cv180x-thermal", + .pm = &cv180x_thermal_pm_ops, + .of_match_table = cv180x_thermal_of_match, + }, +}; + +module_platform_driver(cv180x_thermal_driver); + +MODULE_DESCRIPTION("Sophgo CV180x thermal driver"); +MODULE_AUTHOR("Haylen Chu <heylenay@outlook.com>"); +MODULE_LICENSE("GPL"); -- 2.45.2 ^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH v4 3/3] thermal: cv180x: Add cv180x thermal driver support 2024-07-16 9:42 ` [PATCH v4 3/3] thermal: cv180x: Add cv180x thermal driver support Haylen Chu @ 2024-07-16 12:48 ` Chen Wang 2024-07-17 5:32 ` Haylen Chu 2024-07-17 6:22 ` Inochi Amaoto 1 sibling, 1 reply; 23+ messages in thread From: Chen Wang @ 2024-07-16 12:48 UTC (permalink / raw) To: Haylen Chu, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang Cc: linux-pm, devicetree, linux-kernel, linux-riscv On 2024/7/16 17:42, Haylen Chu wrote: > Add support for cv180x SoCs integrated thermal sensors. > > Signed-off-by: Haylen Chu <heylenay@outlook.com> > --- > drivers/thermal/Kconfig | 6 + > drivers/thermal/Makefile | 1 + > drivers/thermal/cv180x_thermal.c | 241 +++++++++++++++++++++++++++++++ > 3 files changed, 248 insertions(+) > create mode 100644 drivers/thermal/cv180x_thermal.c cv18xx_thermal.c ? See my comments in patch 1. When you deicide it, update this for all patches. > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 204ed89a3ec9..f53c973a361d 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -514,4 +514,10 @@ config LOONGSON2_THERMAL > is higher than the high temperature threshold or lower than the low > temperature threshold, the interrupt will occur. > > +config CV180X_THERMAL Same question above, CV18XX_THERMAL? > + tristate "Temperature sensor driver for Sophgo CV180X" > + help > + If you say yes here you get support for thermal sensor integrated in > + Sophgo CV180X SoCs. > + > endif > diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile > index 5cdf7d68687f..5b59bde8a579 100644 > --- a/drivers/thermal/Makefile > +++ b/drivers/thermal/Makefile > @@ -65,3 +65,4 @@ obj-$(CONFIG_AMLOGIC_THERMAL) += amlogic_thermal.o > obj-$(CONFIG_SPRD_THERMAL) += sprd_thermal.o > obj-$(CONFIG_KHADAS_MCU_FAN_THERMAL) += khadas_mcu_fan.o > obj-$(CONFIG_LOONGSON2_THERMAL) += loongson2_thermal.o > +obj-$(CONFIG_CV180X_THERMAL) += cv180x_thermal.o > diff --git a/drivers/thermal/cv180x_thermal.c b/drivers/thermal/cv180x_thermal.c > new file mode 100644 > index 000000000000..8b726c0ad848 > --- /dev/null > +++ b/drivers/thermal/cv180x_thermal.c > @@ -0,0 +1,241 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2021 Sophgo Inc. > + * Copyright (C) 2024 Haylen Chu <heylenay@outlook.com> > + */ > + > +#include <linux/bits.h> > +#include <linux/clk.h> > +#include <linux/io.h> > +#include <linux/module.h> > +#include <linux/of.h> > +#include <linux/platform_device.h> > +#include <linux/thermal.h> > + > +#define TEMPSEN_VERSION 0x0 > +#define TEMPSEN_CTRL 0x4 > +#define TEMPSEN_CTRL_EN BIT(0) > +#define TEMPSEN_CTRL_SEL_MASK GENMASK(7, 4) > +#define TEMPSEN_CTRL_SEL_OFFSET 4 > +#define TEMPSEN_STATUS 0x8 > +#define TEMPSEN_SET 0xc > +#define TEMPSEN_SET_CHOPSEL_MASK GENMASK(5, 4) > +#define TEMPSEN_SET_CHOPSEL_OFFSET 4 > +#define TEMPSEN_SET_CHOPSEL_128T 0 > +#define TEMPSEN_SET_CHOPSEL_256T 1 > +#define TEMPSEN_SET_CHOPSEL_512T 2 > +#define TEMPSEN_SET_CHOPSEL_1024T 3 > +#define TEMPSEN_SET_ACCSEL_MASK GENMASK(7, 6) > +#define TEMPSEN_SET_ACCSEL_OFFSET 6 > +#define TEMPSEN_SET_ACCSEL_512T 0 > +#define TEMPSEN_SET_ACCSEL_1024T 1 > +#define TEMPSEN_SET_ACCSEL_2048T 2 > +#define TEMPSEN_SET_ACCSEL_4096T 3 > +#define TEMPSEN_SET_CYC_CLKDIV_MASK GENMASK(15, 8) > +#define TEMPSEN_SET_CYC_CLKDIV_OFFSET 8 > +#define TEMPSEN_INTR_EN 0x10 > +#define TEMPSEN_INTR_CLR 0x14 > +#define TEMPSEN_INTR_STA 0x18 > +#define TEMPSEN_INTR_RAW 0x1c > +#define TEMPSEN_RESULT(n) (0x20 + (n) * 4) > +#define TEMPSEN_RESULT_RESULT_MASK GENMASK(12, 0) > +#define TEMPSEN_RESULT_MAX_RESULT_MASK GENMASK(28, 16) > +#define TEMPSEN_RESULT_CLR_MAX_RESULT BIT(31) > +#define TEMPSEN_AUTO_PERIOD 0x64 > +#define TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_MASK GENMASK(23, 0) > +#define TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_OFFSET 0 > + > +struct cv180x_thermal_zone { > + struct device *dev; > + void __iomem *base; > + struct clk *clk_tempsen; > + u32 sample_cycle; > +}; > + > +static void cv180x_thermal_init(struct cv180x_thermal_zone *ctz) > +{ > + void __iomem *base = ctz->base; > + u32 regval; > + > + writel(readl(base + TEMPSEN_INTR_RAW), base + TEMPSEN_INTR_CLR); > + writel(TEMPSEN_RESULT_CLR_MAX_RESULT, base + TEMPSEN_RESULT(0)); > + > + regval = readl(base + TEMPSEN_SET); > + regval &= ~TEMPSEN_SET_CHOPSEL_MASK; > + regval &= ~TEMPSEN_SET_ACCSEL_MASK; > + regval &= ~TEMPSEN_SET_CYC_CLKDIV_MASK; > + regval |= TEMPSEN_SET_CHOPSEL_1024T << TEMPSEN_SET_CHOPSEL_OFFSET; > + regval |= TEMPSEN_SET_ACCSEL_2048T << TEMPSEN_SET_ACCSEL_OFFSET; > + regval |= 0x31 << TEMPSEN_SET_CYC_CLKDIV_OFFSET; > + writel(regval, base + TEMPSEN_SET); > + > + regval = readl(base + TEMPSEN_AUTO_PERIOD); > + regval &= ~TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_MASK; > + regval |= ctz->sample_cycle << TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_OFFSET; > + writel(regval, base + TEMPSEN_AUTO_PERIOD); > + > + regval = readl(base + TEMPSEN_CTRL); > + regval &= ~TEMPSEN_CTRL_SEL_MASK; > + regval |= 1 << TEMPSEN_CTRL_SEL_OFFSET; > + regval |= TEMPSEN_CTRL_EN; > + writel(regval, base + TEMPSEN_CTRL); > +} > + > +static void cv180x_thermal_deinit(struct cv180x_thermal_zone *ct) > +{ > + void __iomem *base = ct->base; > + u32 regval; > + > + regval = readl(base + TEMPSEN_CTRL); > + regval &= ~(TEMPSEN_CTRL_SEL_MASK | TEMPSEN_CTRL_EN); > + writel(regval, base + TEMPSEN_CTRL); > + > + writel(readl(base + TEMPSEN_INTR_RAW), base + TEMPSEN_INTR_CLR); > +} > + > +/* > + * Raw register value to temperature (mC) formula: > + * > + * read_val * 1000 * 716 > + * Temperature = ----------------------- - 273000 > + * divider > + * > + * where divider should be ticks number of accumulation period, > + * e.g. 2048 for TEMPSEN_CTRL_ACCSEL_2048T > + */ > +static int cv180x_calc_temp(struct cv180x_thermal_zone *ctz, u32 result) > +{ > + return (result * 1000) * 716 / 2048 - 273000; > +} > + > +static int cv180x_get_temp(struct thermal_zone_device *tdev, int *temperature) > +{ > + struct cv180x_thermal_zone *ctz = thermal_zone_device_priv(tdev); > + void __iomem *base = ctz->base; > + u32 result; > + > + result = readl(base + TEMPSEN_RESULT(0)) & TEMPSEN_RESULT_RESULT_MASK; > + *temperature = cv180x_calc_temp(ctz, result); > + > + return 0; > +} > + > +static const struct thermal_zone_device_ops cv180x_thermal_ops = { > + .get_temp = cv180x_get_temp, > +}; > + > +static const struct of_device_id cv180x_thermal_of_match[] = { > + { .compatible = "sophgo,cv1800-thermal" }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, cv180x_thermal_of_match); > + > +static int > +cv180x_parse_dt(struct cv180x_thermal_zone *ctz) > +{ > + struct device_node *np = ctz->dev->of_node; > + u32 tmp; > + > + if (of_property_read_u32(np, "sample-rate-hz", &tmp)) { > + ctz->sample_cycle = 1000000; > + } else { > + /* sample cycle should be at least 524us */ > + if (tmp > 1000000 / 524) { > + dev_err(ctz->dev, "invalid sample rate %d\n", tmp); > + return -EINVAL; > + } > + > + ctz->sample_cycle = 1000000 / tmp; > + } > + > + return 0; > +} > + > +static int cv180x_thermal_probe(struct platform_device *pdev) > +{ > + struct cv180x_thermal_zone *ctz; > + struct thermal_zone_device *tz; > + struct resource *res; > + int ret; > + > + ctz = devm_kzalloc(&pdev->dev, sizeof(*ctz), GFP_KERNEL); > + if (!ctz) > + return -ENOMEM; > + > + ctz->dev = &pdev->dev; > + > + ret = cv180x_parse_dt(ctz); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, "failed to parse dt\n"); > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + ctz->base = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(ctz->base)) > + return dev_err_probe(&pdev->dev, PTR_ERR(ctz->base), > + "failed to map tempsen registers\n"); > + > + ctz->clk_tempsen = devm_clk_get_enabled(&pdev->dev, NULL); > + if (IS_ERR(ctz->clk_tempsen)) > + return dev_err_probe(&pdev->dev, PTR_ERR(ctz->clk_tempsen), > + "failed to get clk_tempsen\n"); > + > + cv180x_thermal_init(ctz); > + > + tz = devm_thermal_of_zone_register(&pdev->dev, 0, ctz, > + &cv180x_thermal_ops); > + if (IS_ERR(tz)) > + return dev_err_probe(&pdev->dev, PTR_ERR(tz), > + "failed to register thermal zone\n"); > + > + platform_set_drvdata(pdev, ctz); > + > + return 0; > +} > + > +static int cv180x_thermal_remove(struct platform_device *pdev) > +{ > + struct cv180x_thermal_zone *ctz = platform_get_drvdata(pdev); > + > + cv180x_thermal_deinit(ctz); > + > + return 0; > +} > + > +static int __maybe_unused cv180x_thermal_suspend(struct device *dev) > +{ > + struct cv180x_thermal_zone *ctz = dev_get_drvdata(dev); > + > + cv180x_thermal_deinit(ctz); > + clk_disable_unprepare(ctz->clk_tempsen); > + > + return 0; > +} > + > +static int __maybe_unused cv180x_thermal_resume(struct device *dev) > +{ > + struct cv180x_thermal_zone *ctz = dev_get_drvdata(dev); > + > + clk_prepare_enable(ctz->clk_tempsen); > + cv180x_thermal_init(ctz); > + > + return 0; > +} > + > +static SIMPLE_DEV_PM_OPS(cv180x_thermal_pm_ops, > + cv180x_thermal_suspend, cv180x_thermal_resume); > + > +static struct platform_driver cv180x_thermal_driver = { > + .probe = cv180x_thermal_probe, > + .remove = cv180x_thermal_remove, > + .driver = { > + .name = "cv180x-thermal", > + .pm = &cv180x_thermal_pm_ops, > + .of_match_table = cv180x_thermal_of_match, > + }, > +}; > + > +module_platform_driver(cv180x_thermal_driver); > + > +MODULE_DESCRIPTION("Sophgo CV180x thermal driver"); > +MODULE_AUTHOR("Haylen Chu <heylenay@outlook.com>"); > +MODULE_LICENSE("GPL"); ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4 3/3] thermal: cv180x: Add cv180x thermal driver support 2024-07-16 12:48 ` Chen Wang @ 2024-07-17 5:32 ` Haylen Chu 0 siblings, 0 replies; 23+ messages in thread From: Haylen Chu @ 2024-07-17 5:32 UTC (permalink / raw) To: Chen Wang, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang Cc: linux-pm, devicetree, linux-kernel, linux-riscv On Tue, Jul 16, 2024 at 08:48:13PM +0800, Chen Wang wrote: > > On 2024/7/16 17:42, Haylen Chu wrote: > > Add support for cv180x SoCs integrated thermal sensors. > > > > Signed-off-by: Haylen Chu <heylenay@outlook.com> > > --- > > drivers/thermal/Kconfig | 6 + > > drivers/thermal/Makefile | 1 + > > drivers/thermal/cv180x_thermal.c | 241 +++++++++++++++++++++++++++++++ > > 3 files changed, 248 insertions(+) > > create mode 100644 drivers/thermal/cv180x_thermal.c > cv18xx_thermal.c ? See my comments in patch 1. When you deicide it, update > this for all patches. I would use unified "cv1800" in next revision. Best regards, Haylen > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > index 204ed89a3ec9..f53c973a361d 100644 > > --- a/drivers/thermal/Kconfig > > +++ b/drivers/thermal/Kconfig > > @@ -514,4 +514,10 @@ config LOONGSON2_THERMAL > > is higher than the high temperature threshold or lower than the low > > temperature threshold, the interrupt will occur. > > +config CV180X_THERMAL > Same question above, CV18XX_THERMAL? > > + tristate "Temperature sensor driver for Sophgo CV180X" > > + help > > + If you say yes here you get support for thermal sensor integrated in > > + Sophgo CV180X SoCs. > > + > > endif > > diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile > > index 5cdf7d68687f..5b59bde8a579 100644 > > --- a/drivers/thermal/Makefile > > +++ b/drivers/thermal/Makefile > > @@ -65,3 +65,4 @@ obj-$(CONFIG_AMLOGIC_THERMAL) += amlogic_thermal.o > > obj-$(CONFIG_SPRD_THERMAL) += sprd_thermal.o > > obj-$(CONFIG_KHADAS_MCU_FAN_THERMAL) += khadas_mcu_fan.o > > obj-$(CONFIG_LOONGSON2_THERMAL) += loongson2_thermal.o > > +obj-$(CONFIG_CV180X_THERMAL) += cv180x_thermal.o > > diff --git a/drivers/thermal/cv180x_thermal.c b/drivers/thermal/cv180x_thermal.c > > new file mode 100644 > > index 000000000000..8b726c0ad848 > > --- /dev/null > > +++ b/drivers/thermal/cv180x_thermal.c > > @@ -0,0 +1,241 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2021 Sophgo Inc. > > + * Copyright (C) 2024 Haylen Chu <heylenay@outlook.com> > > + */ > > + > > +#include <linux/bits.h> > > +#include <linux/clk.h> > > +#include <linux/io.h> > > +#include <linux/module.h> > > +#include <linux/of.h> > > +#include <linux/platform_device.h> > > +#include <linux/thermal.h> > > + > > +#define TEMPSEN_VERSION 0x0 > > +#define TEMPSEN_CTRL 0x4 > > +#define TEMPSEN_CTRL_EN BIT(0) > > +#define TEMPSEN_CTRL_SEL_MASK GENMASK(7, 4) > > +#define TEMPSEN_CTRL_SEL_OFFSET 4 > > +#define TEMPSEN_STATUS 0x8 > > +#define TEMPSEN_SET 0xc > > +#define TEMPSEN_SET_CHOPSEL_MASK GENMASK(5, 4) > > +#define TEMPSEN_SET_CHOPSEL_OFFSET 4 > > +#define TEMPSEN_SET_CHOPSEL_128T 0 > > +#define TEMPSEN_SET_CHOPSEL_256T 1 > > +#define TEMPSEN_SET_CHOPSEL_512T 2 > > +#define TEMPSEN_SET_CHOPSEL_1024T 3 > > +#define TEMPSEN_SET_ACCSEL_MASK GENMASK(7, 6) > > +#define TEMPSEN_SET_ACCSEL_OFFSET 6 > > +#define TEMPSEN_SET_ACCSEL_512T 0 > > +#define TEMPSEN_SET_ACCSEL_1024T 1 > > +#define TEMPSEN_SET_ACCSEL_2048T 2 > > +#define TEMPSEN_SET_ACCSEL_4096T 3 > > +#define TEMPSEN_SET_CYC_CLKDIV_MASK GENMASK(15, 8) > > +#define TEMPSEN_SET_CYC_CLKDIV_OFFSET 8 > > +#define TEMPSEN_INTR_EN 0x10 > > +#define TEMPSEN_INTR_CLR 0x14 > > +#define TEMPSEN_INTR_STA 0x18 > > +#define TEMPSEN_INTR_RAW 0x1c > > +#define TEMPSEN_RESULT(n) (0x20 + (n) * 4) > > +#define TEMPSEN_RESULT_RESULT_MASK GENMASK(12, 0) > > +#define TEMPSEN_RESULT_MAX_RESULT_MASK GENMASK(28, 16) > > +#define TEMPSEN_RESULT_CLR_MAX_RESULT BIT(31) > > +#define TEMPSEN_AUTO_PERIOD 0x64 > > +#define TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_MASK GENMASK(23, 0) > > +#define TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_OFFSET 0 > > + > > +struct cv180x_thermal_zone { > > + struct device *dev; > > + void __iomem *base; > > + struct clk *clk_tempsen; > > + u32 sample_cycle; > > +}; > > + > > +static void cv180x_thermal_init(struct cv180x_thermal_zone *ctz) > > +{ > > + void __iomem *base = ctz->base; > > + u32 regval; > > + > > + writel(readl(base + TEMPSEN_INTR_RAW), base + TEMPSEN_INTR_CLR); > > + writel(TEMPSEN_RESULT_CLR_MAX_RESULT, base + TEMPSEN_RESULT(0)); > > + > > + regval = readl(base + TEMPSEN_SET); > > + regval &= ~TEMPSEN_SET_CHOPSEL_MASK; > > + regval &= ~TEMPSEN_SET_ACCSEL_MASK; > > + regval &= ~TEMPSEN_SET_CYC_CLKDIV_MASK; > > + regval |= TEMPSEN_SET_CHOPSEL_1024T << TEMPSEN_SET_CHOPSEL_OFFSET; > > + regval |= TEMPSEN_SET_ACCSEL_2048T << TEMPSEN_SET_ACCSEL_OFFSET; > > + regval |= 0x31 << TEMPSEN_SET_CYC_CLKDIV_OFFSET; > > + writel(regval, base + TEMPSEN_SET); > > + > > + regval = readl(base + TEMPSEN_AUTO_PERIOD); > > + regval &= ~TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_MASK; > > + regval |= ctz->sample_cycle << TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_OFFSET; > > + writel(regval, base + TEMPSEN_AUTO_PERIOD); > > + > > + regval = readl(base + TEMPSEN_CTRL); > > + regval &= ~TEMPSEN_CTRL_SEL_MASK; > > + regval |= 1 << TEMPSEN_CTRL_SEL_OFFSET; > > + regval |= TEMPSEN_CTRL_EN; > > + writel(regval, base + TEMPSEN_CTRL); > > +} > > + > > +static void cv180x_thermal_deinit(struct cv180x_thermal_zone *ct) > > +{ > > + void __iomem *base = ct->base; > > + u32 regval; > > + > > + regval = readl(base + TEMPSEN_CTRL); > > + regval &= ~(TEMPSEN_CTRL_SEL_MASK | TEMPSEN_CTRL_EN); > > + writel(regval, base + TEMPSEN_CTRL); > > + > > + writel(readl(base + TEMPSEN_INTR_RAW), base + TEMPSEN_INTR_CLR); > > +} > > + > > +/* > > + * Raw register value to temperature (mC) formula: > > + * > > + * read_val * 1000 * 716 > > + * Temperature = ----------------------- - 273000 > > + * divider > > + * > > + * where divider should be ticks number of accumulation period, > > + * e.g. 2048 for TEMPSEN_CTRL_ACCSEL_2048T > > + */ > > +static int cv180x_calc_temp(struct cv180x_thermal_zone *ctz, u32 result) > > +{ > > + return (result * 1000) * 716 / 2048 - 273000; > > +} > > + > > +static int cv180x_get_temp(struct thermal_zone_device *tdev, int *temperature) > > +{ > > + struct cv180x_thermal_zone *ctz = thermal_zone_device_priv(tdev); > > + void __iomem *base = ctz->base; > > + u32 result; > > + > > + result = readl(base + TEMPSEN_RESULT(0)) & TEMPSEN_RESULT_RESULT_MASK; > > + *temperature = cv180x_calc_temp(ctz, result); > > + > > + return 0; > > +} > > + > > +static const struct thermal_zone_device_ops cv180x_thermal_ops = { > > + .get_temp = cv180x_get_temp, > > +}; > > + > > +static const struct of_device_id cv180x_thermal_of_match[] = { > > + { .compatible = "sophgo,cv1800-thermal" }, > > + {}, > > +}; > > +MODULE_DEVICE_TABLE(of, cv180x_thermal_of_match); > > + > > +static int > > +cv180x_parse_dt(struct cv180x_thermal_zone *ctz) > > +{ > > + struct device_node *np = ctz->dev->of_node; > > + u32 tmp; > > + > > + if (of_property_read_u32(np, "sample-rate-hz", &tmp)) { > > + ctz->sample_cycle = 1000000; > > + } else { > > + /* sample cycle should be at least 524us */ > > + if (tmp > 1000000 / 524) { > > + dev_err(ctz->dev, "invalid sample rate %d\n", tmp); > > + return -EINVAL; > > + } > > + > > + ctz->sample_cycle = 1000000 / tmp; > > + } > > + > > + return 0; > > +} > > + > > +static int cv180x_thermal_probe(struct platform_device *pdev) > > +{ > > + struct cv180x_thermal_zone *ctz; > > + struct thermal_zone_device *tz; > > + struct resource *res; > > + int ret; > > + > > + ctz = devm_kzalloc(&pdev->dev, sizeof(*ctz), GFP_KERNEL); > > + if (!ctz) > > + return -ENOMEM; > > + > > + ctz->dev = &pdev->dev; > > + > > + ret = cv180x_parse_dt(ctz); > > + if (ret) > > + return dev_err_probe(&pdev->dev, ret, "failed to parse dt\n"); > > + > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + ctz->base = devm_ioremap_resource(&pdev->dev, res); > > + if (IS_ERR(ctz->base)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(ctz->base), > > + "failed to map tempsen registers\n"); > > + > > + ctz->clk_tempsen = devm_clk_get_enabled(&pdev->dev, NULL); > > + if (IS_ERR(ctz->clk_tempsen)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(ctz->clk_tempsen), > > + "failed to get clk_tempsen\n"); > > + > > + cv180x_thermal_init(ctz); > > + > > + tz = devm_thermal_of_zone_register(&pdev->dev, 0, ctz, > > + &cv180x_thermal_ops); > > + if (IS_ERR(tz)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(tz), > > + "failed to register thermal zone\n"); > > + > > + platform_set_drvdata(pdev, ctz); > > + > > + return 0; > > +} > > + > > +static int cv180x_thermal_remove(struct platform_device *pdev) > > +{ > > + struct cv180x_thermal_zone *ctz = platform_get_drvdata(pdev); > > + > > + cv180x_thermal_deinit(ctz); > > + > > + return 0; > > +} > > + > > +static int __maybe_unused cv180x_thermal_suspend(struct device *dev) > > +{ > > + struct cv180x_thermal_zone *ctz = dev_get_drvdata(dev); > > + > > + cv180x_thermal_deinit(ctz); > > + clk_disable_unprepare(ctz->clk_tempsen); > > + > > + return 0; > > +} > > + > > +static int __maybe_unused cv180x_thermal_resume(struct device *dev) > > +{ > > + struct cv180x_thermal_zone *ctz = dev_get_drvdata(dev); > > + > > + clk_prepare_enable(ctz->clk_tempsen); > > + cv180x_thermal_init(ctz); > > + > > + return 0; > > +} > > + > > +static SIMPLE_DEV_PM_OPS(cv180x_thermal_pm_ops, > > + cv180x_thermal_suspend, cv180x_thermal_resume); > > + > > +static struct platform_driver cv180x_thermal_driver = { > > + .probe = cv180x_thermal_probe, > > + .remove = cv180x_thermal_remove, > > + .driver = { > > + .name = "cv180x-thermal", > > + .pm = &cv180x_thermal_pm_ops, > > + .of_match_table = cv180x_thermal_of_match, > > + }, > > +}; > > + > > +module_platform_driver(cv180x_thermal_driver); > > + > > +MODULE_DESCRIPTION("Sophgo CV180x thermal driver"); > > +MODULE_AUTHOR("Haylen Chu <heylenay@outlook.com>"); > > +MODULE_LICENSE("GPL"); ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4 3/3] thermal: cv180x: Add cv180x thermal driver support 2024-07-16 9:42 ` [PATCH v4 3/3] thermal: cv180x: Add cv180x thermal driver support Haylen Chu 2024-07-16 12:48 ` Chen Wang @ 2024-07-17 6:22 ` Inochi Amaoto 2024-07-18 6:49 ` Haylen Chu 1 sibling, 1 reply; 23+ messages in thread From: Inochi Amaoto @ 2024-07-17 6:22 UTC (permalink / raw) To: Haylen Chu, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen Wang, Inochi Amaoto, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang Cc: linux-pm, devicetree, linux-kernel, linux-riscv On Tue, Jul 16, 2024 at 09:42:35AM GMT, Haylen Chu wrote: > Add support for cv180x SoCs integrated thermal sensors. > > Signed-off-by: Haylen Chu <heylenay@outlook.com> > --- > drivers/thermal/Kconfig | 6 + > drivers/thermal/Makefile | 1 + > drivers/thermal/cv180x_thermal.c | 241 +++++++++++++++++++++++++++++++ > 3 files changed, 248 insertions(+) > create mode 100644 drivers/thermal/cv180x_thermal.c > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 204ed89a3ec9..f53c973a361d 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -514,4 +514,10 @@ config LOONGSON2_THERMAL > is higher than the high temperature threshold or lower than the low > temperature threshold, the interrupt will occur. > > +config CV180X_THERMAL > + tristate "Temperature sensor driver for Sophgo CV180X" > + help > + If you say yes here you get support for thermal sensor integrated in > + Sophgo CV180X SoCs. > + > endif > diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile > index 5cdf7d68687f..5b59bde8a579 100644 > --- a/drivers/thermal/Makefile > +++ b/drivers/thermal/Makefile > @@ -65,3 +65,4 @@ obj-$(CONFIG_AMLOGIC_THERMAL) += amlogic_thermal.o > obj-$(CONFIG_SPRD_THERMAL) += sprd_thermal.o > obj-$(CONFIG_KHADAS_MCU_FAN_THERMAL) += khadas_mcu_fan.o > obj-$(CONFIG_LOONGSON2_THERMAL) += loongson2_thermal.o > +obj-$(CONFIG_CV180X_THERMAL) += cv180x_thermal.o > diff --git a/drivers/thermal/cv180x_thermal.c b/drivers/thermal/cv180x_thermal.c > new file mode 100644 > index 000000000000..8b726c0ad848 > --- /dev/null > +++ b/drivers/thermal/cv180x_thermal.c > @@ -0,0 +1,241 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2021 Sophgo Inc. > + * Copyright (C) 2024 Haylen Chu <heylenay@outlook.com> > + */ > + > +#include <linux/bits.h> > +#include <linux/clk.h> > +#include <linux/io.h> > +#include <linux/module.h> > +#include <linux/of.h> > +#include <linux/platform_device.h> > +#include <linux/thermal.h> > + > +#define TEMPSEN_VERSION 0x0 > +#define TEMPSEN_CTRL 0x4 > +#define TEMPSEN_CTRL_EN BIT(0) > +#define TEMPSEN_CTRL_SEL_MASK GENMASK(7, 4) > +#define TEMPSEN_CTRL_SEL_OFFSET 4 > +#define TEMPSEN_STATUS 0x8 > +#define TEMPSEN_SET 0xc > +#define TEMPSEN_SET_CHOPSEL_MASK GENMASK(5, 4) > +#define TEMPSEN_SET_CHOPSEL_OFFSET 4 > +#define TEMPSEN_SET_CHOPSEL_128T 0 > +#define TEMPSEN_SET_CHOPSEL_256T 1 > +#define TEMPSEN_SET_CHOPSEL_512T 2 > +#define TEMPSEN_SET_CHOPSEL_1024T 3 > +#define TEMPSEN_SET_ACCSEL_MASK GENMASK(7, 6) > +#define TEMPSEN_SET_ACCSEL_OFFSET 6 > +#define TEMPSEN_SET_ACCSEL_512T 0 > +#define TEMPSEN_SET_ACCSEL_1024T 1 > +#define TEMPSEN_SET_ACCSEL_2048T 2 > +#define TEMPSEN_SET_ACCSEL_4096T 3 > +#define TEMPSEN_SET_CYC_CLKDIV_MASK GENMASK(15, 8) > +#define TEMPSEN_SET_CYC_CLKDIV_OFFSET 8 > +#define TEMPSEN_INTR_EN 0x10 > +#define TEMPSEN_INTR_CLR 0x14 > +#define TEMPSEN_INTR_STA 0x18 > +#define TEMPSEN_INTR_RAW 0x1c > +#define TEMPSEN_RESULT(n) (0x20 + (n) * 4) > +#define TEMPSEN_RESULT_RESULT_MASK GENMASK(12, 0) > +#define TEMPSEN_RESULT_MAX_RESULT_MASK GENMASK(28, 16) > +#define TEMPSEN_RESULT_CLR_MAX_RESULT BIT(31) > +#define TEMPSEN_AUTO_PERIOD 0x64 > +#define TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_MASK GENMASK(23, 0) > +#define TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_OFFSET 0 > + > +struct cv180x_thermal_zone { > + struct device *dev; > + void __iomem *base; > + struct clk *clk_tempsen; > + u32 sample_cycle; > +}; > + > +static void cv180x_thermal_init(struct cv180x_thermal_zone *ctz) > +{ > + void __iomem *base = ctz->base; > + u32 regval; > + > + writel(readl(base + TEMPSEN_INTR_RAW), base + TEMPSEN_INTR_CLR); > + writel(TEMPSEN_RESULT_CLR_MAX_RESULT, base + TEMPSEN_RESULT(0)); > + > + regval = readl(base + TEMPSEN_SET); > + regval &= ~TEMPSEN_SET_CHOPSEL_MASK; > + regval &= ~TEMPSEN_SET_ACCSEL_MASK; > + regval &= ~TEMPSEN_SET_CYC_CLKDIV_MASK; > + regval |= TEMPSEN_SET_CHOPSEL_1024T << TEMPSEN_SET_CHOPSEL_OFFSET; > + regval |= TEMPSEN_SET_ACCSEL_2048T << TEMPSEN_SET_ACCSEL_OFFSET; > + regval |= 0x31 << TEMPSEN_SET_CYC_CLKDIV_OFFSET; > + writel(regval, base + TEMPSEN_SET); > + > + regval = readl(base + TEMPSEN_AUTO_PERIOD); > + regval &= ~TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_MASK; > + regval |= ctz->sample_cycle << TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_OFFSET; > + writel(regval, base + TEMPSEN_AUTO_PERIOD); > + > + regval = readl(base + TEMPSEN_CTRL); > + regval &= ~TEMPSEN_CTRL_SEL_MASK; > + regval |= 1 << TEMPSEN_CTRL_SEL_OFFSET; > + regval |= TEMPSEN_CTRL_EN; > + writel(regval, base + TEMPSEN_CTRL); > +} > + > +static void cv180x_thermal_deinit(struct cv180x_thermal_zone *ct) > +{ > + void __iomem *base = ct->base; > + u32 regval; > + > + regval = readl(base + TEMPSEN_CTRL); > + regval &= ~(TEMPSEN_CTRL_SEL_MASK | TEMPSEN_CTRL_EN); > + writel(regval, base + TEMPSEN_CTRL); > + > + writel(readl(base + TEMPSEN_INTR_RAW), base + TEMPSEN_INTR_CLR); > +} > + > +/* > + * Raw register value to temperature (mC) formula: > + * > + * read_val * 1000 * 716 > + * Temperature = ----------------------- - 273000 > + * divider > + * > + * where divider should be ticks number of accumulation period, > + * e.g. 2048 for TEMPSEN_CTRL_ACCSEL_2048T > + */ > +static int cv180x_calc_temp(struct cv180x_thermal_zone *ctz, u32 result) > +{ > + return (result * 1000) * 716 / 2048 - 273000; > +} > + > +static int cv180x_get_temp(struct thermal_zone_device *tdev, int *temperature) > +{ > + struct cv180x_thermal_zone *ctz = thermal_zone_device_priv(tdev); > + void __iomem *base = ctz->base; > + u32 result; > + > + result = readl(base + TEMPSEN_RESULT(0)) & TEMPSEN_RESULT_RESULT_MASK; > + *temperature = cv180x_calc_temp(ctz, result); > + > + return 0; > +} > + > +static const struct thermal_zone_device_ops cv180x_thermal_ops = { > + .get_temp = cv180x_get_temp, > +}; > + > +static const struct of_device_id cv180x_thermal_of_match[] = { > + { .compatible = "sophgo,cv1800-thermal" }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, cv180x_thermal_of_match); > + > +static int > +cv180x_parse_dt(struct cv180x_thermal_zone *ctz) > +{ > + struct device_node *np = ctz->dev->of_node; > + u32 tmp; > + > + if (of_property_read_u32(np, "sample-rate-hz", &tmp)) { > + ctz->sample_cycle = 1000000; > + } else { > + /* sample cycle should be at least 524us */ > + if (tmp > 1000000 / 524) { > + dev_err(ctz->dev, "invalid sample rate %d\n", tmp); > + return -EINVAL; > + } > + > + ctz->sample_cycle = 1000000 / tmp; > + } > + > + return 0; > +} > + > +static int cv180x_thermal_probe(struct platform_device *pdev) > +{ > + struct cv180x_thermal_zone *ctz; > + struct thermal_zone_device *tz; > + struct resource *res; > + int ret; > + > + ctz = devm_kzalloc(&pdev->dev, sizeof(*ctz), GFP_KERNEL); > + if (!ctz) > + return -ENOMEM; > + > + ctz->dev = &pdev->dev; > + > + ret = cv180x_parse_dt(ctz); > + if (ret) > + return dev_err_probe(&pdev->dev, ret, "failed to parse dt\n"); > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + ctz->base = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(ctz->base)) > + return dev_err_probe(&pdev->dev, PTR_ERR(ctz->base), > + "failed to map tempsen registers\n"); > + > + ctz->clk_tempsen = devm_clk_get_enabled(&pdev->dev, NULL); > + if (IS_ERR(ctz->clk_tempsen)) > + return dev_err_probe(&pdev->dev, PTR_ERR(ctz->clk_tempsen), > + "failed to get clk_tempsen\n"); > + > + cv180x_thermal_init(ctz); > + > + tz = devm_thermal_of_zone_register(&pdev->dev, 0, ctz, > + &cv180x_thermal_ops); > + if (IS_ERR(tz)) > + return dev_err_probe(&pdev->dev, PTR_ERR(tz), > + "failed to register thermal zone\n"); > + > + platform_set_drvdata(pdev, ctz); > + > + return 0; > +} > + > +static int cv180x_thermal_remove(struct platform_device *pdev) > +{ > + struct cv180x_thermal_zone *ctz = platform_get_drvdata(pdev); > + > + cv180x_thermal_deinit(ctz); > + > + return 0; > +} > + > +static int __maybe_unused cv180x_thermal_suspend(struct device *dev) > +{ > + struct cv180x_thermal_zone *ctz = dev_get_drvdata(dev); > + > + cv180x_thermal_deinit(ctz); > + clk_disable_unprepare(ctz->clk_tempsen); > + > + return 0; > +} > + > +static int __maybe_unused cv180x_thermal_resume(struct device *dev) > +{ > + struct cv180x_thermal_zone *ctz = dev_get_drvdata(dev); > + > + clk_prepare_enable(ctz->clk_tempsen); > + cv180x_thermal_init(ctz); > + > + return 0; > +} > + > +static SIMPLE_DEV_PM_OPS(cv180x_thermal_pm_ops, > + cv180x_thermal_suspend, cv180x_thermal_resume); > + > +static struct platform_driver cv180x_thermal_driver = { > + .probe = cv180x_thermal_probe, > + .remove = cv180x_thermal_remove, > + .driver = { > + .name = "cv180x-thermal", > + .pm = &cv180x_thermal_pm_ops, > + .of_match_table = cv180x_thermal_of_match, > + }, > +}; > + > +module_platform_driver(cv180x_thermal_driver); > + > +MODULE_DESCRIPTION("Sophgo CV180x thermal driver"); > +MODULE_AUTHOR("Haylen Chu <heylenay@outlook.com>"); > +MODULE_LICENSE("GPL"); > -- > 2.45.2 > Where is interrupt handler? I see nothing about it. Regards, Inochi ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4 3/3] thermal: cv180x: Add cv180x thermal driver support 2024-07-17 6:22 ` Inochi Amaoto @ 2024-07-18 6:49 ` Haylen Chu 2024-07-19 1:26 ` Inochi Amaoto 0 siblings, 1 reply; 23+ messages in thread From: Haylen Chu @ 2024-07-18 6:49 UTC (permalink / raw) To: Inochi Amaoto, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen Wang, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang Cc: linux-pm, devicetree, linux-kernel, linux-riscv On Wed, Jul 17, 2024 at 02:22:32PM +0800, Inochi Amaoto wrote: > On Tue, Jul 16, 2024 at 09:42:35AM GMT, Haylen Chu wrote: > > Add support for cv180x SoCs integrated thermal sensors. > > > > Signed-off-by: Haylen Chu <heylenay@outlook.com> > > --- > > drivers/thermal/Kconfig | 6 + > > drivers/thermal/Makefile | 1 + > > drivers/thermal/cv180x_thermal.c | 241 +++++++++++++++++++++++++++++++ > > 3 files changed, 248 insertions(+) > > create mode 100644 drivers/thermal/cv180x_thermal.c > > > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > index 204ed89a3ec9..f53c973a361d 100644 > > --- a/drivers/thermal/Kconfig > > +++ b/drivers/thermal/Kconfig > > @@ -514,4 +514,10 @@ config LOONGSON2_THERMAL > > is higher than the high temperature threshold or lower than the low > > temperature threshold, the interrupt will occur. > > > > +config CV180X_THERMAL > > + tristate "Temperature sensor driver for Sophgo CV180X" > > + help > > + If you say yes here you get support for thermal sensor integrated in > > + Sophgo CV180X SoCs. > > + > > endif > > diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile > > index 5cdf7d68687f..5b59bde8a579 100644 > > --- a/drivers/thermal/Makefile > > +++ b/drivers/thermal/Makefile > > @@ -65,3 +65,4 @@ obj-$(CONFIG_AMLOGIC_THERMAL) += amlogic_thermal.o > > obj-$(CONFIG_SPRD_THERMAL) += sprd_thermal.o > > obj-$(CONFIG_KHADAS_MCU_FAN_THERMAL) += khadas_mcu_fan.o > > obj-$(CONFIG_LOONGSON2_THERMAL) += loongson2_thermal.o > > +obj-$(CONFIG_CV180X_THERMAL) += cv180x_thermal.o > > diff --git a/drivers/thermal/cv180x_thermal.c b/drivers/thermal/cv180x_thermal.c > > new file mode 100644 > > index 000000000000..8b726c0ad848 > > --- /dev/null > > +++ b/drivers/thermal/cv180x_thermal.c > > @@ -0,0 +1,241 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (C) 2021 Sophgo Inc. > > + * Copyright (C) 2024 Haylen Chu <heylenay@outlook.com> > > + */ > > + > > +#include <linux/bits.h> > > +#include <linux/clk.h> > > +#include <linux/io.h> > > +#include <linux/module.h> > > +#include <linux/of.h> > > +#include <linux/platform_device.h> > > +#include <linux/thermal.h> > > + > > +#define TEMPSEN_VERSION 0x0 > > +#define TEMPSEN_CTRL 0x4 > > +#define TEMPSEN_CTRL_EN BIT(0) > > +#define TEMPSEN_CTRL_SEL_MASK GENMASK(7, 4) > > +#define TEMPSEN_CTRL_SEL_OFFSET 4 > > +#define TEMPSEN_STATUS 0x8 > > +#define TEMPSEN_SET 0xc > > +#define TEMPSEN_SET_CHOPSEL_MASK GENMASK(5, 4) > > +#define TEMPSEN_SET_CHOPSEL_OFFSET 4 > > +#define TEMPSEN_SET_CHOPSEL_128T 0 > > +#define TEMPSEN_SET_CHOPSEL_256T 1 > > +#define TEMPSEN_SET_CHOPSEL_512T 2 > > +#define TEMPSEN_SET_CHOPSEL_1024T 3 > > +#define TEMPSEN_SET_ACCSEL_MASK GENMASK(7, 6) > > +#define TEMPSEN_SET_ACCSEL_OFFSET 6 > > +#define TEMPSEN_SET_ACCSEL_512T 0 > > +#define TEMPSEN_SET_ACCSEL_1024T 1 > > +#define TEMPSEN_SET_ACCSEL_2048T 2 > > +#define TEMPSEN_SET_ACCSEL_4096T 3 > > +#define TEMPSEN_SET_CYC_CLKDIV_MASK GENMASK(15, 8) > > +#define TEMPSEN_SET_CYC_CLKDIV_OFFSET 8 > > +#define TEMPSEN_INTR_EN 0x10 > > +#define TEMPSEN_INTR_CLR 0x14 > > +#define TEMPSEN_INTR_STA 0x18 > > +#define TEMPSEN_INTR_RAW 0x1c > > +#define TEMPSEN_RESULT(n) (0x20 + (n) * 4) > > +#define TEMPSEN_RESULT_RESULT_MASK GENMASK(12, 0) > > +#define TEMPSEN_RESULT_MAX_RESULT_MASK GENMASK(28, 16) > > +#define TEMPSEN_RESULT_CLR_MAX_RESULT BIT(31) > > +#define TEMPSEN_AUTO_PERIOD 0x64 > > +#define TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_MASK GENMASK(23, 0) > > +#define TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_OFFSET 0 > > + > > +struct cv180x_thermal_zone { > > + struct device *dev; > > + void __iomem *base; > > + struct clk *clk_tempsen; > > + u32 sample_cycle; > > +}; > > + > > +static void cv180x_thermal_init(struct cv180x_thermal_zone *ctz) > > +{ > > + void __iomem *base = ctz->base; > > + u32 regval; > > + > > + writel(readl(base + TEMPSEN_INTR_RAW), base + TEMPSEN_INTR_CLR); > > + writel(TEMPSEN_RESULT_CLR_MAX_RESULT, base + TEMPSEN_RESULT(0)); > > + > > + regval = readl(base + TEMPSEN_SET); > > + regval &= ~TEMPSEN_SET_CHOPSEL_MASK; > > + regval &= ~TEMPSEN_SET_ACCSEL_MASK; > > + regval &= ~TEMPSEN_SET_CYC_CLKDIV_MASK; > > + regval |= TEMPSEN_SET_CHOPSEL_1024T << TEMPSEN_SET_CHOPSEL_OFFSET; > > + regval |= TEMPSEN_SET_ACCSEL_2048T << TEMPSEN_SET_ACCSEL_OFFSET; > > + regval |= 0x31 << TEMPSEN_SET_CYC_CLKDIV_OFFSET; > > + writel(regval, base + TEMPSEN_SET); > > + > > + regval = readl(base + TEMPSEN_AUTO_PERIOD); > > + regval &= ~TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_MASK; > > + regval |= ctz->sample_cycle << TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_OFFSET; > > + writel(regval, base + TEMPSEN_AUTO_PERIOD); > > + > > + regval = readl(base + TEMPSEN_CTRL); > > + regval &= ~TEMPSEN_CTRL_SEL_MASK; > > + regval |= 1 << TEMPSEN_CTRL_SEL_OFFSET; > > + regval |= TEMPSEN_CTRL_EN; > > + writel(regval, base + TEMPSEN_CTRL); > > +} > > + > > +static void cv180x_thermal_deinit(struct cv180x_thermal_zone *ct) > > +{ > > + void __iomem *base = ct->base; > > + u32 regval; > > + > > + regval = readl(base + TEMPSEN_CTRL); > > + regval &= ~(TEMPSEN_CTRL_SEL_MASK | TEMPSEN_CTRL_EN); > > + writel(regval, base + TEMPSEN_CTRL); > > + > > + writel(readl(base + TEMPSEN_INTR_RAW), base + TEMPSEN_INTR_CLR); > > +} > > + > > +/* > > + * Raw register value to temperature (mC) formula: > > + * > > + * read_val * 1000 * 716 > > + * Temperature = ----------------------- - 273000 > > + * divider > > + * > > + * where divider should be ticks number of accumulation period, > > + * e.g. 2048 for TEMPSEN_CTRL_ACCSEL_2048T > > + */ > > +static int cv180x_calc_temp(struct cv180x_thermal_zone *ctz, u32 result) > > +{ > > + return (result * 1000) * 716 / 2048 - 273000; > > +} > > + > > +static int cv180x_get_temp(struct thermal_zone_device *tdev, int *temperature) > > +{ > > + struct cv180x_thermal_zone *ctz = thermal_zone_device_priv(tdev); > > + void __iomem *base = ctz->base; > > + u32 result; > > + > > + result = readl(base + TEMPSEN_RESULT(0)) & TEMPSEN_RESULT_RESULT_MASK; > > + *temperature = cv180x_calc_temp(ctz, result); > > + > > + return 0; > > +} > > + > > +static const struct thermal_zone_device_ops cv180x_thermal_ops = { > > + .get_temp = cv180x_get_temp, > > +}; > > + > > +static const struct of_device_id cv180x_thermal_of_match[] = { > > + { .compatible = "sophgo,cv1800-thermal" }, > > + {}, > > +}; > > +MODULE_DEVICE_TABLE(of, cv180x_thermal_of_match); > > + > > +static int > > +cv180x_parse_dt(struct cv180x_thermal_zone *ctz) > > +{ > > + struct device_node *np = ctz->dev->of_node; > > + u32 tmp; > > + > > + if (of_property_read_u32(np, "sample-rate-hz", &tmp)) { > > + ctz->sample_cycle = 1000000; > > + } else { > > + /* sample cycle should be at least 524us */ > > + if (tmp > 1000000 / 524) { > > + dev_err(ctz->dev, "invalid sample rate %d\n", tmp); > > + return -EINVAL; > > + } > > + > > + ctz->sample_cycle = 1000000 / tmp; > > + } > > + > > + return 0; > > +} > > + > > +static int cv180x_thermal_probe(struct platform_device *pdev) > > +{ > > + struct cv180x_thermal_zone *ctz; > > + struct thermal_zone_device *tz; > > + struct resource *res; > > + int ret; > > + > > + ctz = devm_kzalloc(&pdev->dev, sizeof(*ctz), GFP_KERNEL); > > + if (!ctz) > > + return -ENOMEM; > > + > > + ctz->dev = &pdev->dev; > > + > > + ret = cv180x_parse_dt(ctz); > > + if (ret) > > + return dev_err_probe(&pdev->dev, ret, "failed to parse dt\n"); > > + > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + ctz->base = devm_ioremap_resource(&pdev->dev, res); > > + if (IS_ERR(ctz->base)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(ctz->base), > > + "failed to map tempsen registers\n"); > > + > > + ctz->clk_tempsen = devm_clk_get_enabled(&pdev->dev, NULL); > > + if (IS_ERR(ctz->clk_tempsen)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(ctz->clk_tempsen), > > + "failed to get clk_tempsen\n"); > > + > > + cv180x_thermal_init(ctz); > > + > > + tz = devm_thermal_of_zone_register(&pdev->dev, 0, ctz, > > + &cv180x_thermal_ops); > > + if (IS_ERR(tz)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(tz), > > + "failed to register thermal zone\n"); > > + > > + platform_set_drvdata(pdev, ctz); > > + > > + return 0; > > +} > > + > > +static int cv180x_thermal_remove(struct platform_device *pdev) > > +{ > > + struct cv180x_thermal_zone *ctz = platform_get_drvdata(pdev); > > + > > + cv180x_thermal_deinit(ctz); > > + > > + return 0; > > +} > > + > > +static int __maybe_unused cv180x_thermal_suspend(struct device *dev) > > +{ > > + struct cv180x_thermal_zone *ctz = dev_get_drvdata(dev); > > + > > + cv180x_thermal_deinit(ctz); > > + clk_disable_unprepare(ctz->clk_tempsen); > > + > > + return 0; > > +} > > + > > +static int __maybe_unused cv180x_thermal_resume(struct device *dev) > > +{ > > + struct cv180x_thermal_zone *ctz = dev_get_drvdata(dev); > > + > > + clk_prepare_enable(ctz->clk_tempsen); > > + cv180x_thermal_init(ctz); > > + > > + return 0; > > +} > > + > > +static SIMPLE_DEV_PM_OPS(cv180x_thermal_pm_ops, > > + cv180x_thermal_suspend, cv180x_thermal_resume); > > + > > +static struct platform_driver cv180x_thermal_driver = { > > + .probe = cv180x_thermal_probe, > > + .remove = cv180x_thermal_remove, > > + .driver = { > > + .name = "cv180x-thermal", > > + .pm = &cv180x_thermal_pm_ops, > > + .of_match_table = cv180x_thermal_of_match, > > + }, > > +}; > > + > > +module_platform_driver(cv180x_thermal_driver); > > + > > +MODULE_DESCRIPTION("Sophgo CV180x thermal driver"); > > +MODULE_AUTHOR("Haylen Chu <heylenay@outlook.com>"); > > +MODULE_LICENSE("GPL"); > > -- > > 2.45.2 > > > > Where is interrupt handler? I see nothing about it. > > Regards, > Inochi Interrupts are not used. This driver implements only polling the temperature. Best regards, Haylen Chu ^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH v4 3/3] thermal: cv180x: Add cv180x thermal driver support 2024-07-18 6:49 ` Haylen Chu @ 2024-07-19 1:26 ` Inochi Amaoto 0 siblings, 0 replies; 23+ messages in thread From: Inochi Amaoto @ 2024-07-19 1:26 UTC (permalink / raw) To: Haylen Chu, Inochi Amaoto, Rafael J. Wysocki, Daniel Lezcano, Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Chen Wang, Paul Walmsley, Palmer Dabbelt, Albert Ou, Jisheng Zhang Cc: linux-pm, devicetree, linux-kernel, linux-riscv On Thu, Jul 18, 2024 at 06:49:05AM GMT, Haylen Chu wrote: > On Wed, Jul 17, 2024 at 02:22:32PM +0800, Inochi Amaoto wrote: > > On Tue, Jul 16, 2024 at 09:42:35AM GMT, Haylen Chu wrote: > > > Add support for cv180x SoCs integrated thermal sensors. > > > > > > Signed-off-by: Haylen Chu <heylenay@outlook.com> > > > --- > > > drivers/thermal/Kconfig | 6 + > > > drivers/thermal/Makefile | 1 + > > > drivers/thermal/cv180x_thermal.c | 241 +++++++++++++++++++++++++++++++ > > > 3 files changed, 248 insertions(+) > > > create mode 100644 drivers/thermal/cv180x_thermal.c > > > > > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > > index 204ed89a3ec9..f53c973a361d 100644 > > > --- a/drivers/thermal/Kconfig > > > +++ b/drivers/thermal/Kconfig > > > @@ -514,4 +514,10 @@ config LOONGSON2_THERMAL > > > is higher than the high temperature threshold or lower than the low > > > temperature threshold, the interrupt will occur. > > > > > > +config CV180X_THERMAL > > > + tristate "Temperature sensor driver for Sophgo CV180X" > > > + help > > > + If you say yes here you get support for thermal sensor integrated in > > > + Sophgo CV180X SoCs. > > > + > > > endif > > > diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile > > > index 5cdf7d68687f..5b59bde8a579 100644 > > > --- a/drivers/thermal/Makefile > > > +++ b/drivers/thermal/Makefile > > > @@ -65,3 +65,4 @@ obj-$(CONFIG_AMLOGIC_THERMAL) += amlogic_thermal.o > > > obj-$(CONFIG_SPRD_THERMAL) += sprd_thermal.o > > > obj-$(CONFIG_KHADAS_MCU_FAN_THERMAL) += khadas_mcu_fan.o > > > obj-$(CONFIG_LOONGSON2_THERMAL) += loongson2_thermal.o > > > +obj-$(CONFIG_CV180X_THERMAL) += cv180x_thermal.o > > > diff --git a/drivers/thermal/cv180x_thermal.c b/drivers/thermal/cv180x_thermal.c > > > new file mode 100644 > > > index 000000000000..8b726c0ad848 > > > --- /dev/null > > > +++ b/drivers/thermal/cv180x_thermal.c > > > @@ -0,0 +1,241 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Copyright (C) 2021 Sophgo Inc. > > > + * Copyright (C) 2024 Haylen Chu <heylenay@outlook.com> > > > + */ > > > + > > > +#include <linux/bits.h> > > > +#include <linux/clk.h> > > > +#include <linux/io.h> > > > +#include <linux/module.h> > > > +#include <linux/of.h> > > > +#include <linux/platform_device.h> > > > +#include <linux/thermal.h> > > > + > > > +#define TEMPSEN_VERSION 0x0 > > > +#define TEMPSEN_CTRL 0x4 > > > +#define TEMPSEN_CTRL_EN BIT(0) > > > +#define TEMPSEN_CTRL_SEL_MASK GENMASK(7, 4) > > > +#define TEMPSEN_CTRL_SEL_OFFSET 4 > > > +#define TEMPSEN_STATUS 0x8 > > > +#define TEMPSEN_SET 0xc > > > +#define TEMPSEN_SET_CHOPSEL_MASK GENMASK(5, 4) > > > +#define TEMPSEN_SET_CHOPSEL_OFFSET 4 > > > +#define TEMPSEN_SET_CHOPSEL_128T 0 > > > +#define TEMPSEN_SET_CHOPSEL_256T 1 > > > +#define TEMPSEN_SET_CHOPSEL_512T 2 > > > +#define TEMPSEN_SET_CHOPSEL_1024T 3 > > > +#define TEMPSEN_SET_ACCSEL_MASK GENMASK(7, 6) > > > +#define TEMPSEN_SET_ACCSEL_OFFSET 6 > > > +#define TEMPSEN_SET_ACCSEL_512T 0 > > > +#define TEMPSEN_SET_ACCSEL_1024T 1 > > > +#define TEMPSEN_SET_ACCSEL_2048T 2 > > > +#define TEMPSEN_SET_ACCSEL_4096T 3 > > > +#define TEMPSEN_SET_CYC_CLKDIV_MASK GENMASK(15, 8) > > > +#define TEMPSEN_SET_CYC_CLKDIV_OFFSET 8 > > > +#define TEMPSEN_INTR_EN 0x10 > > > +#define TEMPSEN_INTR_CLR 0x14 > > > +#define TEMPSEN_INTR_STA 0x18 > > > +#define TEMPSEN_INTR_RAW 0x1c > > > +#define TEMPSEN_RESULT(n) (0x20 + (n) * 4) > > > +#define TEMPSEN_RESULT_RESULT_MASK GENMASK(12, 0) > > > +#define TEMPSEN_RESULT_MAX_RESULT_MASK GENMASK(28, 16) > > > +#define TEMPSEN_RESULT_CLR_MAX_RESULT BIT(31) > > > +#define TEMPSEN_AUTO_PERIOD 0x64 > > > +#define TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_MASK GENMASK(23, 0) > > > +#define TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_OFFSET 0 > > > + > > > +struct cv180x_thermal_zone { > > > + struct device *dev; > > > + void __iomem *base; > > > + struct clk *clk_tempsen; > > > + u32 sample_cycle; > > > +}; > > > + > > > +static void cv180x_thermal_init(struct cv180x_thermal_zone *ctz) > > > +{ > > > + void __iomem *base = ctz->base; > > > + u32 regval; > > > + > > > + writel(readl(base + TEMPSEN_INTR_RAW), base + TEMPSEN_INTR_CLR); > > > + writel(TEMPSEN_RESULT_CLR_MAX_RESULT, base + TEMPSEN_RESULT(0)); > > > + > > > + regval = readl(base + TEMPSEN_SET); > > > + regval &= ~TEMPSEN_SET_CHOPSEL_MASK; > > > + regval &= ~TEMPSEN_SET_ACCSEL_MASK; > > > + regval &= ~TEMPSEN_SET_CYC_CLKDIV_MASK; > > > + regval |= TEMPSEN_SET_CHOPSEL_1024T << TEMPSEN_SET_CHOPSEL_OFFSET; > > > + regval |= TEMPSEN_SET_ACCSEL_2048T << TEMPSEN_SET_ACCSEL_OFFSET; > > > + regval |= 0x31 << TEMPSEN_SET_CYC_CLKDIV_OFFSET; > > > + writel(regval, base + TEMPSEN_SET); > > > + > > > + regval = readl(base + TEMPSEN_AUTO_PERIOD); > > > + regval &= ~TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_MASK; > > > + regval |= ctz->sample_cycle << TEMPSEN_AUTO_PERIOD_AUTO_CYCLE_OFFSET; > > > + writel(regval, base + TEMPSEN_AUTO_PERIOD); > > > + > > > + regval = readl(base + TEMPSEN_CTRL); > > > + regval &= ~TEMPSEN_CTRL_SEL_MASK; > > > + regval |= 1 << TEMPSEN_CTRL_SEL_OFFSET; > > > + regval |= TEMPSEN_CTRL_EN; > > > + writel(regval, base + TEMPSEN_CTRL); > > > +} > > > + > > > +static void cv180x_thermal_deinit(struct cv180x_thermal_zone *ct) > > > +{ > > > + void __iomem *base = ct->base; > > > + u32 regval; > > > + > > > + regval = readl(base + TEMPSEN_CTRL); > > > + regval &= ~(TEMPSEN_CTRL_SEL_MASK | TEMPSEN_CTRL_EN); > > > + writel(regval, base + TEMPSEN_CTRL); > > > + > > > + writel(readl(base + TEMPSEN_INTR_RAW), base + TEMPSEN_INTR_CLR); > > > +} > > > + > > > +/* > > > + * Raw register value to temperature (mC) formula: > > > + * > > > + * read_val * 1000 * 716 > > > + * Temperature = ----------------------- - 273000 > > > + * divider > > > + * > > > + * where divider should be ticks number of accumulation period, > > > + * e.g. 2048 for TEMPSEN_CTRL_ACCSEL_2048T > > > + */ > > > +static int cv180x_calc_temp(struct cv180x_thermal_zone *ctz, u32 result) > > > +{ > > > + return (result * 1000) * 716 / 2048 - 273000; > > > +} > > > + > > > +static int cv180x_get_temp(struct thermal_zone_device *tdev, int *temperature) > > > +{ > > > + struct cv180x_thermal_zone *ctz = thermal_zone_device_priv(tdev); > > > + void __iomem *base = ctz->base; > > > + u32 result; > > > + > > > + result = readl(base + TEMPSEN_RESULT(0)) & TEMPSEN_RESULT_RESULT_MASK; > > > + *temperature = cv180x_calc_temp(ctz, result); > > > + > > > + return 0; > > > +} > > > + > > > +static const struct thermal_zone_device_ops cv180x_thermal_ops = { > > > + .get_temp = cv180x_get_temp, > > > +}; > > > + > > > +static const struct of_device_id cv180x_thermal_of_match[] = { > > > + { .compatible = "sophgo,cv1800-thermal" }, > > > + {}, > > > +}; > > > +MODULE_DEVICE_TABLE(of, cv180x_thermal_of_match); > > > + > > > +static int > > > +cv180x_parse_dt(struct cv180x_thermal_zone *ctz) > > > +{ > > > + struct device_node *np = ctz->dev->of_node; > > > + u32 tmp; > > > + > > > + if (of_property_read_u32(np, "sample-rate-hz", &tmp)) { > > > + ctz->sample_cycle = 1000000; > > > + } else { > > > + /* sample cycle should be at least 524us */ > > > + if (tmp > 1000000 / 524) { > > > + dev_err(ctz->dev, "invalid sample rate %d\n", tmp); > > > + return -EINVAL; > > > + } > > > + > > > + ctz->sample_cycle = 1000000 / tmp; > > > + } > > > + > > > + return 0; > > > +} > > > + > > > +static int cv180x_thermal_probe(struct platform_device *pdev) > > > +{ > > > + struct cv180x_thermal_zone *ctz; > > > + struct thermal_zone_device *tz; > > > + struct resource *res; > > > + int ret; > > > + > > > + ctz = devm_kzalloc(&pdev->dev, sizeof(*ctz), GFP_KERNEL); > > > + if (!ctz) > > > + return -ENOMEM; > > > + > > > + ctz->dev = &pdev->dev; > > > + > > > + ret = cv180x_parse_dt(ctz); > > > + if (ret) > > > + return dev_err_probe(&pdev->dev, ret, "failed to parse dt\n"); > > > + > > > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > > + ctz->base = devm_ioremap_resource(&pdev->dev, res); > > > + if (IS_ERR(ctz->base)) > > > + return dev_err_probe(&pdev->dev, PTR_ERR(ctz->base), > > > + "failed to map tempsen registers\n"); > > > + > > > + ctz->clk_tempsen = devm_clk_get_enabled(&pdev->dev, NULL); > > > + if (IS_ERR(ctz->clk_tempsen)) > > > + return dev_err_probe(&pdev->dev, PTR_ERR(ctz->clk_tempsen), > > > + "failed to get clk_tempsen\n"); > > > + > > > + cv180x_thermal_init(ctz); > > > + > > > + tz = devm_thermal_of_zone_register(&pdev->dev, 0, ctz, > > > + &cv180x_thermal_ops); > > > + if (IS_ERR(tz)) > > > + return dev_err_probe(&pdev->dev, PTR_ERR(tz), > > > + "failed to register thermal zone\n"); > > > + > > > + platform_set_drvdata(pdev, ctz); > > > + > > > + return 0; > > > +} > > > + > > > +static int cv180x_thermal_remove(struct platform_device *pdev) > > > +{ > > > + struct cv180x_thermal_zone *ctz = platform_get_drvdata(pdev); > > > + > > > + cv180x_thermal_deinit(ctz); > > > + > > > + return 0; > > > +} > > > + > > > +static int __maybe_unused cv180x_thermal_suspend(struct device *dev) > > > +{ > > > + struct cv180x_thermal_zone *ctz = dev_get_drvdata(dev); > > > + > > > + cv180x_thermal_deinit(ctz); > > > + clk_disable_unprepare(ctz->clk_tempsen); > > > + > > > + return 0; > > > +} > > > + > > > +static int __maybe_unused cv180x_thermal_resume(struct device *dev) > > > +{ > > > + struct cv180x_thermal_zone *ctz = dev_get_drvdata(dev); > > > + > > > + clk_prepare_enable(ctz->clk_tempsen); > > > + cv180x_thermal_init(ctz); > > > + > > > + return 0; > > > +} > > > + > > > +static SIMPLE_DEV_PM_OPS(cv180x_thermal_pm_ops, > > > + cv180x_thermal_suspend, cv180x_thermal_resume); > > > + > > > +static struct platform_driver cv180x_thermal_driver = { > > > + .probe = cv180x_thermal_probe, > > > + .remove = cv180x_thermal_remove, > > > + .driver = { > > > + .name = "cv180x-thermal", > > > + .pm = &cv180x_thermal_pm_ops, > > > + .of_match_table = cv180x_thermal_of_match, > > > + }, > > > +}; > > > + > > > +module_platform_driver(cv180x_thermal_driver); > > > + > > > +MODULE_DESCRIPTION("Sophgo CV180x thermal driver"); > > > +MODULE_AUTHOR("Haylen Chu <heylenay@outlook.com>"); > > > +MODULE_LICENSE("GPL"); > > > -- > > > 2.45.2 > > > > > > > Where is interrupt handler? I see nothing about it. > > > > Regards, > > Inochi > > Interrupts are not used. This driver implements only polling the > temperature. > > Best regards, > Haylen Chu "xxx is not used" is not the reason for you to not implement it. In addition, interrupt-driven is not just for reading sensors. I have seen something important like critical alert. Drop interrupt support may miss these alert. If you do not want to implement this, move your driver to staging as it is not complete. Regard, Inochi ^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2024-07-19 1:27 UTC | newest] Thread overview: 23+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-07-16 9:40 [PATCH v4 0/3] riscv: sophgo: add thermal sensor support for cv180x/sg200x SoCs Haylen Chu 2024-07-16 9:42 ` [PATCH v4 1/3] dt-bindings: thermal: sophgo,cv1800-thermal: Add Sophgo CV1800 thermal Haylen Chu 2024-07-16 12:43 ` Chen Wang 2024-07-16 15:48 ` Conor Dooley 2024-07-17 0:05 ` Chen Wang 2024-07-17 1:27 ` Inochi Amaoto 2024-07-17 2:14 ` Chen Wang 2024-07-17 2:27 ` Inochi Amaoto 2024-07-17 5:30 ` Haylen Chu 2024-07-17 5:19 ` Haylen Chu 2024-07-17 9:12 ` Krzysztof Kozlowski 2024-07-18 7:04 ` Haylen Chu 2024-07-18 10:53 ` Krzysztof Kozlowski 2024-07-16 15:56 ` Krzysztof Kozlowski 2024-07-16 9:42 ` [PATCH v4 2/3] riscv: dts: sophgo: cv18xx: Add sensor device and thermal zone Haylen Chu 2024-07-16 12:31 ` Chen Wang 2024-07-16 15:56 ` Krzysztof Kozlowski 2024-07-16 9:42 ` [PATCH v4 3/3] thermal: cv180x: Add cv180x thermal driver support Haylen Chu 2024-07-16 12:48 ` Chen Wang 2024-07-17 5:32 ` Haylen Chu 2024-07-17 6:22 ` Inochi Amaoto 2024-07-18 6:49 ` Haylen Chu 2024-07-19 1:26 ` Inochi Amaoto
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).