From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Elder Subject: Re: [PATCH v2 00/17] net: introduce Qualcomm IPA driver Date: Wed, 26 Jun 2019 08:51:02 -0500 Message-ID: <2d40bbcc-1d29-3aa7-e8cb-b0bc5835b8dc@linaro.org> References: <380a6185-7ad1-6be0-060b-e6e5d4126917@linaro.org> <36bca57c999f611353fd9741c55bb2a7@codeaurora.org> <153fafb91267147cf22e2bf102dd822933ec823a.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org To: Arnd Bergmann Cc: Johannes Berg , Dan Williams , Subash Abhinov Kasiviswanathan , abhishek.esse@gmail.com, Ben Chan , Bjorn Andersson , cpratapa@codeaurora.org, David Miller , DTML , Eric Caruso , evgreen@chromium.org, Ilias Apalodimas , Linux ARM , linux-arm-msm@vger.kernel.org, Linux Kernel Mailing List , linux-soc@vger.kernel.org, Networking , syadagir@codeaurora.org List-Id: devicetree@vger.kernel.org On 6/24/19 11:40 AM, Arnd Bergmann wrote: > On Mon, Jun 24, 2019 at 6:21 PM Alex Elder wrote: >> On 6/18/19 2:03 PM, Johannes Berg wrote: >> >>> Really there are two possible ways (and they intersect to some extent). . . . >>> The other is something like IPA or the Intel modem driver, where the >>> device is actually a single (e.g. PCIe) device and just has a single >>> driver, but that single driver offers different channels. >> >> What I don't like about this is that it's more monolithic. It >> seems better to have the low-level IPA or Intel modem driver (or >> any other driver that can support communication between the AP >> and WWAN device) present communication paths that other function- >> specific drivers can attach to and use. > > I did not understand Johannes description as two competing models > for the same code, but rather two kinds of existing hardware that > a new driver system would have to deal with. Based on my understanding of what he said in a message I just responded to, I think you are exactly right. . . . > What we should try to avoid though is a way to add driver private > interfaces that risk having multiple drivers create similar functionality > in incompatible ways. Agreed. -Alex