From: rajpat@codeaurora.org
To: Doug Anderson <dianders@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
msavaliy@qti.qualcomm.com, satya priya <skakit@codeaurora.org>,
Stephen Boyd <sboyd@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH V8 1/8] dt-bindings: spi: Add sc7280 support
Date: Tue, 21 Sep 2021 11:53:26 +0530 [thread overview]
Message-ID: <2d4469be4fa79adaa0a60f42f48bafda@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=X-7-OS0uDFDR+_AksgqLvTVCx0+Z5pbmNCCvqwBrvgBg@mail.gmail.com>
On 2021-09-18 01:32, Doug Anderson wrote:
> Hi,
>
> On Fri, Sep 17, 2021 at 2:49 AM Rajesh Patil <rajpat@codeaurora.org>
> wrote:
>>
>> Add compatible for sc7280 SoC.
>>
>> Signed-off-by: Rajesh Patil <rajpat@codeaurora.org>
>> ---
>> Changes in V8:
>> - As per Doug's comments, added "qcom,sc7280-qspi" compatible
>>
>> Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5
>> ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> index ef5698f..31711fe 100644
>> --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> @@ -21,7 +21,10 @@ allOf:
>> properties:
>> compatible:
>> items:
>> - - const: qcom,sdm845-qspi
>> + - enum:
>> + - qcom,sdm845-qspi
>> + - qcom,sc7280-qspi
>
> Other than the fact that the indentation is wrong (as Rob's bot
> found), this looks good to me. Feel free to add my Reviewed-by when
> you fix the indentation. In theory you could also be nice and add the
> sc7180-qspi at the same time, I think.
>
> -Doug
Adding dt-bindings for sc7180 will send in the follow-up patches.
next prev parent reply other threads:[~2021-09-21 6:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 9:47 [PATCH V8 0/8] Add QSPI and QUPv3 DT nodes for SC7280 SoC Rajesh Patil
2021-09-17 9:48 ` [PATCH V8 1/8] dt-bindings: spi: Add sc7280 support Rajesh Patil
2021-09-17 19:48 ` Rob Herring
2021-09-17 20:02 ` Doug Anderson
2021-09-21 4:04 ` rajpat
2021-09-21 6:23 ` rajpat [this message]
2021-09-17 9:48 ` [PATCH V8 2/8] arm64: dts: sc7280: Add QSPI node Rajesh Patil
2021-09-20 19:38 ` Stephen Boyd
2021-09-17 9:48 ` [PATCH V8 3/8] arm64: dts: sc7280: Configure SPI-NOR FLASH for sc7280-idp Rajesh Patil
2021-09-17 9:48 ` [PATCH V8 4/8] arm64: dts: sc7280: Add QUPv3 wrapper_0 nodes Rajesh Patil
2021-09-20 19:42 ` Stephen Boyd
2021-09-21 4:03 ` rajpat
2021-09-17 9:48 ` [PATCH V8 5/8] arm64: dts: sc7280: Update QUPv3 UART5 DT node Rajesh Patil
2021-09-20 19:43 ` Stephen Boyd
2021-09-17 9:48 ` [PATCH V8 6/8] arm64: dts: sc7280: Configure uart7 to support bluetooth on sc7280-idp Rajesh Patil
2021-09-20 19:44 ` Stephen Boyd
2021-09-17 9:48 ` [PATCH V8 7/8] arm64: dts: sc7280: Add QUPv3 wrapper_1 nodes Rajesh Patil
2021-09-20 19:45 ` Stephen Boyd
2021-09-17 9:48 ` [PATCH V8 8/8] arm64: dts: sc7280: Add aliases for I2C and SPI Rajesh Patil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d4469be4fa79adaa0a60f42f48bafda@codeaurora.org \
--to=rajpat@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=msavaliy@qti.qualcomm.com \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=skakit@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).