Re: [PATCH] arm64: dts: rockchip: Add vcc-supply to SPI flash on rk3399-pinebook-pro

[Dragan Simic <dsimic@manjaro.org>]

Hello Peter,

On 2025-07-30 12:21, Peter Robinson wrote:
> As described in the pinebookpro_v2.1_mainboard_schematic.pdf page 10,
> he SPI Flash's VCC connector is connected to VCC_3V0 power source.
> 
> This fixes the following warning:
> 
>   spi-nor spi1.0: supply vcc not found, using dummy regulator
> 
> Fixes: 5a65505a69884 ("arm64: dts: rockchip: Add initial support for
> Pinebook Pro")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> index 05c48cb09df6f..ee0e6c1947acb 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
> @@ -978,6 +978,7 @@ spiflash: flash@0 {
>  		reg = <0>;
>  		m25p,fast-read;
>  		spi-max-frequency = <10000000>;
> +		vcc-supply = <&vcc_3v0>;
>  	};
>  };

Thanks for the patch!  This addition to the Pinebook Pro device dts
file is looking good to me.  I just checked the schematics of both
Pinebook Pro production versions, i.e. v2.1 and v2.1a, to verify
the addition.

I've got a couple of nitpicks, though.  First, using "Pinebook Pro"
instead of "rk3399-pinebook-pro" in the patch summary would be a bit
more readable.  Second, it would be better to mention the existence
of the second production version, i.e. v2.1, in the patch description,
to clarify that the DT addition applies to both versions, with both
schematics mentioned as references. [1][2]

Anyway, please feel free to include:

Reviewed-by: Dragan Simic <dsimic@manjaro.org>

[1] 
https://files.pine64.org/doc/PinebookPro/pinebookpro_v2.1_mainboard_schematic.pdf
[2] 
https://files.pine64.org/doc/PinebookPro/pinebookpro_schematic_v21a_20220419.pdf