devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: rjw@sisk.pl
Cc: spear-devel@list.st.com, devicetree-discuss@lists.ozlabs.org,
	linux-arm-kernel@lists.infradead.org, cpufreq@vger.kernel.org,
	Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH] fixup! cpufreq: SPEAr: Add CPUFreq driver
Date: Tue, 27 Nov 2012 18:01:39 +0530	[thread overview]
Message-ID: <2d845c8e19392c2b82a243e6e878ae4e5e771c2f.1353785862.git.viresh.kumar@linaro.org> (raw)

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
Hi Rafael,

To make review easier and faster, i am sending incremental patch for SPEAr
cpufreq driver. This patch was earlier discussed here:

http://lists.infradead.org/pipermail/linux-arm-kernel/2012-November/135088.html

 .../devicetree/bindings/cpufreq/cpufreq-spear.txt  | 33 +++++++++++++++-------
 drivers/cpufreq/spear-cpufreq.c                    |  4 +--
 2 files changed, 25 insertions(+), 12 deletions(-)

diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-spear.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-spear.txt
index 4cf2819..f3d44984 100644
--- a/Documentation/devicetree/bindings/cpufreq/cpufreq-spear.txt
+++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-spear.txt
@@ -6,7 +6,6 @@ It supports both uniprocessor (UP) and symmetric multiprocessor (SMP) systems
 which share clock across all CPUs.
 
 Required properties:
-- compatible: "st,cpufreq-spear"
 - cpufreq_tbl: Table of frequencies CPU could be transitioned into, in the
   increasing order.
 
@@ -14,16 +13,30 @@ Optional properties:
 - clock-latency: Specify the possible maximum transition latency for clock, in
   unit of nanoseconds.
 
+Both required and optional properties listed above must be defined under node
+/cpus/cpu@0.
+
 Examples:
 --------
+cpus {
+
+	<...>
+
+	cpu@0 {
+		compatible = "arm,cortex-a9";
+		reg = <0>;
+
+		<...>
+
+		cpufreq_tbl = < 166000
+				200000
+				250000
+				300000
+				400000
+				500000
+				600000 >;
+	};
+
+	<...>
 
-cpufreq {
-	compatible = "st,cpufreq-spear";
-	cpufreq_tbl = < 166000
-			200000
-			250000
-			300000
-			400000
-			500000
-			600000 >;
 };
diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c
index a7fe880..4575cfe 100644
--- a/drivers/cpufreq/spear-cpufreq.c
+++ b/drivers/cpufreq/spear-cpufreq.c
@@ -224,9 +224,9 @@ static int spear_cpufreq_driver_init(void)
 	const __be32 *val;
 	int cnt, i, ret;
 
-	np = of_find_compatible_node(NULL, NULL, "st,cpufreq-spear");
+	np = of_find_node_by_path("/cpus/cpu@0");
 	if (!np) {
-		pr_err("No cpufreq node found");
+		pr_err("No cpu node found");
 		return -ENODEV;
 	}
 
-- 
1.7.12.rc2.18.g61b472e


             reply	other threads:[~2012-11-27 12:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27 12:31 Viresh Kumar [this message]
2012-11-27 19:05 ` [PATCH] fixup! cpufreq: SPEAr: Add CPUFreq driver Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d845c8e19392c2b82a243e6e878ae4e5e771c2f.1353785862.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=cpufreq@vger.kernel.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=rjw@sisk.pl \
    --cc=spear-devel@list.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).