From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Rob Herring <robh+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Damien Le Moal <damien.lemoal@wdc.com>,
Lewis Hanly <lewis.hanly@microchip.com>,
Conor Dooley <conor.dooley@microchip.com>
Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org
Subject: Re: [PATCH 3/9] riscv: dts: microchip: mpfs: Drop empty chosen node
Date: Fri, 26 Nov 2021 10:53:25 +0100 [thread overview]
Message-ID: <2d87b40e-9fdf-572a-a194-afc13fc20dba@canonical.com> (raw)
In-Reply-To: <20211125153131.163533-4-geert@linux-m68k.org>
On 25/11/2021 16:31, Geert Uytterhoeven wrote:
> It does not make sense to have an (empty) chosen node in an SoC-specific
> .dtsi, as chosen is meant for system-specific configuration.
> It is already provided in microchip-mpfs-icicle-kit.dts anyway.
>
> Fixes: 0fa6107eca4186ad ("RISC-V: Initial DTS for Microchip ICICLE board")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> index c9f6d205d2ba1a5e..794da883acb19256 100644
> --- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> +++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
> @@ -9,9 +9,6 @@ / {
> model = "Microchip PolarFire SoC";
> compatible = "microchip,mpfs";
>
> - chosen {
> - };
> -
> cpus {
> #address-cells = <1>;
> #size-cells = <0>;
>
Maybe bootloader expects it? E.g. it looks for node and fills it and
would fail if the node is missing?
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-11-26 9:55 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 15:31 [PATCH 0/9] riscv: dts: Miscellaneous fixes Geert Uytterhoeven
2021-11-25 15:31 ` [PATCH 1/9] riscv: dts: canaan: Fix SPI FLASH node names Geert Uytterhoeven
2021-11-26 4:41 ` Damien Le Moal
2021-11-26 9:54 ` Krzysztof Kozlowski
2021-11-25 15:31 ` [PATCH 2/9] riscv: dts: canaan: Group tuples in interrupt properties Geert Uytterhoeven
2021-11-26 4:42 ` Damien Le Moal
2021-11-26 9:53 ` Krzysztof Kozlowski
2021-11-25 15:31 ` [PATCH 3/9] riscv: dts: microchip: mpfs: Drop empty chosen node Geert Uytterhoeven
2021-11-26 9:53 ` Krzysztof Kozlowski [this message]
2021-11-26 9:57 ` Geert Uytterhoeven
2021-11-26 11:45 ` Conor.Dooley
2021-11-25 15:31 ` [PATCH 4/9] riscv: dts: microchip: Group tuples in interrupt properties Geert Uytterhoeven
2021-11-26 8:42 ` Conor.Dooley
2021-12-03 14:38 ` Geert Uytterhoeven
2021-12-03 15:17 ` Conor.Dooley
2021-11-26 9:52 ` Krzysztof Kozlowski
2021-11-25 15:31 ` [PATCH 5/9] riscv: dts: microchip: mpfs: Fix PLIC node Geert Uytterhoeven
2021-11-26 9:49 ` Krzysztof Kozlowski
2021-11-26 11:49 ` Conor.Dooley
2021-11-25 15:31 ` [PATCH 6/9] riscv: dts: microchip: mpfs: Fix reference clock node Geert Uytterhoeven
2021-11-26 9:48 ` Krzysztof Kozlowski
2021-11-26 10:14 ` Conor.Dooley
2021-11-26 10:47 ` Conor.Dooley
2021-12-03 15:29 ` Conor.Dooley
2021-12-03 15:42 ` Krzysztof Kozlowski
2021-12-03 15:49 ` Geert Uytterhoeven
2021-11-25 15:31 ` [PATCH 7/9] riscv: dts: sifive: Group tuples in register properties Geert Uytterhoeven
2021-11-26 9:46 ` Krzysztof Kozlowski
2021-11-25 15:31 ` [PATCH 8/9] riscv: dts: sifive: Group tuples in interrupt properties Geert Uytterhoeven
2021-11-26 9:46 ` Krzysztof Kozlowski
2021-11-25 15:31 ` [PATCH 9/9] riscv: dts: sifive: fu540-c000: Drop bogus soc node compatible values Geert Uytterhoeven
2021-11-26 9:46 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d87b40e-9fdf-572a-a194-afc13fc20dba@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor.dooley@microchip.com \
--cc=damien.lemoal@wdc.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=lewis.hanly@microchip.com \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).