From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Elliot Berman <quic_eberman@quicinc.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Cc: Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>,
Melody Olvera <quic_molvera@quicinc.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Florian Fainelli <florian.fainelli@broadcom.com>
Subject: Re: [PATCH 2/3] dt-bindings: arm: Document reboot mode magic
Date: Mon, 20 Nov 2023 17:41:52 +0100 [thread overview]
Message-ID: <2d8c7cc2-2c6c-4539-abf3-81700f27b1a7@linaro.org> (raw)
In-Reply-To: <51785de6-2a69-482d-b686-c3694f87e6b7@quicinc.com>
On 20/11/2023 16:45, Elliot Berman wrote:
>
>
> On 11/20/2023 2:56 AM, Krzysztof Kozlowski wrote:
>> On 17/11/2023 22:18, Elliot Berman wrote:
>>> -
>>> -additionalProperties: false
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: arm,psci-1.0
>>> + then:
>>> + $ref: /schemas/power/reset/reboot-mode.yaml#
>>> + properties:
>>> + # "mode-normal" is just SYSTEM_RESET
>>> + mode-normal: false
>>> + patternProperties:
>>> + "^mode-.*$":
>>> + maxItems: 2
>>
>> And if you tested the patch, it would tell you it can be max 1 item.
>
> make dt_binding_check DT_SCHEMA_FILES=arm/psci.yaml
psci.example.dtb: psci: mode-edl: [[0]] is too short
psci.example.dtb: psci: mode-bootloader: [[1, 2]] is too short
psci.example.dtb: psci: Unevaluated properties are not allowed
('mode-bootloader', 'mode-edl' were unexpected)
>
> passes for me. Rob explained why it's working (and why it shouldn't),
> so I'll fix it according to his recommendation in v2.
Then you wanted uint32-matrix.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-20 16:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 21:18 [PATCH 0/3] Implement vendor resets for PSCI SYSTEM_RESET2 Elliot Berman
2023-11-17 21:18 ` [PATCH 1/3] dt-bindings: power: reset: Convert mode-.* properties to array Elliot Berman
2023-11-20 10:52 ` Krzysztof Kozlowski
2023-11-20 15:58 ` Elliot Berman
2023-11-20 15:27 ` Rob Herring
2023-11-17 21:18 ` [PATCH 2/3] dt-bindings: arm: Document reboot mode magic Elliot Berman
2023-11-20 10:56 ` Krzysztof Kozlowski
2023-11-20 15:45 ` Elliot Berman
2023-11-20 16:41 ` Krzysztof Kozlowski [this message]
2023-11-20 17:09 ` Elliot Berman
2023-11-17 21:18 ` [PATCH 3/3] firmware: psci: Read and use vendor reset types Elliot Berman
2023-11-20 10:55 ` [PATCH 0/3] Implement vendor resets for PSCI SYSTEM_RESET2 Krzysztof Kozlowski
2023-11-20 16:03 ` Elliot Berman
2023-11-20 17:27 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d8c7cc2-2c6c-4539-abf3-81700f27b1a7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mark.rutland@arm.com \
--cc=quic_eberman@quicinc.com \
--cc=quic_molvera@quicinc.com \
--cc=quic_satyap@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).