From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Biju Das <biju.das.jz@bp.renesas.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Chris Paterson <Chris.Paterson2@renesas.com>,
Biju Das <biju.das@bp.renesas.com>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node
Date: Tue, 10 May 2022 21:36:10 +0300 [thread overview]
Message-ID: <2d987f83-d59b-b598-1a3d-94bc570b8d89@omp.ru> (raw)
In-Reply-To: <OS0PR01MB5922B28212F59C522FE432B786C99@OS0PR01MB5922.jpnprd01.prod.outlook.com>
On 5/10/22 12:15 PM, Biju Das wrote:
[...]
>>>>> Add ADC node to R9A07G043 (RZ/G2UL) SoC DTSI.
>>>>>
>>>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>>>>> ---
>>>>> arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 21 ++++++++++++++++++++-
>>>>> 1 file changed, 20 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
>>>> b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
>>>>> index b31fb713ae4d..40201a16d653 100644
>>>>> --- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
>>>>> +++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi
>>>>> @@ -483,8 +483,27 @@ i2c3: i2c@10058c00 {
>>>>> };
>>>>>
>>>>> adc: adc@10059000 {
>>>>> + compatible = "renesas,r9a07g043-adc", "renesas,rzg2l-
>>>> adc";
>>>>> reg = <0 0x10059000 0 0x400>;
>>>>> - /* place holder */
>>>>> + interrupts = <GIC_SPI 347 IRQ_TYPE_EDGE_RISING>;
>>>>> + clocks = <&cpg CPG_MOD R9A07G043_ADC_ADCLK>,
>>>>> + <&cpg CPG_MOD R9A07G043_ADC_PCLK>;
>>>>> + clock-names = "adclk", "pclk";
>>>>> + resets = <&cpg R9A07G043_ADC_PRESETN>,
>>>>> + <&cpg R9A07G043_ADC_ADRST_N>;
>>>>> + reset-names = "presetn", "adrst-n";
>>>>
>>>> Not "adrst_n"?
>>>
>>> As per bindings[1], it is correct ie, "adrst-n"
>>
>> Then I think the bindings aren't actually correct. But nevermind... :-)
>
> Why do you think it is not correct? What difference it make, changing from
> adrst-n->adrst_n? Is it violating any DT specification?
>
> Please clarify.
No, I don't think this violates the DT spec. It just doesn't feel right to
convert underscores to hyphens in the "reset-names" prop...
> Regards,
> Biju
MBR, Sergey
next prev parent reply other threads:[~2022-05-10 18:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 18:43 [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node Biju Das
2022-05-10 8:18 ` Sergei Shtylyov
2022-05-10 8:24 ` Biju Das
2022-05-10 9:09 ` Sergey Shtylyov
2022-05-10 9:15 ` Biju Das
2022-05-10 18:36 ` Sergey Shtylyov [this message]
2022-05-11 5:52 ` Biju Das
2022-05-17 8:14 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d987f83-d59b-b598-1a3d-94bc570b8d89@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=Chris.Paterson2@renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox