From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0900CC433EF for ; Tue, 10 May 2022 18:36:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343959AbiEJSg3 (ORCPT ); Tue, 10 May 2022 14:36:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349118AbiEJSgZ (ORCPT ); Tue, 10 May 2022 14:36:25 -0400 Received: from mxout01.lancloud.ru (mxout01.lancloud.ru [45.84.86.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE93550450; Tue, 10 May 2022 11:36:20 -0700 (PDT) Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout01.lancloud.ru 7290120DA93F Received: from LanCloud Received: from LanCloud Received: from LanCloud Subject: Re: [PATCH] arm64: dts: renesas: r9a07g043: Add ADC node To: Biju Das , Rob Herring , Krzysztof Kozlowski CC: Geert Uytterhoeven , Magnus Damm , "linux-renesas-soc@vger.kernel.org" , "devicetree@vger.kernel.org" , Chris Paterson , Biju Das , Prabhakar Mahadev Lad References: <20220505184353.512133-1-biju.das.jz@bp.renesas.com> <530ed78e-bce5-09bd-f0ef-f20de956cfcf@omp.ru> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <2d987f83-d59b-b598-1a3d-94bc570b8d89@omp.ru> Date: Tue, 10 May 2022 21:36:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 5/10/22 12:15 PM, Biju Das wrote: [...] >>>>> Add ADC node to R9A07G043 (RZ/G2UL) SoC DTSI. >>>>> >>>>> Signed-off-by: Biju Das >>>>> --- >>>>> arch/arm64/boot/dts/renesas/r9a07g043.dtsi | 21 ++++++++++++++++++++- >>>>> 1 file changed, 20 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi >>>> b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi >>>>> index b31fb713ae4d..40201a16d653 100644 >>>>> --- a/arch/arm64/boot/dts/renesas/r9a07g043.dtsi >>>>> +++ b/arch/arm64/boot/dts/renesas/r9a07g043.dtsi >>>>> @@ -483,8 +483,27 @@ i2c3: i2c@10058c00 { >>>>> }; >>>>> >>>>> adc: adc@10059000 { >>>>> + compatible = "renesas,r9a07g043-adc", "renesas,rzg2l- >>>> adc"; >>>>> reg = <0 0x10059000 0 0x400>; >>>>> - /* place holder */ >>>>> + interrupts = ; >>>>> + clocks = <&cpg CPG_MOD R9A07G043_ADC_ADCLK>, >>>>> + <&cpg CPG_MOD R9A07G043_ADC_PCLK>; >>>>> + clock-names = "adclk", "pclk"; >>>>> + resets = <&cpg R9A07G043_ADC_PRESETN>, >>>>> + <&cpg R9A07G043_ADC_ADRST_N>; >>>>> + reset-names = "presetn", "adrst-n"; >>>> >>>> Not "adrst_n"? >>> >>> As per bindings[1], it is correct ie, "adrst-n" >> >> Then I think the bindings aren't actually correct. But nevermind... :-) > > Why do you think it is not correct? What difference it make, changing from > adrst-n->adrst_n? Is it violating any DT specification? > > Please clarify. No, I don't think this violates the DT spec. It just doesn't feel right to convert underscores to hyphens in the "reset-names" prop... > Regards, > Biju MBR, Sergey