From: "Andreas Färber" <afaerber@suse.de>
To: Chester Lin <clin@suse.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jose Abreu <joabreu@synopsys.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: netdev@vger.kernel.org, s32@nxp.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <mbrugger@suse.com>,
Jan Petrous <jan.petrous@nxp.com>
Subject: Re: [PATCH v2 1/5] dt-bindings: net: snps, dwmac: add NXP S32CC support
Date: Tue, 29 Nov 2022 15:10:18 +0100 [thread overview]
Message-ID: <2d9c0d89-15c1-bd10-18ac-2e10d451c20f@suse.de> (raw)
In-Reply-To: <20221128054920.2113-2-clin@suse.com>
Hi Chester,
Am 28.11.22 um 06:49 schrieb Chester Lin:
> Add a new compatible string for NXP S32CC DWMAC glue driver. The maxItems
> of clock and clock-names need be increased because S32CC has up to 11
> clocks for its DWMAC.
>
> Signed-off-by: Chester Lin <clin@suse.com>
> ---
>
> No change in v2.
>
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index 13b984076af5..c174d173591e 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -65,6 +65,7 @@ properties:
> - ingenic,x2000-mac
> - loongson,ls2k-dwmac
> - loongson,ls7a-dwmac
> + - nxp,s32cc-dwmac
As we had discussed offline, please change this to nxp,s32g2-dwmac.
S32G3 and S32R45 can then reuse it if they don't require changes; there
is no difference here to how i.MX family or other vendors inherit IP
across SoC models, so Rob's rules apply equally.
Also affects the following patches.
Thanks,
Andreas
> - renesas,r9a06g032-gmac
> - renesas,rzn1-gmac
> - rockchip,px30-gmac
[snip]
--
SUSE Software Solutions Germany GmbH
Frankenstraße 146, 90461 Nürnberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nürnberg)
next prev parent reply other threads:[~2022-11-29 14:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 5:49 [PATCH v2 0/5] Add GMAC support for S32 SoC family Chester Lin
2022-11-28 5:49 ` [PATCH v2 1/5] dt-bindings: net: snps, dwmac: add NXP S32CC support Chester Lin
2022-11-29 14:10 ` Andreas Färber [this message]
2022-11-28 5:49 ` [PATCH v2 2/5] dt-bindings: net: add schema for NXP S32CC dwmac glue driver Chester Lin
2022-11-30 15:51 ` Krzysztof Kozlowski
2022-11-30 17:33 ` Andreas Färber
2022-11-30 18:14 ` Andrew Lunn
2022-12-01 10:18 ` Krzysztof Kozlowski
2022-12-05 7:54 ` Chester Lin
2022-12-05 8:55 ` Krzysztof Kozlowski
2022-12-13 2:46 ` Chester Lin
2022-12-13 7:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d9c0d89-15c1-bd10-18ac-2e10d451c20f@suse.de \
--to=afaerber@suse.de \
--cc=alexandre.torgue@foss.st.com \
--cc=clin@suse.com \
--cc=devicetree@vger.kernel.org \
--cc=jan.petrous@nxp.com \
--cc=joabreu@synopsys.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).