From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92CAFC54FD0 for ; Sun, 26 Apr 2020 11:58:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 644F8206CD for ; Sun, 26 Apr 2020 11:58:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726135AbgDZL6Q (ORCPT ); Sun, 26 Apr 2020 07:58:16 -0400 Received: from mx2.suse.de ([195.135.220.15]:35752 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726125AbgDZL6P (ORCPT ); Sun, 26 Apr 2020 07:58:15 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 2B6DEAA55; Sun, 26 Apr 2020 11:58:12 +0000 (UTC) Subject: Re: [PATCH v3 3/3] ARM: dts: Add Caninos Loucos Labrador To: Matheus Castello Cc: Manivannan Sadhasivam , mark.rutland@arm.com, robh+dt@kernel.org, edgar.righi@lsitec.org.br, igor.lima@lsitec.org.br, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org References: <20200229104358.GB19610@mani> <20200320035104.26139-1-matheus@castello.eng.br> <20200320035104.26139-4-matheus@castello.eng.br> <20200405065137.GC8912@Mani-XPS-13-9360> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Organization: SUSE Software Solutions Germany GmbH Message-ID: <2dca5a4e-933c-0a43-e86f-21b55d75a586@suse.de> Date: Sun, 26 Apr 2020 13:58:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Matheus, Am 23.04.20 um 17:20 schrieb Matheus Castello: > Em 4/5/20 3:51 AM, Manivannan Sadhasivam escreveu: >> On Fri, Mar 20, 2020 at 12:51:04AM -0300, Matheus Castello wrote: >>> Add Device Trees for Caninos Loucos Labrador CoM and base board. >>> Based on the work of Andreas Färber on Lemaker Guitar device tree. >>> >>> Signed-off-by: Matheus Castello >> >> Reviewed-by: Manivannan Sadhasivam >> >> Will queue the series for v5.8 once Andreas is happy with it. > > do you have any more concerns about these patches? Let me know. I've reviewed the preceding two patches. This one here looks okay, Reviewed-by: Andreas Färber but see 2/3 - model here does contain M and your .dtsi is named -v2 - what's the difference to v1? If it's big enough to warrant a separate .dtsi, you should consider whether a versioned compatible string may be needed, too (likely in addition to, not instead of a generic one). No v1 info on the website. Thanks, Andreas -- SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer HRB 36809 (AG Nürnberg)