Re: [PATCH v3,01/11] media: mediatek: vcodec: remove unused parameter

[Nicolas Dufresne <nicolas.dufresne@collabora.com>]

Le samedi 17 juin 2023 à 18:32 +0800, Yunfei Dong a écrit :
> remove unused parameter in struct mtk_vcodec_dev.
> 
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
>  drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c | 2 --
>  drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h     | 6 ------
>  drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c | 2 --
>  3 files changed, 10 deletions(-)
> 
> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
> index d41f2121b94f..03721eda2769 100644
> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
> @@ -336,8 +336,6 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
>  		goto err_core_workq;
>  	}
>  
> -	init_waitqueue_head(&dev->queue);
> -
>  	vfd_dec = video_device_alloc();
>  	if (!vfd_dec) {
>  		mtk_v4l2_err("Failed to allocate video device");
> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h
> index f17d67e781c9..e3230a4d7b8e 100644
> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h
> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h
> @@ -448,10 +448,7 @@ struct mtk_vcodec_enc_pdata {
>   * @decode_workqueue: decode work queue
>   * @encode_workqueue: encode work queue
>   *
> - * @int_cond: used to identify interrupt condition happen
> - * @int_type: used to identify what kind of interrupt condition happen
>   * @dev_mutex: video_device lock
> - * @queue: waitqueue for waiting for completion of device commands
>   *
>   * @dec_irq: decoder irq resource
>   * @enc_irq: h264 encoder irq resource
> @@ -496,10 +493,7 @@ struct mtk_vcodec_dev {
>  
>  	struct workqueue_struct *decode_workqueue;
>  	struct workqueue_struct *encode_workqueue;
> -	int int_cond;
> -	int int_type;
>  	struct mutex dev_mutex;
> -	wait_queue_head_t queue;
>  
>  	int dec_irq;
>  	int enc_irq;
> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c
> index 5df0a22ff3b5..a56652e476c2 100644
> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c
> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c
> @@ -311,8 +311,6 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
>  		goto err_res;
>  	}
>  
> -	init_waitqueue_head(&dev->queue);
> -
>  	/* allocate video device for encoder and register it */
>  	vfd_enc = video_device_alloc();
>  	if (!vfd_enc) {