From: Krzysztof Kozlowski <krzk@kernel.org>
To: yang.li@amlogic.com, Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, Ye He <ye.he@amlogic.com>
Subject: Re: [PATCH v3 2/3] Bluetooth: hci_uart: Add support for Amlogic HCI UART
Date: Mon, 5 Aug 2024 19:29:14 +0200 [thread overview]
Message-ID: <2dee0055-49fe-4920-93d7-5462e88b8096@kernel.org> (raw)
In-Reply-To: <20240802-btaml-v3-2-d8110bf9963f@amlogic.com>
On 02/08/2024 11:39, Yang Li via B4 Relay wrote:
> From: Yang Li <yang.li@amlogic.com>
>
...
> +
> +static const struct aml_device_data data_w155s2 = {
> + .iccm_offset = 256 * 1024,
> +};
> +
> +static const struct aml_device_data data_w265s2 = {
> + .iccm_offset = 384 * 1024,
> +};
> +
> +static const struct of_device_id aml_bluetooth_of_match[] = {
> + { .compatible = "amlogic,w155s2-bt", .data = &data_w155s2 },
> + { .compatible = "amlogic,w265s2-bt", .data = &data_w265s2 },
Your binding says these devices are compatible, but above suggests it is
not. Confusing.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-05 17:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 9:39 [PATCH v3 0/3] Add support for Amlogic HCI UART Yang Li via B4 Relay
2024-08-02 9:39 ` [PATCH v3 1/3] dt-bindings: net: bluetooth: Add support for Amlogic Bluetooth Yang Li via B4 Relay
2024-08-05 17:27 ` Krzysztof Kozlowski
2024-08-06 6:54 ` Yang Li
2024-08-02 9:39 ` [PATCH v3 2/3] Bluetooth: hci_uart: Add support for Amlogic HCI UART Yang Li via B4 Relay
2024-08-02 11:02 ` Paul Menzel
2024-08-06 6:27 ` Yang Li
2024-08-05 17:29 ` Krzysztof Kozlowski [this message]
2024-08-06 8:33 ` Yang Li
2024-08-06 8:37 ` Krzysztof Kozlowski
2024-08-02 9:39 ` [PATCH v3 3/3] MAINTAINERS: Add an entry for Amlogic HCI UART (M: Yang Li) Yang Li via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dee0055-49fe-4920-93d7-5462e88b8096@kernel.org \
--to=krzk@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=will@kernel.org \
--cc=yang.li@amlogic.com \
--cc=ye.he@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).