From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Sibi Sankar <quic_sibis@quicinc.com>,
andersson@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: agross@kernel.org, conor+dt@kernel.org, quic_tdas@quicinc.com,
quic_rjendra@quicinc.com, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, neil.armstrong@linaro.org,
abel.vesa@linaro.org, quic_tsoni@quicinc.com
Subject: Re: [PATCH V2 2/4] clk: qcom: Add Global Clock controller (GCC) driver for X1E80100
Date: Sat, 18 Nov 2023 01:06:06 +0100 [thread overview]
Message-ID: <2e0d2c55-fb2f-4903-a555-f51019942c6e@linaro.org> (raw)
In-Reply-To: <ec9d03f7-7158-4309-9a04-b08c69b89f39@linaro.org>
On 17.11.2023 21:50, Bryan O'Donoghue wrote:
> On 17/11/2023 09:27, Sibi Sankar wrote:
>> * Use shared ops in the x1e80100 gcc driver [Bryan].
>
> This looks better to me now / more consistent with what we have in sc8280xp - where we do try to hit suspend and => retention/parking matters.
Parking the clock is separate from putting the system to sleep.
IIUC we usually use shared ops on clocks that may have different users
(e.g. not only controlled by Linux) and/or that are crucial to the
functioning of hardware (like AXI clocks, which if gated would make
the system crash on any access attempt, from any subsystem, unless
turned on beforehand)
Perhaps Dmitry can use some clearer wording than me..
Konrad
next prev parent reply other threads:[~2023-11-18 0:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 9:27 [PATCH V2 0/4] clk: qcom: Introduce clocks drivers for X1E80100 Sibi Sankar
2023-11-17 9:27 ` [PATCH V2 1/4] dt-bindings: clock: qcom: Add X1E80100 GCC clocks Sibi Sankar
2023-11-17 9:27 ` [PATCH V2 2/4] clk: qcom: Add Global Clock controller (GCC) driver for X1E80100 Sibi Sankar
2023-11-17 20:50 ` Bryan O'Donoghue
2023-11-18 0:06 ` Konrad Dybcio [this message]
2023-11-18 1:52 ` Bryan O'Donoghue
2023-11-20 6:42 ` Sibi Sankar
2023-11-20 11:02 ` Bryan O'Donoghue
2023-11-18 0:01 ` Konrad Dybcio
2023-11-20 11:03 ` Bryan O'Donoghue
2023-11-17 9:27 ` [PATCH V2 3/4] dt-bindings: clock: qcom-rpmhcc: Add RPMHCC bindings " Sibi Sankar
2023-11-17 9:27 ` [PATCH V2 4/4] clk: qcom: rpmh: Add support for X1E80100 rpmh clocks Sibi Sankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e0d2c55-fb2f-4903-a555-f51019942c6e@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).