From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FA6B27FD7D for ; Tue, 21 Oct 2025 20:38:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=210.118.77.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761079094; cv=none; b=iB+iiAh72NfIai2wofewFFD0POy8zByPNvIe7ae2z13o5iDxj66LK0lhYrk8H8ppHz1RY9+QSWvlsISUC9c9pycjrKb+ZzqMaKIydCTwiIchM/0koKnPokvoRhKSC4PXvlhN6LoFf0xTv/+ZmM3mmKPQB10VuRgt5RvEpce1UQg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761079094; c=relaxed/simple; bh=2UzUPa0O7wVHv85721B5teO1x+rf4QPSmTIVyKZAjHQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:From:In-Reply-To: Content-Type:References; b=e2Cm0niJGh7Z6LoWw+/uX64u3meVpG6rApCsNveP51Q0snvgCV4KxMIpwleXcgxsznUJKbFrm5gbuNAydFRssy4KSNK5ru+y8izydOQFiPACoh1Xn4vzHTCddebWFS0DJI7V8HPkpzTQAV2c92sb8m6yFTVuknC0BnOFKkfUWQM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=rSyoE7eE; arc=none smtp.client-ip=210.118.77.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="rSyoE7eE" Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20251021203805euoutp01a3a11403254d637cb2f21ef0ec806884~wnBkAQUWf0192501925euoutp014 for ; Tue, 21 Oct 2025 20:38:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20251021203805euoutp01a3a11403254d637cb2f21ef0ec806884~wnBkAQUWf0192501925euoutp014 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1761079085; bh=WkfTpNuqej1UoTarvASJEkiFQ49zLY0qzCQi5FcT4uM=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=rSyoE7eEsLXh9M8Vms1QePG23J8dvTd+XqkgCf2aNnIF06Guc00f+AK4hNUbm+XLw pJfmkcyYy9OpTo5HtJVNtSFgUe7ZKlhsHWf2/tt/kDnr4zYtaVbCXvNif9xY70br9D /h2cMy3Hj9X/n0N535wxwcgZt96u+dAS1Heq4SpQ= Received: from eusmtip2.samsung.com (unknown [203.254.199.222]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20251021203804eucas1p2c091f1cce52c4d08eeacf8c36604f1fb~wnBisd64H0197501975eucas1p21; Tue, 21 Oct 2025 20:38:04 +0000 (GMT) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20251021203802eusmtip23e28f0f310780cc696c497752fb587eb~wnBhWTpKN1353213532eusmtip2A; Tue, 21 Oct 2025 20:38:02 +0000 (GMT) Message-ID: <2e38e6c2-0548-432f-ae34-daf3972877ac@samsung.com> Date: Tue, 21 Oct 2025 22:38:01 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Betterbird (Windows) Subject: Re: [PATCH v3 06/10] pmdomain: samsung: convert to regmap_read_poll_timeout() To: =?UTF-8?Q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski , Alim Akhtar , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Ulf Hansson Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Content-Language: en-US From: Marek Szyprowski In-Reply-To: <20251016-gs101-pd-v3-6-7b30797396e7@linaro.org> Content-Transfer-Encoding: 8bit X-CMS-MailID: 20251021203804eucas1p2c091f1cce52c4d08eeacf8c36604f1fb X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20251016155855eucas1p2ccc516861548e963761133fc52fc560e X-EPHeader: CA X-CMS-RootMailID: 20251016155855eucas1p2ccc516861548e963761133fc52fc560e References: <20251016-gs101-pd-v3-0-7b30797396e7@linaro.org> <20251016-gs101-pd-v3-6-7b30797396e7@linaro.org> On 16.10.2025 17:58, André Draszik wrote: > Replace the open-coded PD status polling with > regmap_read_poll_timeout(). This change simplifies the code without > altering functionality. > > Signed-off-by: André Draszik > --- > drivers/pmdomain/samsung/exynos-pm-domains.c | 29 ++++++++-------------------- > 1 file changed, 8 insertions(+), 21 deletions(-) > > diff --git a/drivers/pmdomain/samsung/exynos-pm-domains.c b/drivers/pmdomain/samsung/exynos-pm-domains.c > index 383126245811cb8e4dbae3b99ced3f06d3093f35..431548ad9a7e40c0a77ac6672081b600c90ddd4e 100644 > --- a/drivers/pmdomain/samsung/exynos-pm-domains.c > +++ b/drivers/pmdomain/samsung/exynos-pm-domains.c > @@ -13,7 +13,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -35,7 +34,8 @@ struct exynos_pm_domain { > static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on) > { > struct exynos_pm_domain *pd; > - u32 timeout, pwr; > + unsigned int val; > + u32 pwr; > int err; > > pd = container_of(domain, struct exynos_pm_domain, pd); > @@ -45,25 +45,12 @@ static int exynos_pd_power(struct generic_pm_domain *domain, bool power_on) > if (err) > return err; > > - /* Wait max 1ms */ > - timeout = 10; > - while (timeout-- > 0) { > - unsigned int val; > - > - err = regmap_read(pd->regmap, 0x4, &val); > - if (err || ((val & pd->local_pwr_cfg) != pwr)) { > - cpu_relax(); > - usleep_range(80, 100); > - continue; > - } > - > - return 0; > - } > - > - if (!err) > - err = -ETIMEDOUT; > - pr_err("Power domain %s %sable failed: %d\n", domain->name, > - power_on ? "en" : "dis", err); > + err = regmap_read_poll_timeout(pd->regmap, 0x4, val, > + (val & pd->local_pwr_cfg) == pwr, > + 100, 1 * USEC_PER_MSEC); > + if (err) > + pr_err("Power domain %s %sable failed: %d (%#.2x)\n", > + domain->name, power_on ? "en" : "dis", err, val); I've posted my 'tested-by' tag for this patchset, but in meantime I found that this patch causes regression from time to time on old Exynos SoCs (especially when all debugs are disabled). It looks that there are some subtle differences between reading the status register up to 10 times with cpu_relax()+usleep_range() and the regmap_read_poll_timeout(). I will try to analyze this a bit more and provide details, but I suspect that the old loop might take a bit longer than the 1ms from the comment above this code. > return err; > } > Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland