From: Krzysztof Kozlowski <krzk@kernel.org>
To: Eddie James <eajames@linux.ibm.com>, linux-fsi@lists.ozlabs.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org,
joel@jms.id.au, andrew@codeconstruct.com.au
Subject: Re: [PATCH v5 1/9] dt-bindings: fsi: fsi2spi: Document SPI controller child nodes
Date: Wed, 15 May 2024 16:12:09 +0200 [thread overview]
Message-ID: <2e3b20d1-114b-4fbe-819c-437b1530db4f@kernel.org> (raw)
In-Reply-To: <3128df9c-0883-4aad-a959-76f175e8e9a4@linux.ibm.com>
On 15/05/2024 15:06, Eddie James wrote:
>
> On 5/15/24 03:14, Krzysztof Kozlowski wrote:
>> On 14/05/2024 21:54, Eddie James wrote:
>>
>>> properties:
>>> compatible:
>>> @@ -24,6 +23,17 @@ properties:
>>> items:
>>> - description: FSI slave address
>>>
>>> + "#address-cells":
>>> + const: 1
>>> +
>>> + "#size-cells":
>>> + const: 0
>>> +
>>> +patternProperties:
>>> + "^spi@[0-9a-f]+$":
>>> + type: object
>>> + $ref: /schemas/spi/ibm,spi-fsi.yaml
>> Are you sure you do not have dependencies? Nothing was explained about
>> this in the cover letter or changelog.
>
>
> I did mention that it depends on the SPI binding change below the commit
> message in this patch. I guess I should have kept these two together...
Ah, I missed that. Yeah, you must keep them together or wait one more
cycle... Just test bisectability of your patchset.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-15 14:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-14 19:54 [PATCH v5 0/9] dt-bindings: fsi: Convert to json-schema and add missing engines Eddie James
2024-05-14 19:54 ` [PATCH v5 1/9] dt-bindings: fsi: fsi2spi: Document SPI controller child nodes Eddie James
2024-05-14 22:35 ` Rob Herring (Arm)
2024-05-15 8:14 ` Krzysztof Kozlowski
2024-05-15 13:06 ` Eddie James
2024-05-15 14:12 ` Krzysztof Kozlowski [this message]
2024-05-14 19:54 ` [PATCH v5 2/9] dt-bindings: fsi: Document the IBM SCOM engine Eddie James
2024-05-14 19:54 ` [PATCH v5 3/9] dt-bindings: fsi: p9-occ: Convert to json-schema Eddie James
2024-05-15 8:14 ` Krzysztof Kozlowski
2024-05-14 19:54 ` [PATCH v5 4/9] dt-bindings: fsi: Document the IBM SBEFIFO engine Eddie James
2024-05-14 19:54 ` [PATCH v5 5/9] dt-bindings: fsi: Document the FSI controller common properties Eddie James
2024-05-15 14:18 ` Krzysztof Kozlowski
2024-05-15 14:28 ` Eddie James
2024-05-15 14:35 ` Krzysztof Kozlowski
2024-05-15 15:02 ` Eddie James
2024-05-17 9:17 ` Krzysztof Kozlowski
2024-05-22 14:39 ` Rob Herring
2024-05-14 19:54 ` [PATCH v5 6/9] dt-bindings: fsi: ibm,i2cr-fsi-master: Reference common FSI controller Eddie James
2024-05-14 19:54 ` [PATCH v5 7/9] dt-bindings: fsi: ast2600-fsi-master: Convert to json-schema Eddie James
2024-05-15 14:21 ` Krzysztof Kozlowski
2024-05-15 14:24 ` Eddie James
2024-05-15 14:29 ` Krzysztof Kozlowski
2024-05-15 14:29 ` Krzysztof Kozlowski
2024-05-14 19:54 ` [PATCH v5 8/9] dt-bindings: fsi: Document the AST2700 FSI master Eddie James
2024-05-15 14:21 ` Krzysztof Kozlowski
2024-05-14 19:54 ` [PATCH v5 9/9] dt-bindings: fsi: Document the FSI Hub Controller Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e3b20d1-114b-4fbe-819c-437b1530db4f@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).