From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D90CC433F5 for ; Mon, 30 May 2022 06:43:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233048AbiE3Gnh (ORCPT ); Mon, 30 May 2022 02:43:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231516AbiE3Gng (ORCPT ); Mon, 30 May 2022 02:43:36 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D871F3BBD5 for ; Sun, 29 May 2022 23:43:33 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id n124-20020a1c2782000000b003972dfca96cso5835090wmn.4 for ; Sun, 29 May 2022 23:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=gtO8Z2a0J80ts6vwBdzuUpB5ZM5wqbWf0RW3kLdDnho=; b=ywrfVQTd2uOPjB2of3zjWFQnXMt6cpaM0MPEuOKSwyyawy8tIH4E2zzXyZur9x/Rbu NMXD0p8ccYbVF2iL43/unXa1A720NPOEwXYMIRDA7rKMv9qZ5Mz3nJpg/0pkW4GhUxY+ A3NGIgr3Oge2KilwviW5Bdz2wNXDkQSQvTfHoa/AGuQw8MZhhkKB3sOWGH+W0PzuDO5f h9ZEXqx9Pw7dkZOQhkdshnVArkY4WvRAeWcVttnpdST87Jh2Dxg7mDc3m7p40TLLkfnm z0Lfw+qclb5vZjrLaSHizHSDgWUlcAdVeBse3UPNe8PBUeWjSrac1aOnRm+MT4XPcn1r /zog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gtO8Z2a0J80ts6vwBdzuUpB5ZM5wqbWf0RW3kLdDnho=; b=Ri5Y9g43E+URzoOs7aUYCO+cNqTtJanGy07dpftkQDUjBHRZ9hGWsN+5qAlXpzu5AL YaR07vo8WyHbknvtaP3aSW6ixySgjn+meAZQZkBGZHYtzmdltt1prjl8yKkfwSkLgBW4 FnaYzzhWysfNqNclVQT/WpJ08xrcwuRpBTHIy4/Vv6O4FJfid255WAKmkyARLzFtnsv3 C1d7S7ypBvRGnIidSq8OEcTjDtY6k7Zq3xSnsZSeeNpbiDXoi2qmz+vnU57CWuwoP75e oqSHmSOtWicopEhBFcbU7S4YqErpEwYaVasJsYAQCPSo5WoJbgIFINYkxHfa6jsy3jcB 5JHA== X-Gm-Message-State: AOAM531qvrMdUFK6PIf46zv+lrU0u0shgc5sLqq1leVjuCgayQVpKHLm VQ2TQ7l4KOKOW1zkdZaEY2RjSQ== X-Google-Smtp-Source: ABdhPJxSkzwdIOlEJLw3UsLKBXLQIbv3EDsgYcsEHMfrbKU+WtVOIYrdlIECCXjinw3wR9hbG3pAnA== X-Received: by 2002:a7b:c08a:0:b0:397:5859:deb5 with SMTP id r10-20020a7bc08a000000b003975859deb5mr17413447wmh.121.1653893012451; Sun, 29 May 2022 23:43:32 -0700 (PDT) Received: from [192.168.0.179] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id z8-20020a05600c0a0800b0039c15ff3200sm308823wmp.41.2022.05.29.23.43.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 May 2022 23:43:31 -0700 (PDT) Message-ID: <2e6c2995-9204-61fa-0aee-f4ea4cce084c@linaro.org> Date: Mon, 30 May 2022 08:43:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH V2 1/7] dt-bindings: soc: add i.MX93 SRC Content-Language: en-US To: "Peng Fan (OSS)" , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, sboyd@kernel.org, mturquette@baylibre.com, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: aisheng.dong@nxp.com, l.stach@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Peng Fan References: <20220526123411.270083-1-peng.fan@oss.nxp.com> <20220526123411.270083-2-peng.fan@oss.nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20220526123411.270083-2-peng.fan@oss.nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/05/2022 14:34, Peng Fan (OSS) wrote: > From: Peng Fan > > Add bindings for i.MX93 System Reset Controller(SRC). SRC supports > resets and power gating for mixes. > > Signed-off-by: Peng Fan > --- > .../bindings/soc/imx/fsl,imx93-src.yaml | 96 +++++++++++++++++++ Still wrong location of bindings. > include/dt-bindings/power/fsl,imx93-power.h | 11 +++ > 2 files changed, 107 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml > create mode 100644 include/dt-bindings/power/fsl,imx93-power.h > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml > new file mode 100644 > index 000000000000..c20f0bb692fe > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx93-src.yaml > @@ -0,0 +1,96 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/imx/fsl,imx93-src.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX9 System Reset Controller > + > +maintainers: > + - Peng Fan > + > +description: | > + The System Reset Controller (SRC) is responsible for the generation of > + all the system reset signals and boot argument latching. > + > + Its main functions are as follows, > + - Deals with all global system reset sources from other modules, > + and generates global system reset. > + - Responsible for power gating of MIXs (Slices) and their memory > + low power control. > + > +properties: > + compatible: > + items: > + - const: fsl,imx93-src > + - const: syscon > + > + reg: > + maxItems: 1 > + > + slice: > + type: object > + description: list of power domains provided by this controller. Continuing our discussion, I think I see the point of having the node grouping subnodes, just the name confused me. Please make it plural, so "slices". Best regards, Krzysztof