devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Julius Werner <jwerner@chromium.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Dmitry Osipenko <digetx@gmail.com>,
	Doug Anderson <dianders@chromium.org>,
	Jian-Jia Su <jjsu@google.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4 v2] dt-bindings: memory: Factor out common properties of LPDDR bindings
Date: Thu, 8 Sep 2022 16:00:36 +0200	[thread overview]
Message-ID: <2e779d36-116d-a3f4-d9ab-178fdbc6e95a@linaro.org> (raw)
In-Reply-To: <20220907232914.243502-1-jwerner@chromium.org>

On 08/09/2022 01:29, Julius Werner wrote:
> The bindings for different LPDDR versions mostly use the same kinds of
> properties, so in order to reduce duplication when we're adding support
> for more versions, this patch creates a new lpddr-props subschema that
> can be referenced by the others to define these common parts. (This will
> consider a few smaller I/O width and density numbers "legal" for LPDDR3
> that are usually not used there, but this should be harmless.)
> 
> Signed-off-by: Julius Werner <jwerner@chromium.org>
> ---
>  .../ddr/jedec,lpddr-props.yaml                | 52 +++++++++++++++++++
>  .../memory-controllers/ddr/jedec,lpddr2.yaml  | 40 ++------------
>  .../memory-controllers/ddr/jedec,lpddr3.yaml  | 32 ++----------
>  3 files changed, 60 insertions(+), 64 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/memory-controllers/ddr/jedec,lpddr-props.yaml
> 
> Changelog:
> 
> - v2:
>   - removed minItems
>   - reordered io-width enum from lowest to highest
>   - moved `$ref` below `mainainers`
>   - removed part about undeprecating manufacturer-id

Looks good for me. With Rob's ack (for this or for v3) I'll take it via
memory controllers.

Best regards,
Krzysztof

  parent reply	other threads:[~2022-09-08 14:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07 23:29 [PATCH 1/4 v2] dt-bindings: memory: Factor out common properties of LPDDR bindings Julius Werner
2022-09-07 23:29 ` [PATCH 2/4 v2] dt-bindings: memory: Add numeric LPDDR compatible string variant Julius Werner
2022-09-12 21:37   ` Rob Herring
2022-09-07 23:29 ` [PATCH 3/4 v2] dt-bindings: memory: Add jedec,lpddr4 and jedec,lpddr5 bindings Julius Werner
2022-09-08 12:35   ` Rob Herring
2022-09-08 14:04   ` Krzysztof Kozlowski
2022-09-09 23:23     ` Julius Werner
2022-09-07 23:29 ` [PATCH 4/4 v2] dt-bindings: memory: Add jedec,lpddrX-channel binding Julius Werner
2022-09-08 14:00 ` Krzysztof Kozlowski [this message]
2022-09-12 21:32 ` [PATCH 1/4 v2] dt-bindings: memory: Factor out common properties of LPDDR bindings Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e779d36-116d-a3f4-d9ab-178fdbc6e95a@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=digetx@gmail.com \
    --cc=jjsu@google.com \
    --cc=jwerner@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).