From: Florian Fainelli <f.fainelli@gmail.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>,
robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
maxime.ripard@free-electrons.com, wens@csie.org,
peppe.cavallaro@st.com, alexandre.torgue@st.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3 2/4] net: stmmac: dwmac-sun8i: choose internal PHY via phy-is-integrated
Date: Tue, 22 Aug 2017 09:40:32 -0700 [thread overview]
Message-ID: <2e7f8dec-2d7f-6e1a-a462-226dcd023724@gmail.com> (raw)
In-Reply-To: <20170818122118.4925-3-clabbe.montjoie@gmail.com>
On 08/18/2017 05:21 AM, Corentin Labbe wrote:
> The current way to find if the phy is internal is to compare DT phy-mode
> and emac_variant/internal_phy.
> But it will negate a possible future SoC where an external PHY use the
> same phy mode than the internal one.
>
> This patch adds a new way to find if the PHY is internal, via
> the phy-is-integrated property.
>
> Since the internal_phy variable does not need anymore to contain the xMII mode
> used by the internal PHY, it is still used for knowing the presence of an
> internal PHY, so it is modified to a boolean soc_has_internal_phy.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2017-08-22 16:40 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 12:21 [PATCH v3 0/4] net: stmmac: Detect PHY location with phy-is-integrated Corentin Labbe
2017-08-18 12:21 ` [PATCH v3 1/4] ARM: dts: sunxi: h3/h5: represent the mdio switch used by sun8i-h3-emac Corentin Labbe
2017-08-18 12:21 ` [PATCH v3 2/4] net: stmmac: dwmac-sun8i: choose internal PHY via phy-is-integrated Corentin Labbe
2017-08-18 16:58 ` Chen-Yu Tsai
2017-08-22 16:40 ` Florian Fainelli [this message]
2017-08-18 12:21 ` [PATCH v3 3/4] net: stmmac: register parent MDIO node for sun8i-h3-emac Corentin Labbe
2017-08-18 17:05 ` Chen-Yu Tsai
2017-08-19 18:50 ` Corentin Labbe
2017-08-19 20:38 ` Andrew Lunn
[not found] ` <20170819203836.GA21567-g2DYL2Zd6BY@public.gmane.org>
2017-08-20 6:57 ` Corentin Labbe
2017-08-20 14:25 ` Andrew Lunn
2017-08-21 8:10 ` Chen-Yu Tsai
2017-08-21 13:20 ` Andrew Lunn
2017-08-21 13:31 ` Maxime Ripard
[not found] ` <20170821133104.qvrhvwin2rdg4aqo-ZC1Zs529Oq4@public.gmane.org>
2017-08-21 14:23 ` Andrew Lunn
2017-08-22 7:59 ` Corentin Labbe
[not found] ` <20170821142321.GE1703-g2DYL2Zd6BY@public.gmane.org>
2017-08-22 15:39 ` Chen-Yu Tsai
[not found] ` <CAGb2v64E4T=1ff3POGuXZA=MvjGAnKQ6OF6A3sT_cU-=jh6zNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-22 16:40 ` Florian Fainelli
2017-08-22 18:11 ` Corentin Labbe
2017-08-22 18:35 ` Florian Fainelli
2017-08-22 19:37 ` Corentin Labbe
2017-08-23 7:49 ` Maxime Ripard
2017-08-23 16:31 ` Florian Fainelli
2017-08-24 8:12 ` Maxime Ripard
2017-08-24 8:21 ` Corentin Labbe
2017-08-24 19:44 ` Corentin Labbe
2017-08-24 19:59 ` Florian Fainelli
2017-08-25 2:54 ` Chen-Yu Tsai
[not found] ` <CAGb2v64jrDPSff+QL_PQBMaQJ+CcTVbskjuOUd1OqR4smbu+ig-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-08-25 3:05 ` Florian Fainelli
[not found] ` <77ff97c1-9d0a-8b3f-d0b9-25c951f86fec-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-08-25 3:41 ` Chen-Yu Tsai
2017-08-25 3:59 ` Florian Fainelli
2017-08-25 13:26 ` Andrew Lunn
2017-08-22 16:50 ` Maxime Ripard
2017-08-18 12:21 ` [PATCH v3 4/4] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY Corentin Labbe
2017-08-18 16:57 ` Chen-Yu Tsai
2017-08-19 18:33 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e7f8dec-2d7f-6e1a-a462-226dcd023724@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=clabbe.montjoie@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).