From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB73738C for ; Mon, 24 Jun 2024 10:15:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719224141; cv=none; b=WGpQslhOj8MW27A409oPj5jMBxGZnVnp7ahv6zgcRW+Wvpi9Paeu6CXQBS3VfkvIxj17XCYT6I6GqCxQO6Cvn0dywqgaOE+WWy7z/Qh13FMrKF36gVFmqb3whmBgSpkiYoZRQ7/CRTdRejxE+thzvmL/Y48I6B8O3IaqZ+H7i/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719224141; c=relaxed/simple; bh=Uf15in9yBsOauSmzPbkwgFiI/Idp/7pLGB+ASx7TbLg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=clYjw0cxB0qALH3JiifaAOgDfHg9qY0A/IFBLCb6iyWZjvNzT0TRQapaVt57i6usHzBUGyvmkMwDBih4h9NcBOkj3rSeoNHEQUavaKrtEgWVnedI5kIb7EzisEs7+4Ybms8c8SEObcc4n6DMOPuMlJgbHkvE1VE9V8hum7TnP+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wPrjd8Rk; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wPrjd8Rk" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-35f2c9e23d3so3162956f8f.0 for ; Mon, 24 Jun 2024 03:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719224138; x=1719828938; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/RJvLP8dzqTufXS9PhipejEFfcOskTHLuR2GTJoAFLk=; b=wPrjd8RkDEbYDm67J/3d0bmlFoFw+rafxHDy6sElcwVbd+8HrWC+KzGG3MeAsQkV4h MsMhGxYrx6PL7iljYgYslEdjwbFmHakYZV/Pp8hzLeYD/mDyDjQkQXP7TipbP8HoV/Oh R0wWI8BetXBv/SN4WoIoqJ8dOSbsQ3uJx83A13IRkXLcYdAEKYKd7RsTfo8UwOfqoA7N nbwIppusF69CZtgOt2X8+2/A7NqIcS/zLED427n55VBvUBU0DuYXXEyWojA6w5k/E9kn RqpTTxHfqb3+w8hbK981xGy2ZZ4zGmGON8+BtDAwQ5QAKJegtC48GviZiQZMbJrWhNQ8 CBfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719224138; x=1719828938; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/RJvLP8dzqTufXS9PhipejEFfcOskTHLuR2GTJoAFLk=; b=f+2DlApL91veSraWhxQNJWebN3oRjRBP2joO3cEkfJ44qDFibSBkTEtuH+JXxg5qCD tDoBSDkGE1UdqGR3XVyIdzNSfPAYV7ONrQEbTRFp+Ao6ElDZ/dQpm+3VQ3fWRbjHhuoF qiT8rkkAGoXQm8Em0ahBgGv/+9lAC3/OGTqaclj1T4OjFY8XXZ4nptfGDEvNO3gdPP66 M6TpQK2cCvbQIObpvmju3/WnyhK9lHBYy4rG8Rtr2bz8zHiZRSSCjutB17YUyF5kfm8c QjctndMj+8Jbr2OJfrsumnwfwAWDPG5WcdYgOh7z0GqoIFyrqqG9PSZMBK8JVbjwl0fS MEWg== X-Forwarded-Encrypted: i=1; AJvYcCXpEhLbm1TKf6W3zYelszIgyXeGPtpjFnAGGdWlOGWND8/ZBJfzpAAqdtmlijI49krMfi4Y67ZJ7ZqmZYiXI0nsAQhxjlnCUTadxA== X-Gm-Message-State: AOJu0YwFsLRA++22xfg5MHOLAg9mgSbX3pkswBoQYhM8RHvdpRWyi4Jt c18n2W+2nz2LgPB9qFTvI+mHqkq7W2yDDfLEiBVIStStD2wzXy6cthrwq+vsBJDsWcu43P2o2YR 3HiFPfQ== X-Google-Smtp-Source: AGHT+IGu9bYT2sY76dbujOp4sqYEQ5wKe/R7j/GmetRkhI5WP9tkfkIDPJoaPNs/bCovRDm0gZzVdA== X-Received: by 2002:adf:f990:0:b0:361:e909:60c3 with SMTP id ffacd0b85a97d-366e3267fb9mr4020106f8f.9.1719224138105; Mon, 24 Jun 2024 03:15:38 -0700 (PDT) Received: from [192.168.0.3] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42481910d5csm134233475e9.36.2024.06.24.03.15.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jun 2024 03:15:37 -0700 (PDT) Message-ID: <2e8bc8d8-375d-4143-8ffe-7444c9eab42a@linaro.org> Date: Mon, 24 Jun 2024 11:15:36 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 7/8] Add debug log info to vfe block init and set clock rate To: gchan9527@gmail.com, Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , cros-qcom-dts-watchers@chromium.org, Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240624-b4-sc7180-camss-v2-0-0dfecdc50073@gmail.com> <20240624-b4-sc7180-camss-v2-7-0dfecdc50073@gmail.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20240624-b4-sc7180-camss-v2-7-0dfecdc50073@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24/06/2024 00:22, George Chan via B4 Relay wrote: > From: George Chan > > Print out missing clock's name when doing msm_vfe_subdev_init(). > Also print out min clock rate required at vfe_set_clock_rates(). > > Signed-off-by: George Chan > --- > drivers/media/platform/qcom/camss/camss-vfe.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c > index 05fa1adc1661..fbbf38755c0e 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c > @@ -579,7 +579,8 @@ static int vfe_set_clock_rates(struct vfe_device *vfe) > > if (j == clock->nfreqs) { > dev_err(dev, > - "Pixel clock is too high for VFE"); > + "Pixel clock(%s) is too high for VFE, at least set to %lld", > + clock->name, min_rate); Pixel clock %lld Hz is too high for clock %s > return -EINVAL; > } > > @@ -1452,8 +1453,10 @@ int msm_vfe_subdev_init(struct camss *camss, struct vfe_device *vfe, > struct camss_clock *clock = &vfe->clock[i]; > > clock->clk = devm_clk_get(dev, res->clock[i]); > - if (IS_ERR(clock->clk)) > + if (IS_ERR(clock->clk)) { > + dev_err(dev, "missing clk %s", res->clock[i]); > return PTR_ERR(clock->clk); > + } > > clock->name = res->clock[i]; > > A bit inconsistent with the messages stick to "clock %s" --- bod