From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sibi Sankar <quic_sibis@quicinc.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Georgi Djakov <djakov@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Rajendra Nayak <quic_rjendra@quicinc.com>
Subject: Re: [PATCH 03/10] soc: qcom: icc-bwmon: drop unused BWMON_ZONE_COUNT
Date: Tue, 26 Jul 2022 15:29:17 +0200 [thread overview]
Message-ID: <2e928ad6-f11a-145a-d3d3-8ba3ce068a37@linaro.org> (raw)
In-Reply-To: <689ae7a0-bb23-8264-a2ff-40b1b5bbf0af@quicinc.com>
On 26/07/2022 13:25, Sibi Sankar wrote:
> Hey Krzysztof,
>
> Thanks for working on the llcc bwmon patch series!
>
>
> On 7/21/22 12:58 AM, Krzysztof Kozlowski wrote:
>> BWMON_ZONE_COUNT define is not used.
>>
>> Cc: Rajendra Nayak <quic_rjendra@quicinc.com>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> drivers/soc/qcom/icc-bwmon.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/soc/qcom/icc-bwmon.c b/drivers/soc/qcom/icc-bwmon.c
>> index 3415f42523cd..b76a59d9002c 100644
>> --- a/drivers/soc/qcom/icc-bwmon.c
>> +++ b/drivers/soc/qcom/icc-bwmon.c
>> @@ -105,7 +105,6 @@
>>
>> /* BWMONv4 count registers use count unit of 64 kB */
>> #define BWMON_COUNT_UNIT_KB 64
>> -#define BWMON_ZONE_COUNT 0x2d8
>
> Apart from ^^ a few more defines like BWMON_GLOBAL_IRQ_STATUS,
I will remove it in v2.
> THRESHOLD_COUNT_ZONE2_SHIFT were unused as well.
This one was used in the code and later replaced by reg_field shifts.
>
> Reviewed-by: Sibi Sankar <quic_sibis@quicinc.com>
Thanks!
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-26 13:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 19:27 [PATCH 00/10] soc/arm64: qcom: Add LLCC BWMON on SDM845 Krzysztof Kozlowski
2022-07-20 19:27 ` [PATCH 01/10] dt-bindings: interconnect: qcom,msm8998-bwmon: add support for SDM845 LLCC BWMON Krzysztof Kozlowski
2022-07-25 22:32 ` Rob Herring
2022-07-26 11:19 ` Sibi Sankar
2022-07-20 19:27 ` [PATCH 02/10] soc: qcom: icc-bwmon: re-use IRQ enable/clear define Krzysztof Kozlowski
2022-07-26 11:20 ` Sibi Sankar
2022-07-20 19:28 ` [PATCH 03/10] soc: qcom: icc-bwmon: drop unused BWMON_ZONE_COUNT Krzysztof Kozlowski
2022-07-26 11:25 ` Sibi Sankar
2022-07-26 13:29 ` Krzysztof Kozlowski [this message]
2022-07-20 19:28 ` [PATCH 04/10] soc: qcom: icc-bwmon: store reference to varian data in container Krzysztof Kozlowski
2022-07-26 11:28 ` Sibi Sankar
2022-07-20 19:28 ` [PATCH 05/10] soc: qcom: icc-bwmon: clear all registers on init Krzysztof Kozlowski
2022-07-20 19:28 ` [PATCH 06/10] soc: qcom: icc-bwmon: store count unit per variant Krzysztof Kozlowski
2022-07-26 11:37 ` Sibi Sankar
2022-07-20 19:28 ` [PATCH 07/10] soc: qcom: icc-bwmon: use regmap and prepare for BWMON v5 Krzysztof Kozlowski
2022-07-20 19:28 ` [PATCH 08/10] soc: qcom: icc-bwmon: add per-variant quirks Krzysztof Kozlowski
2022-07-20 19:28 ` [PATCH 09/10] soc: qcom: icc-bwmon: add support for SDM845 LLCC BWMON Krzysztof Kozlowski
2022-07-20 19:28 ` [PATCH 10/10] arm64: dts: qcom: sdm845: add " Krzysztof Kozlowski
2022-07-22 1:22 ` Steev Klimaszewski
2022-07-22 17:30 ` Krzysztof Kozlowski
2022-07-23 0:29 ` Steev Klimaszewski
2022-07-23 2:37 ` Steev Klimaszewski
2022-07-23 8:36 ` Krzysztof Kozlowski
2022-07-26 11:31 ` Sibi Sankar
2022-07-26 12:01 ` Sibi Sankar
2022-07-26 13:49 ` Krzysztof Kozlowski
2022-07-26 15:15 ` Steev Klimaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e928ad6-f11a-145a-d3d3-8ba3ce068a37@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).