From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A406FC433EF for ; Tue, 26 Jul 2022 13:29:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238662AbiGZN3Y (ORCPT ); Tue, 26 Jul 2022 09:29:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238509AbiGZN3W (ORCPT ); Tue, 26 Jul 2022 09:29:22 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5F082B1A2 for ; Tue, 26 Jul 2022 06:29:20 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id w15so14610139lft.11 for ; Tue, 26 Jul 2022 06:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=kzYEowobG1GCcVsGATTfBQVx4ZYoqtGaYqMt9Le464E=; b=lHoxWQovthKA2GrOxGoHuCbLjZpwWr3Wlh7056dot4DKAFfIVgkG0X9/r6cqb6+TDZ OZPgf3/NLfKQ46hCkQI5oLLcIlzfQnWXPLnp8qei5lfUKUkHHv0wruzLTH3mim3BdFnM 1xeKuBtdw2mmbMsOWQUku7r1wAsGnlGA5nckVX+WpWLD+hK487Sn8T4gv2i33F3a65uT 24ALNXmSTxaVq71Lw4aQLmo0yKJw2DwMNFFklMhsmGexYn3qNzpQyosSSkGmYyPSsdP6 no+INldFjim//84rveKiIerJUAFYM6dFjuSXJrLJE5voGvjXv0ei+RCSVB3/WRewDOu/ +7iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=kzYEowobG1GCcVsGATTfBQVx4ZYoqtGaYqMt9Le464E=; b=ZXksQKLBdif7QoMKAnnsVEwMIu/j31qitJtMWzfEaypfn6WVfEJlOuV57doBtiWLwn qE0eDnoQRsfvg2f0koiv9OfAT20E3YLyRVrpFbOjcSaiyc/qfM+l3NLE74Ql/iLLJ/mX IWZiWSSsURycrNAz+/QhmfHW9QAwnKZpcnyIelfNmK36tD2WnmerCMrtV4Q1Dp1x/EOp hsqMYrFqdKrr2aeEIawweqougcvGhV45Sc3k+r10f3NCzFrLjz3J5IMn7XuZwsAA45Tp ngJUWB6TMfO2Vx+zxhm1pK6Kr9gYGlV1VHoD7Feay8P+a5kHohs/Ds/3WbfjNyNIzsy/ zF2A== X-Gm-Message-State: AJIora8q8osgJZhc9/mvGVB+/aa/6ebfQL5Y7IW5o82G1bgoacLYImSV yWmFgtUmdANLl3dcpqL0+Oy8Lg== X-Google-Smtp-Source: AGRyM1uzPgOgi6yIT6lZAK0SxMjw4dz41VaKCAnAeaO5QC0g8ea4Em13uGgJdkaREsyjbsOtBTUaHQ== X-Received: by 2002:ac2:4e07:0:b0:48a:18f3:e5fe with SMTP id e7-20020ac24e07000000b0048a18f3e5femr6931153lfr.357.1658842159247; Tue, 26 Jul 2022 06:29:19 -0700 (PDT) Received: from [192.168.3.197] (78-26-46-173.network.trollfjord.no. [78.26.46.173]) by smtp.gmail.com with ESMTPSA id i6-20020a056512318600b0048a78d5c4b5sm1698072lfe.165.2022.07.26.06.29.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jul 2022 06:29:18 -0700 (PDT) Message-ID: <2e928ad6-f11a-145a-d3d3-8ba3ce068a37@linaro.org> Date: Tue, 26 Jul 2022 15:29:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 03/10] soc: qcom: icc-bwmon: drop unused BWMON_ZONE_COUNT Content-Language: en-US To: Sibi Sankar , Andy Gross , Bjorn Andersson , Konrad Dybcio , Georgi Djakov , Rob Herring , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rajendra Nayak References: <20220720192807.130098-1-krzysztof.kozlowski@linaro.org> <20220720192807.130098-4-krzysztof.kozlowski@linaro.org> <689ae7a0-bb23-8264-a2ff-40b1b5bbf0af@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <689ae7a0-bb23-8264-a2ff-40b1b5bbf0af@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/07/2022 13:25, Sibi Sankar wrote: > Hey Krzysztof, > > Thanks for working on the llcc bwmon patch series! > > > On 7/21/22 12:58 AM, Krzysztof Kozlowski wrote: >> BWMON_ZONE_COUNT define is not used. >> >> Cc: Rajendra Nayak >> Signed-off-by: Krzysztof Kozlowski >> --- >> drivers/soc/qcom/icc-bwmon.c | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/drivers/soc/qcom/icc-bwmon.c b/drivers/soc/qcom/icc-bwmon.c >> index 3415f42523cd..b76a59d9002c 100644 >> --- a/drivers/soc/qcom/icc-bwmon.c >> +++ b/drivers/soc/qcom/icc-bwmon.c >> @@ -105,7 +105,6 @@ >> >> /* BWMONv4 count registers use count unit of 64 kB */ >> #define BWMON_COUNT_UNIT_KB 64 >> -#define BWMON_ZONE_COUNT 0x2d8 > > Apart from ^^ a few more defines like BWMON_GLOBAL_IRQ_STATUS, I will remove it in v2. > THRESHOLD_COUNT_ZONE2_SHIFT were unused as well. This one was used in the code and later replaced by reg_field shifts. > > Reviewed-by: Sibi Sankar Thanks! Best regards, Krzysztof