[PATCH 0/8] Add pmics supported in Qualcomm's SDX75 platform

[PATCH 0/8] Add pmics supported in Qualcomm's SDX75 platform

[Rohit Agarwal]

Hi,

This series add support of pmics that are found in SDX75 platform and
add the corresponding regulators in the IDP platform as well.
It also parallely updates the pmic found in SDX65 to PM7250b and add pinctrl
support for the same pmic chip.
This series is based on the new header inclusion[1] and movement of the
regulators level from rpmpd to rpmhpd[2].
This series can be picked after successfully picking [2] and [3] as [1] has
already been applied.

[1] https://lore.kernel.org/all/1689744162-9421-1-git-send-email-quic_rohiagar@quicinc.com/
[2] https://lore.kernel.org/all/1690781104-2290-1-git-send-email-quic_rohiagar@quicinc.com/
[3] https://lore.kernel.org/all/1690461813-22564-1-git-send-email-quic_rohiagar@quicinc.com/

Thanks,
Rohit.

Rohit Agarwal (8):
  arm64: dts: qcom: sdx75: Add spmi node
  arm64: dts: qcom: Add pinctrl gpio support for pm7250b
  arm64: dts: qcom: Add PMIC pm7550ba dtsi
  arm64: dts: qcom: Add PMIC pmx75 dtsi
  ARM: dts: qcom: sdx65-mtp: Update the pmic used in sdx65
  arm64: dts: qcom: sdx75-idp: Add pmics supported in SDX75
  arm64: dts: qcom: sdx75: Add rpmhpd node
  arm64: dts: qcom: sdx75-idp: Add regulator nodes

 arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts |   2 +-
 arch/arm64/boot/dts/qcom/pm7250b.dtsi     |  10 ++
 arch/arm64/boot/dts/qcom/pm7550ba.dtsi    |  70 ++++++++++
 arch/arm64/boot/dts/qcom/pmx75.dtsi       |  64 ++++++++++
 arch/arm64/boot/dts/qcom/sdx75-idp.dts    | 205 ++++++++++++++++++++++++++++++
 arch/arm64/boot/dts/qcom/sdx75.dtsi       |  74 +++++++++++
 6 files changed, 424 insertions(+), 1 deletion(-)
 create mode 100644 arch/arm64/boot/dts/qcom/pm7550ba.dtsi
 create mode 100644 arch/arm64/boot/dts/qcom/pmx75.dtsi

-- 
2.7.4

[PATCH 1/8] arm64: dts: qcom: sdx75: Add spmi node

[Rohit Agarwal]

Add SPMI node to SDX75 dtsi.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sdx75.dtsi | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
index 21d5d55..5e9602cd 100644
--- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
@@ -469,6 +469,29 @@
 			interrupt-controller;
 		};
 
+		spmi_bus: spmi@c400000 {
+			compatible = "qcom,spmi-pmic-arb";
+			reg = <0x0 0xc400000 0x0 0x3000>,
+			      <0x0 0xc500000 0x0 0x400000>,
+			      <0x0 0xc440000 0x0 0x80000>,
+			      <0x0 0xc4c0000 0x0 0x10000>,
+			      <0x0 0xc42d000 0x0 0x4000>;
+			reg-names = "core",
+				    "chnls",
+				    "obsrvr",
+				    "intr",
+				    "cnfg";
+			interrupts-extended = <&pdc 1 IRQ_TYPE_LEVEL_HIGH>;
+			interrupt-names = "periph_irq";
+			qcom,ee = <0>;
+			qcom,channel = <0>;
+			qcom,bus-id = <0>;
+			#address-cells = <2>;
+			#size-cells = <0>;
+			interrupt-controller;
+			#interrupt-cells = <4>;
+		};
+
 		tlmm: pinctrl@f000000 {
 			compatible = "qcom,sdx75-tlmm";
 			reg = <0x0 0x0f000000 0x0 0x400000>;
-- 
2.7.4

Re: [PATCH 1/8] arm64: dts: qcom: sdx75: Add spmi node

[Konrad Dybcio]

On 2.08.2023 11:59, Rohit Agarwal wrote:
> Add SPMI node to SDX75 dtsi.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sdx75.dtsi | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
> index 21d5d55..5e9602cd 100644
> --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
> @@ -469,6 +469,29 @@
>  			interrupt-controller;
>  		};
>  
> +		spmi_bus: spmi@c400000 {
> +			compatible = "qcom,spmi-pmic-arb";
> +			reg = <0x0 0xc400000 0x0 0x3000>,
> +			      <0x0 0xc500000 0x0 0x400000>,
> +			      <0x0 0xc440000 0x0 0x80000>,
> +			      <0x0 0xc4c0000 0x0 0x10000>,
> +			      <0x0 0xc42d000 0x0 0x4000>;
Please pad the address part to 8 hex digits (add leading zeroes)

Konrad

Re: [PATCH 1/8] arm64: dts: qcom: sdx75: Add spmi node

[Rohit Agarwal]

On 8/2/2023 6:10 PM, Konrad Dybcio wrote:
> On 2.08.2023 11:59, Rohit Agarwal wrote:
>> Add SPMI node to SDX75 dtsi.
>>
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sdx75.dtsi | 23 +++++++++++++++++++++++
>>   1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
>> index 21d5d55..5e9602cd 100644
>> --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
>> @@ -469,6 +469,29 @@
>>   			interrupt-controller;
>>   		};
>>   
>> +		spmi_bus: spmi@c400000 {
>> +			compatible = "qcom,spmi-pmic-arb";
>> +			reg = <0x0 0xc400000 0x0 0x3000>,
>> +			      <0x0 0xc500000 0x0 0x400000>,
>> +			      <0x0 0xc440000 0x0 0x80000>,
>> +			      <0x0 0xc4c0000 0x0 0x10000>,
>> +			      <0x0 0xc42d000 0x0 0x4000>;
> Please pad the address part to 8 hex digits (add leading zeroes)
Sure will update this.
Thanks,
Rohit.
>
> Konrad

[PATCH 2/8] arm64: dts: qcom: Add pinctrl gpio support for pm7250b

[Rohit Agarwal]

Add pinctrl gpio dts node for pm7250b.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 arch/arm64/boot/dts/qcom/pm7250b.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
index daa6f1d..f40b9f8 100644
--- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
@@ -147,6 +147,16 @@
 			#size-cells = <0>;
 			status = "disabled";
 		};
+
+		pm7250b_gpios: pinctrl@c000 {
+			compatible = "qcom,pm7250b-gpio", "qcom,spmi-gpio";
+			reg = <0xc000>;
+			gpio-controller;
+			gpio-ranges = <&pm7250b_gpios 0 0 12>;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
 	};
 
 	pmic@3 {
-- 
2.7.4

Re: [PATCH 2/8] arm64: dts: qcom: Add pinctrl gpio support for pm7250b

[Konrad Dybcio]

On 2.08.2023 11:59, Rohit Agarwal wrote:
> Add pinctrl gpio dts node for pm7250b.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

[PATCH 3/8] arm64: dts: qcom: Add PMIC pm7550ba dtsi

[Rohit Agarwal]

Add dtsi for PMIC pm7550ba found in Qualcomm platforms.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 arch/arm64/boot/dts/qcom/pm7550ba.dtsi | 70 ++++++++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/pm7550ba.dtsi

diff --git a/arch/arm64/boot/dts/qcom/pm7550ba.dtsi b/arch/arm64/boot/dts/qcom/pm7550ba.dtsi
new file mode 100644
index 0000000..97b28bb
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/pm7550ba.dtsi
@@ -0,0 +1,70 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
+
+/ {
+	thermal-zones {
+		pm7550ba-thermal {
+			polling-delay-passive = <100>;
+			polling-delay = <0>;
+
+			thermal-sensors = <&pm7550ba_temp>;
+
+			trips {
+				trip0 {
+					temperature = <95000>;
+					hysteresis = <0>;
+					type = "passive";
+				};
+
+				trip1 {
+					temperature = <115000>;
+					hysteresis = <0>;
+					type = "hot";
+				};
+
+				trip2 {
+					temperature = <145000>;
+					hysteresis = <0>;
+					type = "critical";
+				};
+			};
+		};
+	};
+};
+
+&spmi_bus {
+	pm7550ba: pmic@7 {
+		compatible = "qcom,pm7550ba", "qcom,spmi-pmic";
+		reg = <7 SPMI_USID>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		pm7550ba_temp: temp-alarm@a00 {
+			compatible = "qcom,spmi-temp-alarm";
+			reg = <0xa00>;
+			interrupts = <0x7 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+			#thermal-sensor-cells = <0>;
+		};
+
+		pm7550ba_gpios: gpio@8800 {
+			compatible = "qcom,pm7550ba-gpio", "qcom,spmi-gpio";
+			reg = <0x8800>;
+			gpio-controller;
+			gpio-ranges = <&pm7550ba_gpios 0 0 8>;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+
+		pm7550ba_eusb2_repeater: phy@fd00 {
+			compatible = "qcom,pm8550b-eusb2-repeater";
+			reg = <0xfd00>;
+			#phy-cells = <0>;
+		};
+	};
+};
-- 
2.7.4

Re: [PATCH 3/8] arm64: dts: qcom: Add PMIC pm7550ba dtsi

[Konrad Dybcio]

On 2.08.2023 11:59, Rohit Agarwal wrote:
> Add dtsi for PMIC pm7550ba found in Qualcomm platforms.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
Subject: "PMIC pm7550ba" -> "pm7550ba PMIC"

[...]

> +
> +		pm7550ba_eusb2_repeater: phy@fd00 {
> +			compatible = "qcom,pm8550b-eusb2-repeater";
A new compatible should be introduced, so that it goes like this:

compatible = "qcom,pm7550ba-eusb2-repeater", "qcom,pm8550b-eusb2-repeater";

Konrad

Re: [PATCH 3/8] arm64: dts: qcom: Add PMIC pm7550ba dtsi

[Rohit Agarwal]

On 8/2/2023 6:12 PM, Konrad Dybcio wrote:
> On 2.08.2023 11:59, Rohit Agarwal wrote:
>> Add dtsi for PMIC pm7550ba found in Qualcomm platforms.
>>
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> ---
> Subject: "PMIC pm7550ba" -> "pm7550ba PMIC"
>
> [...]
>
>> +
>> +		pm7550ba_eusb2_repeater: phy@fd00 {
>> +			compatible = "qcom,pm8550b-eusb2-repeater";
> A new compatible should be introduced, so that it goes like this:
>
> compatible = "qcom,pm7550ba-eusb2-repeater", "qcom,pm8550b-eusb2-repeater";
Just a doubt, Since the compatible can be same why we need to introduce 
a new compatible.
Should every soc have a compatible string?

Thanks,
Rohit.
>
> Konrad

Re: [PATCH 3/8] arm64: dts: qcom: Add PMIC pm7550ba dtsi

[Konrad Dybcio]

On 2.08.2023 15:13, Rohit Agarwal wrote:
> 
> On 8/2/2023 6:12 PM, Konrad Dybcio wrote:
>> On 2.08.2023 11:59, Rohit Agarwal wrote:
>>> Add dtsi for PMIC pm7550ba found in Qualcomm platforms.
>>>
>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>> ---
>> Subject: "PMIC pm7550ba" -> "pm7550ba PMIC"
>>
>> [...]
>>
>>> +
>>> +        pm7550ba_eusb2_repeater: phy@fd00 {
>>> +            compatible = "qcom,pm8550b-eusb2-repeater";
>> A new compatible should be introduced, so that it goes like this:
>>
>> compatible = "qcom,pm7550ba-eusb2-repeater", "qcom,pm8550b-eusb2-repeater";
> Just a doubt, Since the compatible can be same why we need to introduce a new compatible.
> Should every soc have a compatible string?
If it turns out that we need to add a quirk for PM7550BA 3 years down
the line, this approach lets us fix it for users that never updated
their device trees.

Konrad

Re: [PATCH 3/8] arm64: dts: qcom: Add PMIC pm7550ba dtsi

[Rohit Agarwal]

On 8/2/2023 6:44 PM, Konrad Dybcio wrote:
> On 2.08.2023 15:13, Rohit Agarwal wrote:
>> On 8/2/2023 6:12 PM, Konrad Dybcio wrote:
>>> On 2.08.2023 11:59, Rohit Agarwal wrote:
>>>> Add dtsi for PMIC pm7550ba found in Qualcomm platforms.
>>>>
>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>> ---
>>> Subject: "PMIC pm7550ba" -> "pm7550ba PMIC"
>>>
>>> [...]
>>>
>>>> +
>>>> +        pm7550ba_eusb2_repeater: phy@fd00 {
>>>> +            compatible = "qcom,pm8550b-eusb2-repeater";
>>> A new compatible should be introduced, so that it goes like this:
>>>
>>> compatible = "qcom,pm7550ba-eusb2-repeater", "qcom,pm8550b-eusb2-repeater";
>> Just a doubt, Since the compatible can be same why we need to introduce a new compatible.
>> Should every soc have a compatible string?
> If it turns out that we need to add a quirk for PM7550BA 3 years down
> the line, this approach lets us fix it for users that never updated
> their device trees.
Yes. Got it.

Thanks,
Rohit
>
> Konrad

Re: [PATCH 3/8] arm64: dts: qcom: Add PMIC pm7550ba dtsi

[Pavan Kondeti]

On Wed, Aug 02, 2023 at 03:14:19PM +0200, Konrad Dybcio wrote:
> On 2.08.2023 15:13, Rohit Agarwal wrote:
> > 
> > On 8/2/2023 6:12 PM, Konrad Dybcio wrote:
> >> On 2.08.2023 11:59, Rohit Agarwal wrote:
> >>> Add dtsi for PMIC pm7550ba found in Qualcomm platforms.
> >>>
> >>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> >>> ---
> >> Subject: "PMIC pm7550ba" -> "pm7550ba PMIC"
> >>
> >> [...]
> >>
> >>> +
> >>> +        pm7550ba_eusb2_repeater: phy@fd00 {
> >>> +            compatible = "qcom,pm8550b-eusb2-repeater";
> >> A new compatible should be introduced, so that it goes like this:
> >>
> >> compatible = "qcom,pm7550ba-eusb2-repeater", "qcom,pm8550b-eusb2-repeater";
> > Just a doubt, Since the compatible can be same why we need to introduce a new compatible.
> > Should every soc have a compatible string?
> If it turns out that we need to add a quirk for PM7550BA 3 years down
> the line, this approach lets us fix it for users that never updated
> their device trees.
> 

Trying to make my understanding clear.

eUSB repeater is a peripheral in the PMIC. Do we need a separate
compatible even if the peripheral is same in two different PMIC chips?
I believe eUSB peripheral has some identification registers to apply any
quirks in future.

Adding Jack who would know more about any deltas between the PMICs in
sdx75 and sm8550.

Thanks,
Pavan

Re: [PATCH 3/8] arm64: dts: qcom: Add PMIC pm7550ba dtsi

[Konrad Dybcio]

On 3.08.2023 07:06, Pavan Kondeti wrote:
> 
> On Wed, Aug 02, 2023 at 03:14:19PM +0200, Konrad Dybcio wrote:
>> On 2.08.2023 15:13, Rohit Agarwal wrote:
>>>
>>> On 8/2/2023 6:12 PM, Konrad Dybcio wrote:
>>>> On 2.08.2023 11:59, Rohit Agarwal wrote:
>>>>> Add dtsi for PMIC pm7550ba found in Qualcomm platforms.
>>>>>
>>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>>> ---
>>>> Subject: "PMIC pm7550ba" -> "pm7550ba PMIC"
>>>>
>>>> [...]
>>>>
>>>>> +
>>>>> +        pm7550ba_eusb2_repeater: phy@fd00 {
>>>>> +            compatible = "qcom,pm8550b-eusb2-repeater";
>>>> A new compatible should be introduced, so that it goes like this:
>>>>
>>>> compatible = "qcom,pm7550ba-eusb2-repeater", "qcom,pm8550b-eusb2-repeater";
>>> Just a doubt, Since the compatible can be same why we need to introduce a new compatible.
>>> Should every soc have a compatible string?
>> If it turns out that we need to add a quirk for PM7550BA 3 years down
>> the line, this approach lets us fix it for users that never updated
>> their device trees.
>>
> 
> Trying to make my understanding clear.
> 
> eUSB repeater is a peripheral in the PMIC. Do we need a separate
> compatible even if the peripheral is same in two different PMIC chips?
> I believe eUSB peripheral has some identification registers to apply any
> quirks in future.
Perhaps, but keeping the compatible tied to the specific hardware is
the way to go with the device tree. Most components don't have such
information avaiable, and since at introduction time there wasn't
any better name for it, "pm8550b-eusb2-repeater" was chosen.

Konrad

Re: [PATCH 3/8] arm64: dts: qcom: Add PMIC pm7550ba dtsi

[Pavan Kondeti]

On Fri, Aug 04, 2023 at 06:58:34PM +0200, Konrad Dybcio wrote:
> On 3.08.2023 07:06, Pavan Kondeti wrote:
> > 
> > On Wed, Aug 02, 2023 at 03:14:19PM +0200, Konrad Dybcio wrote:
> >> On 2.08.2023 15:13, Rohit Agarwal wrote:
> >>>
> >>> On 8/2/2023 6:12 PM, Konrad Dybcio wrote:
> >>>> On 2.08.2023 11:59, Rohit Agarwal wrote:
> >>>>> Add dtsi for PMIC pm7550ba found in Qualcomm platforms.
> >>>>>
> >>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> >>>>> ---
> >>>> Subject: "PMIC pm7550ba" -> "pm7550ba PMIC"
> >>>>
> >>>> [...]
> >>>>
> >>>>> +
> >>>>> +        pm7550ba_eusb2_repeater: phy@fd00 {
> >>>>> +            compatible = "qcom,pm8550b-eusb2-repeater";
> >>>> A new compatible should be introduced, so that it goes like this:
> >>>>
> >>>> compatible = "qcom,pm7550ba-eusb2-repeater", "qcom,pm8550b-eusb2-repeater";
> >>> Just a doubt, Since the compatible can be same why we need to introduce a new compatible.
> >>> Should every soc have a compatible string?
> >> If it turns out that we need to add a quirk for PM7550BA 3 years down
> >> the line, this approach lets us fix it for users that never updated
> >> their device trees.
> >>
> > 
> > Trying to make my understanding clear.
> > 
> > eUSB repeater is a peripheral in the PMIC. Do we need a separate
> > compatible even if the peripheral is same in two different PMIC chips?
> > I believe eUSB peripheral has some identification registers to apply any
> > quirks in future.
> Perhaps, but keeping the compatible tied to the specific hardware is
> the way to go with the device tree. Most components don't have such
> information avaiable, and since at introduction time there wasn't
> any better name for it, "pm8550b-eusb2-repeater" was chosen.
> 

Thanks for the clarification and guidance. We can introduce a new
compatible and use qcom,pm8550b-eusb2-repeater as generic binding.

Thanks,
Pavan

[PATCH 4/8] arm64: dts: qcom: Add PMIC pmx75 dtsi

[Rohit Agarwal]

Add dtsi for PMIC pmx75 found in Qualcomm platforms.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 arch/arm64/boot/dts/qcom/pmx75.dtsi | 64 +++++++++++++++++++++++++++++++++++++
 1 file changed, 64 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/pmx75.dtsi

diff --git a/arch/arm64/boot/dts/qcom/pmx75.dtsi b/arch/arm64/boot/dts/qcom/pmx75.dtsi
new file mode 100644
index 0000000..28d99bc
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/pmx75.dtsi
@@ -0,0 +1,64 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+#include <dt-bindings/interrupt-controller/irq.h>
+#include <dt-bindings/spmi/spmi.h>
+
+/ {
+	thermal-zones {
+		pmx75-thermal {
+			polling-delay-passive = <100>;
+			polling-delay = <0>;
+
+			thermal-sensors = <&pmx75_temp>;
+
+			trips {
+				trip0 {
+					temperature = <95000>;
+					hysteresis = <0>;
+					type = "passive";
+				};
+
+				trip1 {
+					temperature = <115000>;
+					hysteresis = <0>;
+					type = "hot";
+				};
+
+				trip2 {
+					temperature = <145000>;
+					hysteresis = <0>;
+					type = "critical";
+				};
+			};
+		};
+	};
+};
+
+&spmi_bus {
+	pmx75: pmic@1 {
+		compatible = "qcom,pmx75", "qcom,spmi-pmic";
+		reg = <1 SPMI_USID>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		pmx75_temp: temp-alarm@a00 {
+			compatible = "qcom,spmi-temp-alarm";
+			reg = <0xa00>;
+			interrupts = <0x1 0xa 0x0 IRQ_TYPE_EDGE_BOTH>;
+			#thermal-sensor-cells = <0>;
+		};
+
+		pmx75_gpios: gpio@8800 {
+			compatible = "qcom,pmx75-gpio", "qcom,spmi-gpio";
+			reg = <0x8800>;
+			gpio-controller;
+			gpio-ranges = <&pmx75_gpios 0 0 16>;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+	};
+};
-- 
2.7.4

Re: [PATCH 4/8] arm64: dts: qcom: Add PMIC pmx75 dtsi

[Konrad Dybcio]

On 2.08.2023 11:59, Rohit Agarwal wrote:
> Add dtsi for PMIC pmx75 found in Qualcomm platforms.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
[...]

> +		pmx75_temp: temp-alarm@a00 {
Nit: can the label be pmx75_temp_alarm? "temp" is too vague, I think.

Konrad

Re: [PATCH 4/8] arm64: dts: qcom: Add PMIC pmx75 dtsi

[Rohit Agarwal]

On 8/2/2023 6:16 PM, Konrad Dybcio wrote:
> On 2.08.2023 11:59, Rohit Agarwal wrote:
>> Add dtsi for PMIC pmx75 found in Qualcomm platforms.
>>
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> ---
> [...]
>
>> +		pmx75_temp: temp-alarm@a00 {
> Nit: can the label be pmx75_temp_alarm? "temp" is too vague, I think.
Sure will update this.
Thanks,
Rohit.
>
> Konrad

[PATCH 5/8] ARM: dts: qcom: sdx65-mtp: Update the pmic used in sdx65

[Rohit Agarwal]

Update the pmic used in sdx65 platform to pm7250b.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
index 02d8d6e..fcf1c51 100644
--- a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
+++ b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
@@ -7,7 +7,7 @@
 #include "qcom-sdx65.dtsi"
 #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
 #include <arm64/qcom/pmk8350.dtsi>
-#include <arm64/qcom/pm8150b.dtsi>
+#include <arm64/qcom/pm7250b.dtsi>
 #include "qcom-pmx65.dtsi"
 
 / {
-- 
2.7.4

Re: [PATCH 5/8] ARM: dts: qcom: sdx65-mtp: Update the pmic used in sdx65

[Konrad Dybcio]

On 2.08.2023 11:59, Rohit Agarwal wrote:
> Update the pmic used in sdx65 platform to pm7250b.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
Has this changed with a board revision? Was this wrong before?

Need more explanation, and this definitely deserves a Fixes: tag.

Konrad
>  arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
> index 02d8d6e..fcf1c51 100644
> --- a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
> @@ -7,7 +7,7 @@
>  #include "qcom-sdx65.dtsi"
>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>  #include <arm64/qcom/pmk8350.dtsi>
> -#include <arm64/qcom/pm8150b.dtsi>
> +#include <arm64/qcom/pm7250b.dtsi>
>  #include "qcom-pmx65.dtsi"
>  
>  / {

Re: [PATCH 5/8] ARM: dts: qcom: sdx65-mtp: Update the pmic used in sdx65

[Rohit Agarwal]

On 8/2/2023 6:16 PM, Konrad Dybcio wrote:
> On 2.08.2023 11:59, Rohit Agarwal wrote:
>> Update the pmic used in sdx65 platform to pm7250b.
>>
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> ---
> Has this changed with a board revision? Was this wrong before?
>
> Need more explanation, and this definitely deserves a Fixes: tag.
Just went through the sdx65 pmics and found this mistake so updating here.
Although the validations were successful with the earlier pmic as well 
when originally pushed the patch.
Will add the fixes tag.

Thanks,
Rohit.
>
> Konrad
>>   arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
>> index 02d8d6e..fcf1c51 100644
>> --- a/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
>> +++ b/arch/arm/boot/dts/qcom/qcom-sdx65-mtp.dts
>> @@ -7,7 +7,7 @@
>>   #include "qcom-sdx65.dtsi"
>>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>>   #include <arm64/qcom/pmk8350.dtsi>
>> -#include <arm64/qcom/pm8150b.dtsi>
>> +#include <arm64/qcom/pm7250b.dtsi>
>>   #include "qcom-pmx65.dtsi"
>>   
>>   / {

[PATCH 6/8] arm64: dts: qcom: sdx75-idp: Add pmics supported in SDX75

[Rohit Agarwal]

SDX75-idp features pmk8550, pmx75 and pm7550ba pmic, so include them.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sdx75-idp.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdx75-idp.dts b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
index cbe5cdf..94a9218 100644
--- a/arch/arm64/boot/dts/qcom/sdx75-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
@@ -6,6 +6,9 @@
 /dts-v1/;
 
 #include "sdx75.dtsi"
+#include "pmk8550.dtsi"
+#include "pmx75.dtsi"
+#include "pm7550ba.dtsi"
 
 / {
 	model = "Qualcomm Technologies, Inc. SDX75 IDP";
-- 
2.7.4

[PATCH 7/8] arm64: dts: qcom: sdx75: Add rpmhpd node

[Rohit Agarwal]

Add rpmhpd node and opps for this node to the SDX75 dts.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sdx75.dtsi | 51 +++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
index 5e9602cd..3a1d37a 100644
--- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
@@ -9,6 +9,7 @@
 #include <dt-bindings/clock/qcom,rpmh.h>
 #include <dt-bindings/clock/qcom,sdx75-gcc.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
+#include <dt-bindings/power/qcom,rpmhpd.h>
 #include <dt-bindings/soc/qcom,rpmh-rsc.h>
 
 / {
@@ -666,6 +667,56 @@
 				clock-names = "xo";
 				#clock-cells = <1>;
 			};
+
+			rpmhpd: power-controller {
+				compatible = "qcom,sdx75-rpmhpd";
+				#power-domain-cells = <1>;
+				operating-points-v2 = <&rpmhpd_opp_table>;
+
+				rpmhpd_opp_table: opp-table {
+					compatible = "operating-points-v2";
+
+					rpmhpd_opp_ret: opp1 {
+						opp-level = <RPMH_REGULATOR_LEVEL_RETENTION>;
+					};
+
+					rpmhpd_opp_min_svs: opp2 {
+						opp-level = <RPMH_REGULATOR_LEVEL_MIN_SVS>;
+					};
+
+					rpmhpd_opp_low_svs: opp3 {
+						opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS>;
+					};
+
+					rpmhpd_opp_svs: opp4 {
+						opp-level = <RPMH_REGULATOR_LEVEL_SVS>;
+					};
+
+					rpmhpd_opp_svs_l1: opp5 {
+						opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>;
+					};
+
+					rpmhpd_opp_nom: opp6 {
+						opp-level = <RPMH_REGULATOR_LEVEL_NOM>;
+					};
+
+					rpmhpd_opp_nom_l1: opp7 {
+						opp-level = <RPMH_REGULATOR_LEVEL_NOM_L1>;
+					};
+
+					rpmhpd_opp_nom_l2: opp8 {
+						opp-level = <RPMH_REGULATOR_LEVEL_NOM_L2>;
+					};
+
+					rpmhpd_opp_turbo: opp9 {
+						opp-level = <RPMH_REGULATOR_LEVEL_TURBO>;
+					};
+
+					rpmhpd_opp_turbo_l1: opp10 {
+						opp-level = <RPMH_REGULATOR_LEVEL_TURBO_L1>;
+					};
+				};
+			};
 		};
 
 		cpufreq_hw: cpufreq@17d91000 {
-- 
2.7.4

Re: [PATCH 7/8] arm64: dts: qcom: sdx75: Add rpmhpd node

[Konrad Dybcio]

On 2.08.2023 11:59, Rohit Agarwal wrote:
> Add rpmhpd node and opps for this node to the SDX75 dts.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sdx75.dtsi | 51 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
> index 5e9602cd..3a1d37a 100644
> --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
> @@ -9,6 +9,7 @@
>  #include <dt-bindings/clock/qcom,rpmh.h>
>  #include <dt-bindings/clock/qcom,sdx75-gcc.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/power/qcom,rpmhpd.h>
>  #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>  
>  / {
> @@ -666,6 +667,56 @@
>  				clock-names = "xo";
>  				#clock-cells = <1>;
>  			};
> +
> +			rpmhpd: power-controller {
> +				compatible = "qcom,sdx75-rpmhpd";
> +				#power-domain-cells = <1>;
> +				operating-points-v2 = <&rpmhpd_opp_table>;
> +
> +				rpmhpd_opp_table: opp-table {
> +					compatible = "operating-points-v2";
> +
> +					rpmhpd_opp_ret: opp1 {
Please use opp-(value-of-opp-level) here, we've hit a few cases
where introducing levels inbetween was necessary and this would
limit the diff if that was the case again, so opp-16 etc.

Konrad

Re: [PATCH 7/8] arm64: dts: qcom: sdx75: Add rpmhpd node

[Rohit Agarwal]

On 8/2/2023 6:18 PM, Konrad Dybcio wrote:
> On 2.08.2023 11:59, Rohit Agarwal wrote:
>> Add rpmhpd node and opps for this node to the SDX75 dts.
>>
>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sdx75.dtsi | 51 +++++++++++++++++++++++++++++++++++++
>>   1 file changed, 51 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi
>> index 5e9602cd..3a1d37a 100644
>> --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi
>> @@ -9,6 +9,7 @@
>>   #include <dt-bindings/clock/qcom,rpmh.h>
>>   #include <dt-bindings/clock/qcom,sdx75-gcc.h>
>>   #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +#include <dt-bindings/power/qcom,rpmhpd.h>
>>   #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>>   
>>   / {
>> @@ -666,6 +667,56 @@
>>   				clock-names = "xo";
>>   				#clock-cells = <1>;
>>   			};
>> +
>> +			rpmhpd: power-controller {
>> +				compatible = "qcom,sdx75-rpmhpd";
>> +				#power-domain-cells = <1>;
>> +				operating-points-v2 = <&rpmhpd_opp_table>;
>> +
>> +				rpmhpd_opp_table: opp-table {
>> +					compatible = "operating-points-v2";
>> +
>> +					rpmhpd_opp_ret: opp1 {
> Please use opp-(value-of-opp-level) here, we've hit a few cases
> where introducing levels inbetween was necessary and this would
> limit the diff if that was the case again, so opp-16 etc.
Will update this as well

Thanks,
Rohit.
>
> Konrad

[PATCH 8/8] arm64: dts: qcom: sdx75-idp: Add regulator nodes

[Rohit Agarwal]

Add the regulators found on SDX75 IDP.

Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sdx75-idp.dts | 202 +++++++++++++++++++++++++++++++++
 1 file changed, 202 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdx75-idp.dts b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
index 94a9218..7cb4fea 100644
--- a/arch/arm64/boot/dts/qcom/sdx75-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sdx75-idp.dts
@@ -5,6 +5,7 @@
 
 /dts-v1/;
 
+#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
 #include "sdx75.dtsi"
 #include "pmk8550.dtsi"
 #include "pmx75.dtsi"
@@ -17,6 +18,207 @@
 	aliases {
 		serial0 = &uart1;
 	};
+
+	vph_pwr: vph-pwr-regulator {
+		compatible = "regulator-fixed";
+		regulator-name = "vph_pwr";
+		regulator-min-microvolt = <3700000>;
+		regulator-max-microvolt = <3700000>;
+	};
+
+	vph_ext: vph-ext-regulator {
+		compatible = "regulator-fixed";
+		regulator-name = "vph_ext";
+		regulator-min-microvolt = <3700000>;
+		regulator-max-microvolt = <3700000>;
+	};
+
+	vreg_bob_3p3: pmx75-bob {
+		compatible = "regulator-fixed";
+		regulator-name = "vreg_bob_3p3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+
+		vin-supply = <&vph_ext>;
+	};
+};
+
+&apps_rsc {
+	pmx75-rpmh-regulators {
+		compatible = "qcom,pmx75-rpmh-regulators";
+		qcom,pmic-id = "b";
+
+		vdd-s1-supply = <&vph_pwr>;
+		vdd-s2-supply = <&vph_pwr>;
+		vdd-s3-supply = <&vph_pwr>;
+		vdd-s4-supply = <&vph_pwr>;
+		vdd-s5-supply = <&vph_pwr>;
+		vdd-s6-supply = <&vph_pwr>;
+		vdd-s7-supply = <&vph_pwr>;
+		vdd-s8-supply = <&vph_pwr>;
+		vdd-s9-supply = <&vph_pwr>;
+		vdd-s10-supply = <&vph_pwr>;
+		vdd-l1-supply = <&vreg_s2b_1p224>;
+		vdd-l2-l18-supply = <&vreg_s2b_1p224>;
+		vdd-l3-supply = <&vreg_s7b_0p936>;
+		vdd-l4-l16-supply = <&vreg_s7b_0p936>;
+		vdd-l5-l6-supply = <&vreg_s4b_1p824>;
+		vdd-l7-supply = <&vreg_s7b_0p936>;
+		vdd-l8-l9-supply = <&vreg_s8b_0p824>;
+		vdd-l10-supply = <&vreg_bob_3p3>;
+		vdd-l11-l13-supply = <&vreg_bob_3p3>;
+		vdd-l12-supply = <&vreg_s2b_1p224>;
+		vdd-l14-supply = <&vreg_s3b_0p752>;
+		vdd-l15-supply = <&vreg_s2b_1p224>;
+		vdd-l17-supply = <&vreg_s8b_0p824>;
+		vdd-l19-supply = <&vreg_s7b_0p936>;
+		vdd-l20-l21-supply = <&vreg_s7b_0p936>;
+
+		vreg_s2b_1p224: smps2 {
+			regulator-min-microvolt = <1224000>;
+			regulator-max-microvolt = <1350000>;
+		};
+
+		vreg_s3b_0p752: smps3 {
+			regulator-min-microvolt = <684000>;
+			regulator-max-microvolt = <904000>;
+		};
+
+		vreg_s4b_1p824: smps4 {
+			regulator-min-microvolt = <1824000>;
+			regulator-max-microvolt = <1904000>;
+		};
+
+		vreg_s7b_0p936: smps7 {
+			regulator-min-microvolt = <352000>;
+			regulator-max-microvolt = <1060000>;
+		};
+
+		vreg_s8b_0p824: smps8 {
+			regulator-min-microvolt = <500000>;
+			regulator-max-microvolt = <1100000>;
+		};
+
+		ldo1 {
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo2 {
+			regulator-min-microvolt = <1000000>;
+			regulator-max-microvolt = <1160000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo3 {
+			regulator-min-microvolt = <300000>;
+			regulator-max-microvolt = <1040000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo4 {
+			regulator-min-microvolt = <864000>;
+			regulator-max-microvolt = <912000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo5 {
+			regulator-min-microvolt = <1770000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo6 {
+			regulator-min-microvolt = <1800000>;
+			regulator-max-microvolt = <1800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo7 {
+			regulator-min-microvolt = <300000>;
+			regulator-max-microvolt = <960000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo8 {
+			regulator-min-microvolt = <800000>;
+			regulator-max-microvolt = <800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo9 {
+			regulator-min-microvolt = <752000>;
+			regulator-max-microvolt = <800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo10 {
+			regulator-min-microvolt = <3008000>;
+			regulator-max-microvolt = <3088000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo11 {
+			regulator-min-microvolt = <1704000>;
+			regulator-max-microvolt = <2928000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo12 {
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo13 {
+			regulator-min-microvolt = <1704000>;
+			regulator-max-microvolt = <2928000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo14 {
+			regulator-min-microvolt = <300000>;
+			regulator-max-microvolt = <800000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo15 {
+			regulator-min-microvolt = <1200000>;
+			regulator-max-microvolt = <1200000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo16 {
+			regulator-min-microvolt = <880000>;
+			regulator-max-microvolt = <920000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo17 {
+			regulator-min-microvolt = <684000>;
+			regulator-max-microvolt = <957600>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo19 {
+			regulator-min-microvolt = <900000>;
+			regulator-max-microvolt = <960000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo20 {
+			regulator-min-microvolt = <912000>;
+			regulator-max-microvolt = <952000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+
+		ldo21 {
+			regulator-min-microvolt = <300000>;
+			regulator-max-microvolt = <1000000>;
+			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+		};
+	};
 };
 
 &chosen {
-- 
2.7.4

Re: [PATCH 8/8] arm64: dts: qcom: sdx75-idp: Add regulator nodes

[Konrad Dybcio]

On 2.08.2023 11:59, Rohit Agarwal wrote:
> Add the regulators found on SDX75 IDP.
> 
> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> ---
[...]


> +		vreg_s2b_1p224: smps2 {
Even though most RPMh devices use the schematic-like names, I think naming
the labels like pmicname_regname, e.g. pm8550_l2 would be easier to read..
(Bjorn, Krzysztof - opinions?)

On top of that, please add labels to all of the regulators you're
introducing to limit unnecessary diff in the future.

Konrad

Re: [PATCH 8/8] arm64: dts: qcom: sdx75-idp: Add regulator nodes

[Bjorn Andersson]

On Wed, Aug 02, 2023 at 02:49:56PM +0200, Konrad Dybcio wrote:
> On 2.08.2023 11:59, Rohit Agarwal wrote:
> > Add the regulators found on SDX75 IDP.
> > 
> > Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
> > ---
> [...]
> 
> 
> > +		vreg_s2b_1p224: smps2 {
> Even though most RPMh devices use the schematic-like names, I think naming
> the labels like pmicname_regname, e.g. pm8550_l2 would be easier to read..
> (Bjorn, Krzysztof - opinions?)
> 

Using the naming from the schematics is preferred, and avoid various
levels of ambiguity.

> On top of that, please add labels to all of the regulators you're
> introducing to limit unnecessary diff in the future.
> 

There are cases where regulators are left on by the bootloader, but
doesn't have a function, or name, in the particular board. In this case
it might be unnecessary (or not possible) to label the regulator, but we
still might want to list the regulator so it will be turned off
automatically.

But such decision is explicit and should be mentioned either in a
comment or in the commit message.

Regards,
Bjorn