From: Alex Bee <knaerzche@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>,
Jianfeng Liu <liujianfeng1994@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
ezequiel@vanguardiasur.com.ar, frattaroli.nicolas@gmail.com,
heiko@sntech.de, kernel@collabora.com, krzk+dt@kernel.org,
linkmauve@linkmauve.fr, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
nicolas.dufresne@collabora.com, p.zabel@pengutronix.de,
robh@kernel.org
Subject: Re: [PATCH v6 4/6] media: hantro: Add RK3588 VEPU121
Date: Tue, 18 Jun 2024 10:28:14 +0200 [thread overview]
Message-ID: <2e98128f-39f8-4800-91f6-c1cfa21fa0a6@gmail.com> (raw)
In-Reply-To: <o6iccgurpi7sraq7plxaccz37i44te4jaqicnp2nqbke2qtskh@4kboulg3zywx>
Am 17.06.24 um 13:30 schrieb Sebastian Reichel:
> Hi,
>
> On Mon, Jun 17, 2024 at 10:50:22AM GMT, Jianfeng Liu wrote:
>> Hi Sebastian,
>>
>> Thu, 13 Jun 2024 15:48:45 +0200, Sebastian Reichel wrote:
>>> + { .compatible = "rockchip,rk3588-vepu121", .data = &rk3568_vpu_variant, },
>>
>> rk3568_vpu_variant is decoder's data, typo?
>
> See first sentence of the commit message.
>
I think, what Jianfeng meant, is that you are incorrectly using
rk3568_vpu_variant for the newly added "rockchip,rk3588-vepu121"
compatible: rk3568_vpu_variant is for the decoder (confusing, I know:
should actually be rk3568_vdpu_variant) - you want to use
rk3568_vepu_variant instead for it instead.
Alex
> -- Sebastian.
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2024-06-18 8:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 13:48 [PATCH v6 0/6] RK3588 VEPU121/VPU121 support Sebastian Reichel
2024-06-13 13:48 ` [PATCH v6 1/6] media: dt-bindings: rk3568-vepu: Add RK3588 VEPU121 Sebastian Reichel
2024-06-13 16:22 ` Conor Dooley
2024-06-13 13:48 ` [PATCH v6 2/6] media: dt-bindings: rockchip-vpu: Add RK3588 VPU121 Sebastian Reichel
2024-06-13 13:48 ` [PATCH v6 3/6] media: hantro: Disable multicore support Sebastian Reichel
2024-06-13 13:48 ` [PATCH v6 4/6] media: hantro: Add RK3588 VEPU121 Sebastian Reichel
2024-06-17 2:50 ` Jianfeng Liu
2024-06-17 11:30 ` Sebastian Reichel
2024-06-17 15:07 ` Jianfeng Liu
2024-06-18 8:28 ` Alex Bee [this message]
2024-06-13 13:48 ` [PATCH v6 5/6] arm64: dts: rockchip: Add VEPU121 to RK3588 Sebastian Reichel
2024-06-13 17:21 ` Nicolas Dufresne
2024-06-13 13:48 ` [PATCH v6 6/6] arm64: dts: rockchip: Add VPU121 support for RK3588 Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e98128f-39f8-4800-91f6-c1cfa21fa0a6@gmail.com \
--to=knaerzche@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linkmauve@linkmauve.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=liujianfeng1994@gmail.com \
--cc=nicolas.dufresne@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).