From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDE7D3BBFD3 for ; Fri, 17 Jul 2026 09:30:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784280625; cv=none; b=HN34kURcGO0RnAah/g6XP78anwz7HDlMpDZ4cIEiqDxvoozyZNj4e/Xv7HLOXZsHDOmlPtz9TEzdXEUbCtqa+RjO5k1146y7h8y8UUc1yyWwSNWkXiHPEfB5aYhDY8gHuHjB+jSSgBVkEZ0L1fAsz1se6ySyA4fegluTDunAh3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784280625; c=relaxed/simple; bh=sW39zPxE9KCDrhtE5RxDgtxp+wa5oNRnPHM5iQvak9A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mNbqZqmWDnzd9kgogx0xhAEBddnyKbu1n1xjR4KeZK3y7OGU2yZAlp2Ucb6agQ0JVw65aY/rm/zA3TRrzOwePw851tqvA+RklDko249QZ2ob/8fghuw+BTAS2v3EUy8yRhXYGHYcLANmDAkcLROmWM2j7PHOWoYceULudXl4kps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=oaAi9IR3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PqiFdqI6; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="oaAi9IR3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PqiFdqI6" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66H6cRTN794306 for ; Fri, 17 Jul 2026 09:30:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TnVo3dTONDwo1Ybr6ny1brTgUFSId0p7SO+cCeMTRgQ=; b=oaAi9IR3JYz5La5X ooCE/hmwAzHRm7UAezhUauUYoWb3Os2Wu0QH3KPm0mtKZX3CLCk6RBFDv2mE15hB 5oLLfdIMwF79vdKk9Y26EUmyXxKZsqeiNBQS4YUjX4HN1wbxdY5/3hKW/pBJpms1 Dx/vJ+FPsLxSYlo48lt4UywRXANIzHZrGRse8Nogp0DEH1NvnaSmbWUGUIMcVTE9 ZT9fkVMMi+DjYalROdE5tKjlJzvlxMcO3a4yggLfo24Miljy3P3iWj80EPPU8ilR h8pSaYGwZSeE6I+eUFIdKYGcPdP/8hKiuvVBAzaTN9681FRpzE3ESc5jiBs0v35F h0z5/g== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ff3u8k3b9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 17 Jul 2026 09:30:22 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2cf27789c79so16744375ad.2 for ; Fri, 17 Jul 2026 02:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784280622; x=1784885422; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=TnVo3dTONDwo1Ybr6ny1brTgUFSId0p7SO+cCeMTRgQ=; b=PqiFdqI6hQWxfOT7u+JdxSC4pdGfazRK/SRPYnqxbb2kjSp78q5D5ia71glCoSxx8c ZW7JvqZ9xdwa6OIh1ULr3/lx74wRIut/DCLyfYwzhdJuM9w4O/Mzk6nvZk4WNjJf+vGN qMx4RLhnLaSSAx30TuHSfWtD3ZDASes9d6KE91evbK93ndV0qU+K8UzcAUh5AY++IDKR u8Gkgmnbp4Il2mjKOn/iK/N268E1W4a41QjmsHcIMQB+zhIoZ4HoxZthz8DX/vPSefkd ynQEr3NJDABxWWHgm/xfc3d2Jd1Riea2ItY7FOHGpoY6WmcD2aAQsPJ40wzHEBVLqoUX 0awA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784280622; x=1784885422; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TnVo3dTONDwo1Ybr6ny1brTgUFSId0p7SO+cCeMTRgQ=; b=icirS0JVdjw+BBexHDwFrs85XUiplLwkItkgmVA4K1jgfZcH9lciirlhUsTXxHCOCE PNVTxQH2eUbMLoduemRC8ZaN58B1tV7pxDIDyGk8dJDQWRdpDkkADuc41ddmqun+Z7En qzeWTJHrtef3K1ialYZkFwIqe24wA53ayYDaCR730rAnpI8OpcRDJ6bSftZJAlIMgIMQ vSYmfw1YI5znzrTSdci94nIqbg5ofraiFQ3XwdBa+pFXwnFyAyvDodP+zHjHMLu+VYDx QUi+8LeBPx27mq8Y23VnPEIFM6Q3EFqn7S7YBpqKElFtNsoiM7EQOGbgB0u9gkWnrm07 p56A== X-Forwarded-Encrypted: i=1; AHgh+RoYmTGAdGMYbJS2qqIKonxp2XOLGqeYf1IzFwoh6Ied85mSrGgC0DSo5IbOWEwOB3c7zgzWbZIu++1z@vger.kernel.org X-Gm-Message-State: AOJu0Yxwa4r17xhNTL7+9suKYiGtVkUF/Y7hpm+cFa27ct1Ci3NMQTtm 5P1aL6XnxFb376P2Nq0a1t3JiZH0wnTE6SUH5ebHLuOXqgGSowwiRfASJr03VB5g9eqG/M9kMKg pBlWc+mU2aMtDhALV0PguJY64TDQ5t8cOZOWIz4AeyNePzHQPw6+UCtZGX4jpqRwX X-Gm-Gg: AfdE7cnNlYZDL0NtANmbdiRvFY/pJqDiHvcS6/9EA1/Z2rSlz31mBy0aCNWRsZwihWF BWqZwANsvG0LVK3hMDYVixljYDfnxoVlH8hSpSlApeDf3UWXr41FJqkZVed10ngSSG+TAKQodKl yc1cY983V2oGDmRuL74kJVyqa98qy1K9wT4/DLPKZf/UByLvkwHWs1hFm0FIfIlEr0BfFcS1N3Q ub8VTLYO49QXFAGHN9TnmDYtSlFwdM1r12nIo9nU3RtMU97/h+ZjVVLrrND4FTBrS6AwHR1tdSr b8d2/I0jZUW6xL2BbZMM2g/SEkIWU5oxEBdznX3okyv7fr384C9QVKlEnsBSSSyLmhBwB/yPPN9 NwaGfXTDJ9CZSdeU4DNJJZbsvWT0= X-Received: by 2002:a17:903:3c46:b0:2c9:97a8:afef with SMTP id d9443c01a7336-2cf349f4a51mr17753075ad.40.1784280622073; Fri, 17 Jul 2026 02:30:22 -0700 (PDT) X-Received: by 2002:a17:903:3c46:b0:2c9:97a8:afef with SMTP id d9443c01a7336-2cf349f4a51mr17752525ad.40.1784280621313; Fri, 17 Jul 2026 02:30:21 -0700 (PDT) Received: from [10.217.216.90] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2cf344f4481sm7415285ad.32.2026.07.17.02.30.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jul 2026 02:30:20 -0700 (PDT) Message-ID: <2e9a211d-a877-419a-ba8d-40bfc42e65ef@oss.qualcomm.com> Date: Fri, 17 Jul 2026 15:00:11 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] dt-bindings: clock: qcom: glymur-gcc: Add missing CX power domain To: Bjorn Andersson Cc: Abel Vesa , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Maulik Shah , Dmitry Baryshkov , Jyothi Kumar Seerapu , Konrad Dybcio , Brian Masney , Krzysztof Kozlowski , Sibi Sankar , Pankaj Patil , Akhil P Oommen , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jishnu Prakash , Raviteja Laggyshetty , Kamal Wadhwa , Qiang Yu , Manaf Meethalavalappu Pallikunhi , Abel Vesa References: <20260715-glymur-fix-gcc-cx-scaling-v3-0-72eb5adad156@oss.qualcomm.com> <20260715-glymur-fix-gcc-cx-scaling-v3-1-72eb5adad156@oss.qualcomm.com> <4b543abe-2482-4381-b41e-623cdf5be9a2@oss.qualcomm.com> <316fd37b-9936-4bca-8521-9a11ee65cbd6@oss.qualcomm.com> Content-Language: en-US From: Taniya Das In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: sHQUjwIAUIR3SeDG7M9imOO6a50y3phd X-Proofpoint-ORIG-GUID: sHQUjwIAUIR3SeDG7M9imOO6a50y3phd X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE3MDA5NCBTYWx0ZWRfX6XYmXjsWFTS2 tc3sHmPIam341Yq3HFQ28sHfDn1Q55lAE+VgGgEOBGmnT9p2DSSdb4Fk967axJQmy+3+/R9aTpY 79YsAqvnXBnWRvxSvb+qThZatRYIwyw= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE3MDA5NCBTYWx0ZWRfX3bZJt4Hxe3Cv mwcoWpoMr2C4dsJv0WvxzCkRoVqlZ13RZ7yUjm3hkna0gHC7uYht6miHfBvSlgDYjHW94zz0J7S P5716DJD9bLuiesJdeMmftUIslTfLIBvarmjkXsFokFUDR7+TjRLjzbaLAHJ9YTA8TgV9I+rTu/ +ATtAWzFl0opsPYAsB/Aiyc5SS/OUMr4PcSTlZgo4OOOcEaSYWWnBsX0f8C0bUX8tOPEjlxUhri g7G1LvrtipypRFHVw8Gdsjc0jpI3NViDrrpdZyvEfm8VHR6LXrh+DRRwNpAGeFt0VJrq10GJjAA Rx0aJlyQUSnudJAPP2q79rrMZO+mW2mSCl1e+QSIdd9H2+3pPQbNJTt1jUKmzGztR4/7abKzcDO in27DGp8U2zjO983DWNbGMvWA91T4BjOjewkYLhSTQyESqtCNrevSzreoYwg3uAcx5EA4Oysjod exAgWtGHWnRBR1r7iOw== X-Authority-Analysis: v=2.4 cv=TL11jVla c=1 sm=1 tr=0 ts=6a59f62e cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=ZdHkocIOR6SBK6D-yKIA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-17_02,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 spamscore=0 bulkscore=0 malwarescore=0 suspectscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607170094 On 7/17/2026 6:45 AM, Bjorn Andersson wrote: > On Thu, Jul 16, 2026 at 04:42:11PM +0530, Taniya Das wrote: >> >> >> On 7/16/2026 12:52 PM, Abel Vesa wrote: >>> On 26-07-16 10:13:48, Taniya Das wrote: >>>> >>>> >>>> On 7/15/2026 6:59 PM, Abel Vesa wrote: >>>>> The GDSCs provided by the Glymur GCC are supplied by the RPMh CX power >>>>> domain. Model that parent domain in the GCC binding so the provider can >>>>> describe the dependency in devicetree. >>>>> >>>>> Add a single CX power-domain entry to the binding and make it required, >>>>> matching the hardware description needed by the GCC node. >>>>> >>>>> Fixes: ee2d967030fe ("dt-bindings: clock: qcom: document the Glymur Global Clock Controller") >>>>> Signed-off-by: Abel Vesa >>>>> --- >>>>> Documentation/devicetree/bindings/clock/qcom,glymur-gcc.yaml | 8 ++++++++ >>>>> 1 file changed, 8 insertions(+) >>>> >>>> >>>> Abel, I feel we should add the 'required-opps' as well which will ensure >>>> the clock controllers minimum voltage requirement. >>> >>> But it was agreed in v1 that we should not add the required-opps. So we >>> dropped it in v2. >>> >> >> Okay, sorry, may be I missed that comment. >> >> >>> Can you give more details to why you think it is needed ? >> >> My reasoning is that if a clock controller requires a rail, it is >> preferable to explicitly specify the required operating level rather >> than rely on system/client vote. This makes the dependency >> self-contained and easier to reason about. Clients that require a higher >> operating level than the clock controller's minimum requirement remain >> free to vote for a higher level as needed. >> > > You're expressing this in generic terms, can you please provide the > concrete example of what this would look for in the Glymur GCC case? > Yes, Bjorn, this is indeed a general requirement for a clock controller. In Glymur I do see that CX could drop to retention corner in case there is no vote from any subsystem and so it is better to vote from clock controller a level above retention using the required-opps. > What is the required-opps for the Glymur GCC? LOW_SVS(rpmhpd_opp_low_svs) corner should be good for GCC controller. -- Thanks, Taniya Das