From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D96CC77B73 for ; Thu, 20 Apr 2023 06:04:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233907AbjDTGE1 (ORCPT ); Thu, 20 Apr 2023 02:04:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233968AbjDTGD7 (ORCPT ); Thu, 20 Apr 2023 02:03:59 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51DC86EA8; Wed, 19 Apr 2023 23:03:18 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 6C3F324E1B2; Thu, 20 Apr 2023 14:03:16 +0800 (CST) Received: from EXMBX162.cuchost.com (172.16.6.72) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 20 Apr 2023 14:03:16 +0800 Received: from [192.168.125.106] (113.72.144.253) by EXMBX162.cuchost.com (172.16.6.72) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Thu, 20 Apr 2023 14:03:15 +0800 Message-ID: <2e9d1548-1a2b-d4aa-2582-f70299d1b050@starfivetech.com> Date: Thu, 20 Apr 2023 14:03:14 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RESEND v2 3/6] soc: starfive: Modify ioremap to regmap To: Conor Dooley CC: Rob Herring , Krzysztof Kozlowski , Emil Renner Berthing , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , Hal Feng , , , References: <20230419035646.43702-1-changhuang.liang@starfivetech.com> <20230419035646.43702-4-changhuang.liang@starfivetech.com> <20230419-headdress-surcharge-8017d6db444b@spud> Content-Language: en-US From: Changhuang Liang In-Reply-To: <20230419-headdress-surcharge-8017d6db444b@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.144.253] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX162.cuchost.com (172.16.6.72) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2023/4/20 1:29, Conor Dooley wrote: > On Tue, Apr 18, 2023 at 08:56:43PM -0700, Changhuang Liang wrote: >> Modify ioremap to regmap which can be compatible with the syscon >> interface, such as: >> struct regmap *syscon_node_to_regmap(struct device_node *np) >> Convenient introduction of syscon operation. > > What's missing here is an explanation of *why* you are making this > compatible with the syscon interface. Provided everything else is fine, > I can fix this when applying the series. > > Thanks, > Conor. > Add this patch just for using the same member(struct regmap *base) in patch 5. Maybe I should replace syscon_node_to_regmap() with of_iomap() in patch 5. So that patch 5 will use (void __iomem *base) member, and I also can drop this patch 3 in this series. struct regmap *syscon_node_to_regmap(struct device_node *np); void __iomem *of_iomap(struct device_node *node, int index);