* [PATCH] ARM: dts: omap: gta04: add BNO055 IMU chip
@ 2023-01-13 22:10 Andreas Kemnade
2023-01-15 14:58 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Kemnade @ 2023-01-13 22:10 UTC (permalink / raw)
To: bcousson, tony, robh+dt, krzysztof.kozlowski+dt, linux-omap,
devicetree, linux-kernel
Cc: Andreas Kemnade
There is finally a driver upstreamed, so add the
device.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/omap3-gta04a5.dts | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts b/arch/arm/boot/dts/omap3-gta04a5.dts
index 0b5bd7388877..4f56f7fc0d1b 100644
--- a/arch/arm/boot/dts/omap3-gta04a5.dts
+++ b/arch/arm/boot/dts/omap3-gta04a5.dts
@@ -75,6 +75,11 @@ OMAP3_CORE1_IOPAD(0x2138, PIN_INPUT | MUX_MODE4) /* gpin114 */
>;
};
+ bno050_pins: pinmux-bno050-pins {
+ pinctrl-single,pins = <
+ OMAP3_CORE1_IOPAD(0x2136, PIN_INPUT | MUX_MODE4) /* gpin113 */
+ >;
+ };
};
/*
@@ -136,4 +141,13 @@ bme280@76 {
vdda-supply = <&vio>;
vddd-supply = <&vio>;
};
+
+ bno055@29 {
+ compatible = "bosch,bno055";
+ reg = <0x29>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&bno050_pins>;
+ /* interrupt at &gpio4 17 */
+ };
+
};
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: omap: gta04: add BNO055 IMU chip
2023-01-13 22:10 [PATCH] ARM: dts: omap: gta04: add BNO055 IMU chip Andreas Kemnade
@ 2023-01-15 14:58 ` Krzysztof Kozlowski
2023-01-17 19:36 ` Andreas Kemnade
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-01-15 14:58 UTC (permalink / raw)
To: Andreas Kemnade, bcousson, tony, robh+dt, krzysztof.kozlowski+dt,
linux-omap, devicetree, linux-kernel
On 13/01/2023 23:10, Andreas Kemnade wrote:
> There is finally a driver upstreamed, so add the
> device.
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> arch/arm/boot/dts/omap3-gta04a5.dts | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts b/arch/arm/boot/dts/omap3-gta04a5.dts
> index 0b5bd7388877..4f56f7fc0d1b 100644
> --- a/arch/arm/boot/dts/omap3-gta04a5.dts
> +++ b/arch/arm/boot/dts/omap3-gta04a5.dts
> @@ -75,6 +75,11 @@ OMAP3_CORE1_IOPAD(0x2138, PIN_INPUT | MUX_MODE4) /* gpin114 */
> >;
> };
>
> + bno050_pins: pinmux-bno050-pins {
> + pinctrl-single,pins = <
> + OMAP3_CORE1_IOPAD(0x2136, PIN_INPUT | MUX_MODE4) /* gpin113 */
> + >;
> + };
> };
>
> /*
> @@ -136,4 +141,13 @@ bme280@76 {
> vdda-supply = <&vio>;
> vddd-supply = <&vio>;
> };
> +
> + bno055@29 {
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "bosch,bno055";
> + reg = <0x29>;
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: omap: gta04: add BNO055 IMU chip
2023-01-15 14:58 ` Krzysztof Kozlowski
@ 2023-01-17 19:36 ` Andreas Kemnade
0 siblings, 0 replies; 3+ messages in thread
From: Andreas Kemnade @ 2023-01-17 19:36 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: bcousson, tony, robh+dt, krzysztof.kozlowski+dt, linux-omap,
devicetree, linux-kernel
On Sun, 15 Jan 2023 15:58:05 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> On 13/01/2023 23:10, Andreas Kemnade wrote:
> > There is finally a driver upstreamed, so add the
> > device.
> >
> > Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> > ---
> > arch/arm/boot/dts/omap3-gta04a5.dts | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/omap3-gta04a5.dts b/arch/arm/boot/dts/omap3-gta04a5.dts
> > index 0b5bd7388877..4f56f7fc0d1b 100644
> > --- a/arch/arm/boot/dts/omap3-gta04a5.dts
> > +++ b/arch/arm/boot/dts/omap3-gta04a5.dts
> > @@ -75,6 +75,11 @@ OMAP3_CORE1_IOPAD(0x2138, PIN_INPUT | MUX_MODE4) /* gpin114 */
> > >;
> > };
> >
> > + bno050_pins: pinmux-bno050-pins {
> > + pinctrl-single,pins = <
> > + OMAP3_CORE1_IOPAD(0x2136, PIN_INPUT | MUX_MODE4) /* gpin113 */
> > + >;
> > + };
> > };
> >
> > /*
> > @@ -136,4 +141,13 @@ bme280@76 {
> > vdda-supply = <&vio>;
> > vddd-supply = <&vio>;
> > };
> > +
> > + bno055@29 {
>
> Node names should be generic.
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
>
the usual pitfall, just looking at the style around... Especially if it an
old patch, not needing too much attention, just removing some now undefined
properties. The file deserves some cleanup, since generic node names were
not invented there yet.
Regards,
Andreas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-17 21:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-13 22:10 [PATCH] ARM: dts: omap: gta04: add BNO055 IMU chip Andreas Kemnade
2023-01-15 14:58 ` Krzysztof Kozlowski
2023-01-17 19:36 ` Andreas Kemnade
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).