From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA5C2C05027 for ; Tue, 14 Feb 2023 23:56:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231645AbjBNX4K (ORCPT ); Tue, 14 Feb 2023 18:56:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231707AbjBNX4J (ORCPT ); Tue, 14 Feb 2023 18:56:09 -0500 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6376823C59 for ; Tue, 14 Feb 2023 15:56:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1676418968; x=1707954968; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=pEnLWNUeiDXooxyuVty+8cCKql27+XR1BGKYZjuILOw=; b=nFu9F4f9sOBpnWgwQ+Q4VC7MptY4uEmvifEFdIBIWcGtFFcsmeOnlJTT gO0Wwx0Pr7PicCzppzpqyDmyOaWFvxbSgmLVvRc3eAb2DKsHTBQkljvg8 y+o+JPPeTAFrsw9C+bow1rhUCLB8DR/DK/qmfnybrNeG42kxQ0MV5NGB/ iMyfF3+zUh2D267vVy6w2+cBbWXFtL3hjXzJKQKXB9Shzj/1rdQvqqk7M pugsWfSNxXj/dDTIf+pO9qxbO8ztwRsCguHE1s5YaUTSSQ84lYOOn6ZID 4Hp5nShM35gg1CWS5AG74qGFSr4Jm3K8aS0AtGroOWW8hYSbK6V5YdTz4 A==; X-IronPort-AV: E=Sophos;i="5.97,298,1669046400"; d="scan'208";a="335284578" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 15 Feb 2023 07:56:07 +0800 IronPort-SDR: tGYPjV2ICjBYIdC72USsTmOeldVObmc4FRcFpMSpUPUWScVjGpObVlBCehvHWmAtun1CDwhtPu C5MKnGnRupdOjQy0rUFTR1Psg4u5Pmfevfmsspz16nkffh3wdZf+DaI5wKv+pfhfVbAi5N2PWI ufb0gJijpxsA8jQWSsN8vnX1eji4PTIZPAeRlQQ8SXljz8vdnwZCVxeYm46e9kPMxykJ5Q3Mvo jVpSRl2E5DfHjR3q4x/amDBYYCDdVtzxfEUYfGegyI4NokoJyjVLLkJ4ut2X0JZVOrj8+vHTNH oIE= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Feb 2023 15:07:30 -0800 IronPort-SDR: 3bYR5jj5YSakz67ZJTAc3Sv/e+hvdCnBhQeUaV+v5H6vlxSqrCBhqFEGbXyOuRL/PpwSPJY2pT hgGXROcl/83IqpiulrNrxgxmYGvoSzSZrwp5Dr6HHJq1q+rRI8PZp3ArnbL9NXYDtSNX1MpjSf soBmW0/4W4jxulRJF9atuRmYPyza9PBZix/GO0w8naV89jPXs7wupGcdAZ9EQxWhSWGdjIhY1e YiRYg8KjWQ/XvoY/XO5TNajoCkZK0dCa/n5qBBDvJzFaKrD0rFWB8t8WHYQkVbx7JSIzsfF4ns xgQ= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Feb 2023 15:56:08 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4PGdQH0cVMz1RwtC for ; Tue, 14 Feb 2023 15:56:06 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1676418966; x=1679010967; bh=pEnLWNUeiDXooxyuVty+8cCKql27+XR1BGK YZjuILOw=; b=ikPUjaoUBrwQzD0XtJBdPMNlUgHr9DIs/NZUcygVDiRPAgQWpRN GH4ICJUSMCYC73uHMjkCKsKzF/v5w/QgmRt9hR5POPV32S8hDk220xWZdU0oytDo qAXQpf2021exeZ5/ZTgO0BKKx5ohsspoKFwX5lt9UG1261LW/spWaQ9aKHmZyDzZ 9878KXRrPX1hX+KRVSQQaJAG1W4BMGJfjhr0fi6WShB7hQbZAPVUYL9gcbzXx08f vGwpE77XRMOM5EmEnA7j+ciioKnKW4vvEa9U0NCHvV3NcWiQgsHVz4y6C6RjUmO5 Yp62eaCXHahoZbnK4blMKgmZZ8ikXQketbA== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id weeWiGibIylh for ; Tue, 14 Feb 2023 15:56:06 -0800 (PST) Received: from [10.225.163.116] (unknown [10.225.163.116]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4PGdQC15SSz1RvLy; Tue, 14 Feb 2023 15:56:02 -0800 (PST) Message-ID: <2ebd33e2-46ef-356d-ff4c-81b74950d02f@opensource.wdc.com> Date: Wed, 15 Feb 2023 08:56:01 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 1/9] PCI: rockchip: Remove writes to unused registers Content-Language: en-US To: Rick Wertenbroek , alberto.dassatti@heig-vd.ch Cc: xxm@rock-chips.com, rick.wertenbroek@heig-vd.ch, Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Shawn Lin , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Bjorn Helgaas , Jani Nikula , Greg Kroah-Hartman , Rodrigo Vivi , Mikko Kovanen , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org References: <20230214140858.1133292-1-rick.wertenbroek@gmail.com> <20230214140858.1133292-2-rick.wertenbroek@gmail.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230214140858.1133292-2-rick.wertenbroek@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2/14/23 23:08, Rick Wertenbroek wrote: > Remove write accesses to registers that are marked "unused" (and > therefore read-only) in the technical reference manual (TRM) > (see RK3399 TRM 17.6.8.1) > > Signed-off-by: Rick Wertenbroek I checked the TRM and indeed these registers are listed as unused. However, with this patch, nothing work for me using a Pine rockpro64 board. Keeping this patch, your series (modulo some other fixes, more emails coming) is making things work ! So I think the bug is with the TRM, not the code. THinking logically about htis, it makes sense: this is programming the address translation unit to translate mmio & dma between host PCI address and local CPU space address. If we never set the PU address, how can that unit possibly ever translate anything ? > --- > drivers/pci/controller/pcie-rockchip-ep.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/pci/controller/pcie-rockchip-ep.c b/drivers/pci/controller/pcie-rockchip-ep.c > index d1a200b93..d5c477020 100644 > --- a/drivers/pci/controller/pcie-rockchip-ep.c > +++ b/drivers/pci/controller/pcie-rockchip-ep.c > @@ -61,10 +61,6 @@ static void rockchip_pcie_clear_ep_ob_atu(struct rockchip_pcie *rockchip, > ROCKCHIP_PCIE_AT_OB_REGION_DESC0(region)); > rockchip_pcie_write(rockchip, 0, > ROCKCHIP_PCIE_AT_OB_REGION_DESC1(region)); > - rockchip_pcie_write(rockchip, 0, > - ROCKCHIP_PCIE_AT_OB_REGION_CPU_ADDR0(region)); > - rockchip_pcie_write(rockchip, 0, > - ROCKCHIP_PCIE_AT_OB_REGION_CPU_ADDR1(region)); > } > > static void rockchip_pcie_prog_ep_ob_atu(struct rockchip_pcie *rockchip, u8 fn, > @@ -114,12 +110,6 @@ static void rockchip_pcie_prog_ep_ob_atu(struct rockchip_pcie *rockchip, u8 fn, > PCIE_CORE_OB_REGION_ADDR0_LO_ADDR); > addr1 = upper_32_bits(cpu_addr); > } > - > - /* CPU bus address region */ > - rockchip_pcie_write(rockchip, addr0, > - ROCKCHIP_PCIE_AT_OB_REGION_CPU_ADDR0(r)); > - rockchip_pcie_write(rockchip, addr1, > - ROCKCHIP_PCIE_AT_OB_REGION_CPU_ADDR1(r)); > } > > static int rockchip_pcie_ep_write_header(struct pci_epc *epc, u8 fn, u8 vfn, -- Damien Le Moal Western Digital Research