devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI
@ 2023-08-25 13:56 Krzysztof Kozlowski
  2023-08-25 13:56 ` [PATCH 2/2] ARM: dts: qcom: sdx65: fix SDHCI clocks order Krzysztof Kozlowski
  2023-08-25 14:07 ` [PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI Konrad Dybcio
  0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-08-25 13:56 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel
  Cc: Krzysztof Kozlowski

DSI node does not accept nor use "label" property:

  qcom-apq8064-asus-nexus7-flo.dtb: dsi@4700000: Unevaluated properties are not allowed ('label' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom/qcom-apq8064.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
index 9e033dc6e391..7fd3f164e7d4 100644
--- a/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-apq8064.dtsi
@@ -1270,7 +1270,6 @@ mmss_sfpb: syscon@5700000 {
 		dsi0: dsi@4700000 {
 			compatible = "qcom,apq8064-dsi-ctrl",
 				     "qcom,mdss-dsi-ctrl";
-			label = "MDSS DSI CTRL->0";
 			#address-cells = <1>;
 			#size-cells = <0>;
 			interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ARM: dts: qcom: sdx65: fix SDHCI clocks order
  2023-08-25 13:56 [PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI Krzysztof Kozlowski
@ 2023-08-25 13:56 ` Krzysztof Kozlowski
  2023-08-25 14:08   ` Konrad Dybcio
  2023-08-25 14:07 ` [PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI Konrad Dybcio
  1 sibling, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2023-08-25 13:56 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel
  Cc: Krzysztof Kozlowski

Bindings expect clocks to be in different order:

  qcom-sdx65-mtp.dtb: mmc@8804000: clock-names:0: 'iface' was expected
  qcom-sdx65-mtp.dtb: mmc@8804000: clock-names:1: 'core' was expected

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom/qcom-sdx65.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi
index a1679f9f8f1e..9d9ac4e23831 100644
--- a/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-sdx65.dtsi
@@ -461,9 +461,9 @@ sdhc_1: mmc@8804000 {
 			interrupts = <GIC_SPI 210 IRQ_TYPE_LEVEL_HIGH>,
 				     <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>;
 			interrupt-names = "hc_irq", "pwr_irq";
-			clocks = <&gcc GCC_SDCC1_APPS_CLK>,
-				 <&gcc GCC_SDCC1_AHB_CLK>;
-			clock-names = "core", "iface";
+			clocks = <&gcc GCC_SDCC1_AHB_CLK>,
+				 <&gcc GCC_SDCC1_APPS_CLK>;
+			clock-names = "iface", "core";
 			status = "disabled";
 		};
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI
  2023-08-25 13:56 [PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI Krzysztof Kozlowski
  2023-08-25 13:56 ` [PATCH 2/2] ARM: dts: qcom: sdx65: fix SDHCI clocks order Krzysztof Kozlowski
@ 2023-08-25 14:07 ` Konrad Dybcio
  1 sibling, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2023-08-25 14:07 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel

On 25.08.2023 15:56, Krzysztof Kozlowski wrote:
> DSI node does not accept nor use "label" property:
> 
>   qcom-apq8064-asus-nexus7-flo.dtb: dsi@4700000: Unevaluated properties are not allowed ('label' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 2/2] ARM: dts: qcom: sdx65: fix SDHCI clocks order
  2023-08-25 13:56 ` [PATCH 2/2] ARM: dts: qcom: sdx65: fix SDHCI clocks order Krzysztof Kozlowski
@ 2023-08-25 14:08   ` Konrad Dybcio
  0 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2023-08-25 14:08 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
	linux-kernel

On 25.08.2023 15:56, Krzysztof Kozlowski wrote:
> Bindings expect clocks to be in different order:
> 
>   qcom-sdx65-mtp.dtb: mmc@8804000: clock-names:0: 'iface' was expected
>   qcom-sdx65-mtp.dtb: mmc@8804000: clock-names:1: 'core' was expected
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-08-25 14:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-25 13:56 [PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI Krzysztof Kozlowski
2023-08-25 13:56 ` [PATCH 2/2] ARM: dts: qcom: sdx65: fix SDHCI clocks order Krzysztof Kozlowski
2023-08-25 14:08   ` Konrad Dybcio
2023-08-25 14:07 ` [PATCH 1/2] ARM: dts: qcom: apq8064: drop label property from DSI Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).