From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jakob Unterwurzacher <jakobunt@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: jakob.unterwurzacher@theobroma-systems.com,
Ermin Sunj <ermin.sunj@theobroma-systems.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] TSD: arm64: dts: rockchip: use codec as clock master
Date: Fri, 25 Aug 2023 08:49:21 +0200 [thread overview]
Message-ID: <2eda319d-bdd9-bfeb-005a-5989cf674501@linaro.org> (raw)
In-Reply-To: <20230823122000.585787-1-jakob.unterwurzacher@theobroma-systems.com>
On 23/08/2023 14:19, Jakob Unterwurzacher wrote:
> From: Ermin Sunj <ermin.sunj@theobroma-systems.com>
>
> If the codec is not the clock master, the MCLK needs to be
> synchronous to both I2S_SCL ans I2S_LRCLK. We do not have that
> on Haikou, causing distorted audio.
>
> Before:
>
> Running audioloopback.py script on Ringneck, 1kHz
> output sine wave is not stable and shows distortion.
>
> After:
>
> 10h stress tests audioloopback.py failed only one time.
> That is 0.00014% failure rate.
What is TSD? Why it is in the subject prefix?
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-25 6:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 12:19 [PATCH 1/2] TSD: arm64: dts: rockchip: use codec as clock master Jakob Unterwurzacher
2023-08-23 12:20 ` [PATCH 2/2] TSD: arm64: dts: rockchip: set system-clock-fixed in sgtl5000_codec Jakob Unterwurzacher
2023-08-23 12:38 ` [PATCH 1/2] TSD: arm64: dts: rockchip: use codec as clock master Heiko Stübner
2023-08-25 6:49 ` Krzysztof Kozlowski [this message]
2023-08-25 13:16 ` Jakob Unterwurzacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2eda319d-bdd9-bfeb-005a-5989cf674501@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ermin.sunj@theobroma-systems.com \
--cc=heiko@sntech.de \
--cc=jakob.unterwurzacher@theobroma-systems.com \
--cc=jakobunt@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).