From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: 郭力豪 <lhjeff911@gmail.com>,
rafael@kernel.org, "Daniel Lezcano" <daniel.lezcano@linaro.org>,
amitk@kernel.org, rui.zhang@intel.com, robh+dt@kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: "lh.kuo" <lh.kuo@sunplus.com>, 呂芳騰LuWells <wells.lu@sunplus.com>
Subject: Re: [PATCH v9 2/2] dt-bindings:thermal: Add Sunplus schema
Date: Fri, 10 Jun 2022 12:29:07 +0200 [thread overview]
Message-ID: <2edb2dbc-0f62-23cc-2f32-3d27d83a194e@linaro.org> (raw)
In-Reply-To: <CAGcXWkzSrEPPT2m=2trWN-BV-ix9TcHCvZYya5i54ei=EWGTZw@mail.gmail.com>
On 10/06/2022 03:32, 郭力豪 wrote:
> Add bindings for Sunplus thermal driver
>
> Signed-off-by: Li-hao Kuo <lhjeff911@gmail.com>
Thank you for your patch. There is something to discuss/improve.
> ---
> Changes in v9:
> - Change the setting of compatible
> - Mosdify the setting of remove funciton.
Your subject misses space after "dt-bindings:". Look at other patches
how they are named. Please fix it.
Normally I would give conditional review, but I am afraid it you won't
fix it, based on our previous history here. :(
So sorry, but for such small change, I expect v10.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-06-10 10:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 1:32 [PATCH v9 2/2] dt-bindings:thermal: Add Sunplus schema 郭力豪
2022-06-10 10:29 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2edb2dbc-0f62-23cc-2f32-3d27d83a194e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=lh.kuo@sunplus.com \
--cc=lhjeff911@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=wells.lu@sunplus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).