From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28FF3C7EE26 for ; Tue, 23 May 2023 23:35:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234317AbjEWXfT (ORCPT ); Tue, 23 May 2023 19:35:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238712AbjEWXfS (ORCPT ); Tue, 23 May 2023 19:35:18 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6BFE130 for ; Tue, 23 May 2023 16:34:41 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4f3bb61f860so122817e87.3 for ; Tue, 23 May 2023 16:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684884878; x=1687476878; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uZg4v0RTyzNREljAm+hWtlmx8oK1tgGcQi54orgW1ds=; b=OstWqeJ8EBmWlFGue4DAaM6ZZhqrbhVBiHBeqwEkfBiE7hUwN6EVNxk44rPHYYdjLx ouN7tkRmfck3Ej5JJQklzLGP92BrvTcGGDW4hja4smz2EhINxCFPlTkaiaOiaDU/Wk+W mYgEbHiM211S4AGUPMcQXwc7dK853YjrtHjfdLYnT3NIjW3R+vgewHmI6kkDkYpLekIA pLP/cE6iTnzsf6gFCB4EMkvCHF+k6ish4fvk3T5CT6o/pulNQIidz5bi/Y0lOBj/lvuz Me7nnL4FEqfYoUPIwyR8YMVMqKK4I5ztKCertmHEi9Om4kVA68ten7F8tT59p6Vyfr8W EAfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684884878; x=1687476878; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uZg4v0RTyzNREljAm+hWtlmx8oK1tgGcQi54orgW1ds=; b=Ce+U666xCXv5l7bvfTsaChOEMkDgJwGb3Gx3Xmb0CbNXZYBb2DomJnBgIaFOD5e8f0 Ij0y5pcq3zmvur0buc66yR2ezTKel//mVREx+BTcJAzWUmaeJx7PtbtZG7ydrVGBQrJf hJttezhsjtXzdWHj0xgYlTYGypKZYdAV70mOiW8XsW1NIHF5IQNnzk+uVta9onGtDiBR v1yI0p4vsBQufLJfyO4VeRZZSeV2SDT5spnMRsX7YKzTchZ7GC1gs/5yBNPrKdyH3rZj bv0ANIv2bDi3vxdoo+V5oNpyvYq2SiwVglgz1cvs5qyt5wIBIGfRLZiUQsU1VLhmEntg PUdQ== X-Gm-Message-State: AC+VfDzp0JG2kmF3ztC48vK52iJhrnqxX7JPvIQqA6us0nX/zfAUarD1 LLi9SDoR2U8tSmdOKU7YFjjEog== X-Google-Smtp-Source: ACHHUZ5VDMwnlQ1kaA9DshgcAwp1SpRlIsOFRsbkhg4YoGBxLfOqCiRKUEVf4TbW3N9bzRfshL/0vw== X-Received: by 2002:ac2:4556:0:b0:4f3:a8f2:2138 with SMTP id j22-20020ac24556000000b004f3a8f22138mr4811916lfm.58.1684884878607; Tue, 23 May 2023 16:34:38 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id g10-20020a19ac0a000000b004f3af454556sm1490213lfc.246.2023.05.23.16.34.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 May 2023 16:34:38 -0700 (PDT) Message-ID: <2ef03df1-00ec-4e93-ecca-5cc4a4ef3b23@linaro.org> Date: Wed, 24 May 2023 02:34:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 6/6] ARM: dts: qcom: apq8074-dragonboard: enable coincell charger Content-Language: en-GB From: Dmitry Baryshkov To: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20230508160446.2374438-1-dmitry.baryshkov@linaro.org> <20230508160446.2374438-7-dmitry.baryshkov@linaro.org> In-Reply-To: <20230508160446.2374438-7-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/05/2023 19:04, Dmitry Baryshkov wrote: > Enable coincell charger for the coin battery which can be installed on > the APQ8074 dragonboard. > > Reviewed-by: Konrad Dybcio > Signed-off-by: Dmitry Baryshkov > --- > arch/arm/boot/dts/qcom-apq8074-dragonboard.dts | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts > index 07db6451f273..93a059641957 100644 > --- a/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts > +++ b/arch/arm/boot/dts/qcom-apq8074-dragonboard.dts > @@ -58,6 +58,12 @@ eeprom: eeprom@52 { > }; > }; > > +&pm8941_coincell { > + qcom,rset-ohms = <2100>; > + qcom,vset-millivolts = <3000>; > + status = "okay"; > +}; Ok, this one might need reconsideration. I still didn't find the lithium accumulator of this size and granted that it might be the battery instead of the accumulator, it is safer not to enable the charger, at least by default. > + > &pm8941_gpios { > msm_keys_default: pm8941-gpio-keys-state { > pins = "gpio5", "gpio23"; -- With best wishes Dmitry