Re: [PATCH v2 2/3] dt-bindings: MIPS: Add Ingenic X1830 based boards.

[Zhou Yanjie <zhouyanjie@wanyeetech.com>]

Hi Rob,

在 2020/7/14 上午10:32, Rob Herring 写道:
> On Fri, Jun 26, 2020 at 01:37:15AM +0800, 周琰杰 (Zhou Yanjie) wrote:
>> Add bindings for Ingenic X1830 based board, prepare for later dts.
>>
>> Tested-by: 周正 (Zhou Zheng) <sernia.zhou@foxmail.com>
>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
>> ---
>>
>> Notes:
>>      v1->v2:
>>      No change.
>>
>>   Documentation/devicetree/bindings/mips/ingenic/devices.yaml | 12 +++++++++---
>>   1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mips/ingenic/devices.yaml b/Documentation/devicetree/bindings/mips/ingenic/devices.yaml
>> index d1175030781a..feb695be9f66 100644
>> --- a/Documentation/devicetree/bindings/mips/ingenic/devices.yaml
>> +++ b/Documentation/devicetree/bindings/mips/ingenic/devices.yaml
>> @@ -8,7 +8,8 @@ title: Ingenic XBurst based Platforms Device Tree Bindings
>>   
>>   maintainers:
>>     - 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
>> -description: |
>> +
>> +description:
>>     Devices with a Ingenic XBurst CPU shall have the following properties.
>>   
>>   properties:
>> @@ -32,8 +33,13 @@ properties:
>>             - const: img,ci20
>>             - const: ingenic,jz4780
>>   
>> -      - description: YSH & ATIL General Board CU Neo
>> +      - description: YSH & ATIL General Board, CU1000 Module with Neo Backplane
>>           items:
>>             - const: yna,cu1000-neo
>> -          - const: ingenic,x1000
>> +          - const: ingenic,x1000e
> What's this change? You can't just change bindings.


This is my fault, I will add the modification of the corresponding dts 
file in the next version.

Thanks and best regards!

>> +
>> +      - description: YSH & ATIL General Board, CU1830 Module with Neo Backplane
>> +        items:
>> +          - const: yna,cu1830-neo
>> +          - const: ingenic,x1830
>>   ...
>> -- 
>> 2.11.0
>>