From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C20BC433EF for ; Tue, 14 Dec 2021 14:59:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235118AbhLNO7m (ORCPT ); Tue, 14 Dec 2021 09:59:42 -0500 Received: from foss.arm.com ([217.140.110.172]:58140 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232616AbhLNO7m (ORCPT ); Tue, 14 Dec 2021 09:59:42 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 26983D6E; Tue, 14 Dec 2021 06:59:42 -0800 (PST) Received: from [10.57.34.58] (unknown [10.57.34.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 51A4F3F774; Tue, 14 Dec 2021 06:59:40 -0800 (PST) Message-ID: <2f100de5-c3de-e70e-9869-ba1942f686c8@arm.com> Date: Tue, 14 Dec 2021 14:59:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v2 5/5] dt-bindings: perf: Add compatible for Arm DSU-110 Content-Language: en-GB To: Suzuki K Poulose , will@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com Cc: catalin.marinas@arm.com, thierry.reding@gmail.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org References: <51a8060493e1220886dcd468fad9a2b603607297.1639490264.git.robin.murphy@arm.com> From: Robin Murphy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2021-12-14 14:42, Suzuki K Poulose wrote: > On 14/12/2021 14:16, Robin Murphy wrote: >> DSU-110 is the newest and shiniest for Armv9. Its programmer's model is >> largely identical to the previous generation of DSUs, so we can treat it >> as compatible, but it does have a a handful of extra IMP-DEF PMU events >> to call its own. Thanks to the new notion of core complexes, the maximum >> number of supported CPUs goes up as well. >> >> Signed-off-by: Robin Murphy >> --- >> >> v2: Also make it complete and valid >> >>   Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml | 8 ++++++-- >>   1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml >> b/Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml >> index 09ddeb6a3ccc..7f31bcecedb5 100644 >> --- a/Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml >> +++ b/Documentation/devicetree/bindings/perf/arm,dsu-pmu.yaml >> @@ -21,7 +21,11 @@ description: >>   properties: >>     compatible: >> -    const: arm,dsu-pmu >> +    oneOf: >> +      - const: arm,dsu-pmu >> +      - items: >> +          - const: arm,dsu-110-pmu >> +          - const: arm,dsu-pmu > > Couldn't this be : > >     compatible: >       oneOf: >         - const: arm,dsu-110-pmu >         - const: arm,dsu-pmu > > Otherwise, looks good to me. My intent here was for the new case to use both strings and thus still permit a less-specific match to the original one (hence why there's no change to the actual driver included here). It's a true "compatible" in the sense that you can run the thing with the existing driver as if it's a 1st-gen DSU and get the expected results - at least that's the conclusion I drew from a side-by-side comparison of the TRMs, and the folks testing FPGAs haven't complained since I told them to try it months ago :) Thanks, Robin.