From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B495C433EF for ; Sat, 25 Jun 2022 20:43:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233493AbiFYUnS (ORCPT ); Sat, 25 Jun 2022 16:43:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233401AbiFYUnR (ORCPT ); Sat, 25 Jun 2022 16:43:17 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66E7665FB for ; Sat, 25 Jun 2022 13:43:16 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id g26so11334087ejb.5 for ; Sat, 25 Jun 2022 13:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=iFd1veKfhTMGQGljEN9uvXrZe1abjjQ/8ra6X7ZXp/A=; b=Q7zhM31lwwRJmmE86uF2FZdYeGJWH8clPbsigWZbDLOJkiq5xQB4H51dgNqn2WCHnx yUXJzBRWoVFajl57tWs4A69Wbki0B8V6iPIANs+sUlfUDigI0GlifsugGjE5wqOMd+/y 3CpLaWbqBcZr37Ce7sSFjjD7xg1mqyT69ipPkjCsv48oCysOCsktRsLZtjVgT497qpu5 DcAvK9SrwWTCZO9i+rwbxJ16hZqYBo02WvDH26todecvwLGQfVRcLMTNMPFHBJoqb6Wc 75Xbhv36Ay184RbeLY8M/ygMw1D3mXj5nHzu+9iKS2YnB3+L4/fqYfrHAu+Ie1/0gzhZ ls3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iFd1veKfhTMGQGljEN9uvXrZe1abjjQ/8ra6X7ZXp/A=; b=fyMf4Lj/gKbtIbKcbCwpgllqpBSysaFhhyFiRcAL3fDOl1sb5tP8NCM3WEla6ZIf5G HUQkvCwIh6bgLKWALTzrNHO6LO3XvWb3JVLAMaYxA8y4MokZgMff/tJidRMCFxf1sU47 vH41Um7tMNX0hbchK+N5eC5AfbWxxcqPV99RknsHxTy1ndiBW3BhVQTCQvSvuG9wr8mI PFkPlh+E0ol0prnikYRxULwjwj2W9+WGYl0+3hnBVPvsV6F6a1hm7vi1OevHTi/KzuG8 X5mAgPFF0GC+UkPU7fvTnfImM3a0bAhL33SjAathcVgRq3ipxaGaXsKhCeJCwILNE2Xd d5fg== X-Gm-Message-State: AJIora/MdXBYYXpb9OqzeGtrbEdMSpKsUaU64sRJN2ucUOsyVfCOdrjR azVUrZbYfv9SZFrZyJwxJl/mBg== X-Google-Smtp-Source: AGRyM1ubzxZPS0hDWjk/Wtmb8RnNWKmiyIjbS5HD1t1lVciAej4xtBFwV019ReryeNb/GjF5I2Bz9Q== X-Received: by 2002:a17:907:2ce4:b0:722:df67:12cc with SMTP id hz4-20020a1709072ce400b00722df6712ccmr5399009ejc.715.1656189794930; Sat, 25 Jun 2022 13:43:14 -0700 (PDT) Received: from [192.168.0.239] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id g26-20020a170906199a00b00724ff3251c4sm3019630ejd.26.2022.06.25.13.43.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Jun 2022 13:43:14 -0700 (PDT) Message-ID: <2f2b2544-9c53-3a6a-d9c9-375e75b112f3@linaro.org> Date: Sat, 25 Jun 2022 22:43:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 1/2] dt-bindings: i2c: Document RZ/V2M I2C controller Content-Language: en-US To: Phil Edworthy , Rob Herring , Krzysztof Kozlowski Cc: Biju Das , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, Geert Uytterhoeven , linux-renesas-soc@vger.kernel.org References: <20220624101736.27217-1-phil.edworthy@renesas.com> <20220624101736.27217-2-phil.edworthy@renesas.com> From: Krzysztof Kozlowski In-Reply-To: <20220624101736.27217-2-phil.edworthy@renesas.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/06/2022 12:17, Phil Edworthy wrote: > Document Renesas RZ/V2M (r9a09g011) I2C controller bindings. > > Signed-off-by: Phil Edworthy > Reviewed-by: Biju Das > --- > .../bindings/i2c/renesas,rzv2m.yaml | 76 +++++++++++++++++++ > 1 file changed, 76 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > > diff --git a/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > new file mode 100644 > index 000000000000..9049461ad2f4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/renesas,rzv2m.yaml > @@ -0,0 +1,76 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/i2c/renesas,rzv2m.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Renesas RZ/V2M I2C Bus Interface > + > +maintainers: > + - Phil Edworthy > + > +allOf: > + - $ref: /schemas/i2c/i2c-controller.yaml# > + > +properties: > + compatible: > + items: > + - enum: > + - renesas,i2c-r9a09g011 # RZ/V2M > + - const: renesas,rzv2m-i2c > + > + reg: > + maxItems: 1 > + > + interrupts: > + items: > + - description: Data transmission/reception interrupt > + - description: Status interrupt > + > + interrupt-names: > + items: > + - const: tia > + - const: tis > + > + clock-frequency: > + description: > + Desired I2C bus clock frequency in Hz. The absence of this property > + indicates the default frequency 100 kHz. Instead of last sentence, just add "default: 100000". > + > + clocks: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-names > + - clocks > + - power-domains > + - resets This was not mentioned in properties. Why? > + - '#address-cells' > + - '#size-cells' > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + > + i2c0: i2c@a4030000 { > + compatible = "renesas,i2c-r9a09g011", "renesas,rzv2m-i2c"; > + reg = <0xa4030000 0x80>; > + interrupts = , > + ; > + interrupt-names = "tia", "tis"; > + clocks = <&cpg CPG_MOD R9A09G011_IIC_PCLK0>; > + resets = <&cpg R9A09G011_IIC_GPA_PRESETN>; > + power-domains = <&cpg>; > + clock-frequency = <100000>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; Best regards, Krzysztof