From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m32113.qiye.163.com (mail-m32113.qiye.163.com [220.197.32.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EA303D5646; Fri, 15 May 2026 04:33:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.32.113 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778819622; cv=none; b=lPA6V/vj8P6NBdkD++NP/6vU9apA43UkjB5OiANjsB+7iSo+c8dpFlH25huSRIZFsZIFouCHDaTIqse7UbfpjW5djhlFFg3Ay1aSEyxvFIhCbkq3lRa9BMUhTeopHbrOmGJWScG3qRCX5+Jzqz19XpFqdUM9KnYQQ25ScTZp6Uc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778819622; c=relaxed/simple; bh=zg8dWcxfVEFqhgH2uc69LayhhgOBez8UBuZQBT7A5oo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=svD/4/M/ERY9Jem3p9WWE3erNPQqjgQeeK6V6jWIHWbiE2eoPL53eKCzLX1eGG3je8pDOT0R2wQy5PrFkB0F9CjuJXbpb0KHYm4xFjDX6V4klxQfR5FaceQBNf+vTY5pTBktKnxwAc25CIHDbfiACAn4bCdgU2KzEK2snFNMv3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=UZB7lH4h; arc=none smtp.client-ip=220.197.32.113 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="UZB7lH4h" Received: from [172.16.12.43] (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 3e82fac39; Fri, 15 May 2026 11:57:58 +0800 (GMT+08:00) Message-ID: <2f653664-27e9-4632-97e9-8b59cf7e585e@rock-chips.com> Date: Fri, 15 May 2026 11:57:58 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/3] dt-bindings: display: rockchip: analogix-dp: Expose inherited properties To: Conor Dooley Cc: hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, nicolas.frattaroli@collabora.com, cristian.ciocaltea@collabora.com, sebastian.reichel@collabora.com, dmitry.baryshkov@oss.qualcomm.com, luca.ceresoli@bootlin.com, dianders@chromium.org, m.szyprowski@samsung.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260514070133.2275069-1-damon.ding@rock-chips.com> <20260514070133.2275069-2-damon.ding@rock-chips.com> <20260514-upstate-sneer-0b6e78682798@spud> Content-Language: en-US From: Damon Ding In-Reply-To: <20260514-upstate-sneer-0b6e78682798@spud> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Tid: 0a9e29c8ae0703a3kunmd1b8d9bd125afa X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVkZSktLVkIYTR8aHkgdTE0YSVYVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSE pKQk1VSktLVUpCWQY+ DKIM-Signature: a=rsa-sha256; b=UZB7lH4hvEXP3pLiPNBhvVIN/gQNsy9iafLoKvDKgsRRFlrJKAecHptJ7/J77wyBeceuZOOprBHD36ae6nHJk5rWBHxxSgKKrOX7JTLhssGbJxofO/ZsqaDhRPiJGMf+/tYd2AQbZfHuNBGK4/0Iow6PsrJyKqHXbi5WbuimHJU=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=num2dBkmQCmOz3VFEseziFih+L9BmXJ8Dbo1P1UCNNw=; h=date:mime-version:subject:message-id:from; Hi Conor, On 5/15/2026 2:16 AM, Conor Dooley wrote: > On Thu, May 14, 2026 at 03:01:31PM +0800, Damon Ding wrote: >> Expose the inherited properties from the base analogix-dp schema >> to satisfy unevaluatedProperties constraints. >> >> Signed-off-by: Damon Ding > > Given it's unevaluatedProperties, not addtionalProperties, this patch > shouldn't be needed? > When I remove both the top-level data-lanes property and those explicit "xxx: true" property entries and run the dtbs check with: make CHECK_DTBS=y CROSS_COMPILE=aarch64-linux-gnu- LT0=none LLVM=1 LLVM_IAS=1 ARCH=arm64 rockchip/rk3588-evb1-v10.dtb rockchip/rk3588s-evb1-v10.dtb rockchip/rk3399-sapphire-excavator.dtb rockchip/rk3576-evb1-v10.dtb -j4 It results in validation errors like these: /home/ding/drm-misc/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dtb: edp@27dc0000: ports:port@1:endpoint: Unevaluated properties are not allowed ('data-lanes' was unexpected) from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# /home/ding/drm-misc/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dtb: edp@27dc0000: Unevaluated properties are not allowed ('force-hpd', 'interrupts', 'phy-names', 'phys', 'ports', 'reg' were unexpected) from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,analogix-dp.yaml# I suspect that the properties defined in the child binding are overriding/masking all the inherited properties from the parent Analogix DP schema. Is there a better way to fix this issue without explicitly listing all inherited properties as true? Best regards, Damon >> --- >> .../bindings/display/rockchip/rockchip,analogix-dp.yaml | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml >> index bb75d898a5c5..896ded87880f 100644 >> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml >> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml >> @@ -50,6 +50,13 @@ properties: >> aux-bus: >> $ref: /schemas/display/dp-aux-bus.yaml# >> >> + reg: true >> + interrupts: true >> + phys: true >> + phy-names: true >> + force-hpd: true >> + ports: true >> + >> required: >> - compatible >> - clocks >> -- >> 2.34.1 >> >>