From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Jianhua Lu <lujianhua000@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sm8250-xiaomi-elish: add usb pd negotiation support
Date: Sat, 2 Mar 2024 00:58:57 +0100 [thread overview]
Message-ID: <2f6a5c83-69a4-480b-a235-c0d51feac31e@linaro.org> (raw)
In-Reply-To: <20240227124529.12926-1-lujianhua000@gmail.com>
On 27.02.2024 13:45, Jianhua Lu wrote:
> Add usb pd negotiation, but charging is controlled by pm8150b pmic,
> so it can only charge battery with 5W,
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> ---
> arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> index 6f54f50a70b0..ed103b90f4e6 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> @@ -636,7 +636,8 @@ &pm8150b_typec {
> connector {
> compatible = "usb-c-connector";
>
> - power-role = "source";
> + op-sink-microwatt = <10000000>;
Is 10W really the minimum value for this tablet to function as a sink?
Is that what the downstream kernel sets?
> + power-role = "dual";
> data-role = "dual";
> self-powered;
>
> @@ -645,6 +646,12 @@ PDO_FIXED_DUAL_ROLE |
> PDO_FIXED_USB_COMM |
> PDO_FIXED_DATA_SWAP)>;
>
> + sink-pdos = <PDO_FIXED(5000, 3000,
> + PDO_FIXED_DUAL_ROLE |
Please align the PDO_.. against the open brace
> + PDO_FIXED_USB_COMM |
> + PDO_FIXED_DATA_SWAP)
> + PDO_VAR(5000, 12000, 5000)>;
60W max? This is not unheard of, but I'm just making sure you know..
Konrad
next prev parent reply other threads:[~2024-03-01 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 12:45 [PATCH] arm64: dts: qcom: sm8250-xiaomi-elish: add usb pd negotiation support Jianhua Lu
2024-03-01 23:58 ` Konrad Dybcio [this message]
2024-03-02 3:05 ` Jianhua Lu
2024-03-02 13:01 ` Jianhua Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f6a5c83-69a4-480b-a235-c0d51feac31e@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lujianhua000@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).