Re: [PATCH 4/8] ASoC: tegra: Select SND_SOC_RT5659

[Sameer Pujar <dev.spujar@gmail.com>]

On 1/29/2021 10:49 PM, Mark Brown wrote:
> On Fri, Jan 29, 2021 at 10:15:51PM +0530, Sameer Pujar wrote:
>> On 1/29/2021 9:18 PM, Mark Brown wrote:
>>> If the user wants a given CODEC driver then they should enable that
>>> driver.
>> Above card driver is intended to be used on multiple platforms. DT has
>> already a way for user to describe the CODEC connection required for
>> specific platform. So idea is enable these CODECs from driver point of view
>> for this card driver and platform DT can use what is required. Also the
>> CODEC driver will be a loadable module here.
> No, you're missing the point of a generic driver here.  This will mean
> that if someone wants to build the driver into the kernel for their
> embedded board they will be forced to build in every CODEC driver
> someone has decided might be used with this generic driver, and even if
> they're building things modular someone trying to cut down the size of
> their kernel images is going to at least have to spend time building
> CODEC drivers they don't want to use.  Distributions should just select
> all the CODEC drivers that are available in Kconfig, people configuring
> for a particular target audience should be able to build only the
> drivers they know they need.

OK, will drop this in v2. Thank you for details.

>
>> If above does not seem fine, alternatively can I just enable CODEC config
>> independently from defconfig?
> Yes.