From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0515CC433F5 for ; Mon, 18 Apr 2022 12:20:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238383AbiDRMXU (ORCPT ); Mon, 18 Apr 2022 08:23:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238840AbiDRMWx (ORCPT ); Mon, 18 Apr 2022 08:22:53 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB0251EEFF for ; Mon, 18 Apr 2022 05:18:23 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id t11so26486509eju.13 for ; Mon, 18 Apr 2022 05:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=304FwvbODPc/e7NTdlGUu0OxXKV91QMvJtVzbIwOzsY=; b=oauAcvfa+/M3D5189r4makzPKYi0gCRiGm46EFxvtnJHKSzGdOdw+IekjUokWg84mc /rr5jvl3u5ivgV3bvm3wQyLnaP5CfC36SOlsJU4Wevk5/RREie3FSqKEDgZS1TmOWAxH aJEwSBcXIiX0WBv/QSZqjCivrgFhZLNODCv9X4f2om5D3JhiJp87qgRGS7DMYfYcTUSQ pcoco8zBK29ToYbxN7NYkAzgTqL/G8njWL3GcEqAKChlRSwyFxORKmBbLMb0wJ42rvSS k5RX1MVZkQ5ZakdB2Tomatx5c2GrMwJubXZQwEVZV9Di+0O3WSTNWPBWRoz+8B+RSpxs +jFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=304FwvbODPc/e7NTdlGUu0OxXKV91QMvJtVzbIwOzsY=; b=3+ZvnTUlwnTDDLycQiiIflUeZRQo02o87yUCf6urHEzxB0BRccRFe8a6QNhTaaqG6C H2DNujtnq6+Qc4u+PMD6dpZtLbxrN5OoPvb10w5M2vvA3TNOb/wTJ8zRHKlhiV3fAFMR eERpR++VY/1RBieQJu3jus3bXXAJL76CS54wSNVZbGelJLmIw5BZnTyA7PUmP5As3j3m CcsGL3Spg7PX8XZqYgo8rfWF/4yL0S4A6rdkkWhFvyveGy9E0qlToSEy13GJRW3E57A0 7jmuuDHemhGQ8D+edh9AJTXItfFp5x20BFbCRr1a7DduY4YFgt1syV2vhJcELbmkdGKg HIBw== X-Gm-Message-State: AOAM532+WhtmF7xx4Cnz9cPPwWg5JoXXqKx5jbBGeUjUUynxFY3Kr1Ff vX7c4NKj6+z68UwrtJbVfPpWMg== X-Google-Smtp-Source: ABdhPJwitUmBeZrL4/JQi7iDB4R8V82XjKuvEHdTLZYkZ4ZYC6c9hFCwam2fEu49tYxcY++zvLSjng== X-Received: by 2002:a17:907:7206:b0:6ef:b47c:e5ec with SMTP id dr6-20020a170907720600b006efb47ce5ecmr3565212ejc.351.1650284301960; Mon, 18 Apr 2022 05:18:21 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id h23-20020a0564020e9700b00420fff23180sm6441720eda.41.2022.04.18.05.18.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Apr 2022 05:18:21 -0700 (PDT) Message-ID: <2f8d2f6a-32dc-15cc-321c-f75721edf8a2@linaro.org> Date: Mon, 18 Apr 2022 14:18:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 2/5] dt-bindings: clock: Document MA35D1 clock controller bindings Content-Language: en-US To: Jacky Huang , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ychuang570808@gmail.com Cc: robh+dt@kernel.org, sboyd@kernel.org, krzk+dt@kernel.org, arnd@arndb.de, olof@lixom.net, will@kernel.org, soc@kernel.org, cfli0@nuvoton.com References: <20220418082738.11301-1-ychuang3@nuvoton.com> <20220418082738.11301-3-ychuang3@nuvoton.com> From: Krzysztof Kozlowski In-Reply-To: <20220418082738.11301-3-ychuang3@nuvoton.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/04/2022 10:27, Jacky Huang wrote: > Add documentation to describe Nuvoton MA35D1 clock driver bindings. > You skipped the review tag, so I assume because of amount of changes. Usually it is nice to mention it... > Signed-off-by: Jacky Huang > --- > .../bindings/clock/nuvoton,ma35d1-clk.yaml | 63 +++++++++++++++++++ > 1 file changed, 63 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml > > diff --git a/Documentation/devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml b/Documentation/devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml > new file mode 100644 > index 000000000000..d0d37c5e84af > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/nuvoton,ma35d1-clk.yaml > @@ -0,0 +1,63 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/nuvoton,ma35d1-clk.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton MA35D1 Clock Control Module Binding > + > +maintainers: > + - Chi-Fang Li > + - Jacky Huang > + > +description: | > + The MA35D1 clock controller generates clocks for the whole chip, > + including system clocks and all peripheral clocks. > + > + See also: > + include/dt-bindings/clock/ma35d1-clk.h > + > +properties: > + compatible: > + const: nuvoton,ma35d1-clk > + > + reg: > + maxItems: 1 > + > + "#clock-cells": > + const: 1 > + > + assigned-clocks: What about clocks? This depends on clocks. What clocks do you want to assign if they are not an input to the device? > + minItems: 5 > + maxItems: 5 This is different than before. minItems should not be here. Why do you need assigned-clocks in the binding at all? > + > + assigned-clock-rates: > + minItems: 5 > + maxItems: 5 > + > + nuvoton,clk-pll-mode: > + A list of PLL operation mode corresponding to DDRPLL, APLL, EPLL, > + and VPLL in sequential. This does not look like a binding which was tested. Read "writing-schema" and test your bindings. > + $ref: /schemas/types.yaml#/definitions/uint32-array > + minItems: 5 No need for minItems. > + maxItems: 5 > + items: > + enum: [ 0, 1, 2 ] You need to describe the values in description, what's their meaning. > + > +required: > + - compatible > + - reg > + - "#clock-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + clk: clock-controller@40460200 { > + compatible = "nuvoton,ma35d1-clk"; > + reg = <0x0 0x40460200 0x0 0x100>; > + #clock-cells = <1>; > + }; > +... Best regards, Krzysztof