From: Randy Dunlap <rdunlap@infradead.org>
To: "Rafał Miłecki" <zajec5@gmail.com>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>
Cc: "Matthias Brugger" <matthias.bgg@gmail.com>,
"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V3 2/2] nvmem: add generic driver for devices with MMIO access
Date: Mon, 20 Feb 2023 11:55:58 -0800 [thread overview]
Message-ID: <2f9aa86e-40e1-91f6-06b2-c79d62f7a136@infradead.org> (raw)
In-Reply-To: <20230220174930.7440-3-zajec5@gmail.com>
Hi,
On 2/20/23 09:49, Rafał Miłecki wrote:
> +static int mmio_nvmem_write(void *context, unsigned int offset, void *val, size_t bytes)
> +{
> + struct mmio_nvmem *priv = context;
> +
> + switch (priv->io_width) {
> + case 1:
> + case 2:
> + case 4:
> + return -EOPNOTSUPP;
I'm just curious: (since read supports those cases)
what size writes are typically used here?
And what value for priv->io_width?
Thanks.
> + default:
> + memcpy_toio(priv->base + offset, val, bytes);
> + }
> +
> + return 0;
> +}
--
~Randy
next prev parent reply other threads:[~2023-02-20 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 17:49 [PATCH V3 0/2] nvmem: add and use generic MMIO NVMEM Rafał Miłecki
2023-02-20 17:49 ` [PATCH V3 1/2] dt-bindings: nvmem: mmio: new binding for MMIO accessible NVMEM devices Rafał Miłecki
2023-02-26 18:38 ` Rob Herring
2023-02-20 17:49 ` [PATCH V3 2/2] nvmem: add generic driver for devices with MMIO access Rafał Miłecki
2023-02-20 19:55 ` Randy Dunlap [this message]
2023-02-20 22:05 ` Rafał Miłecki
2023-02-27 9:45 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f9aa86e-40e1-91f6-06b2-c79d62f7a136@infradead.org \
--to=rdunlap@infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=hayashi.kunihiko@socionext.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mhiramat@kernel.org \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).