From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC386C001E0 for ; Thu, 27 Jul 2023 07:18:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232519AbjG0HSc (ORCPT ); Thu, 27 Jul 2023 03:18:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233352AbjG0HSE (ORCPT ); Thu, 27 Jul 2023 03:18:04 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A9CB5269 for ; Thu, 27 Jul 2023 00:11:31 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5221cf2bb8cso798086a12.1 for ; Thu, 27 Jul 2023 00:11:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690441819; x=1691046619; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JYep43itLi484JjMyR1Wqkn5aeEi0wNHqtDvsnoQYt4=; b=RaE6n6Gunpftj1GFdzPxvEQGGy7My9xgpFOh6jjNMx/KowsR5Y0kSZkZRQL09KuQYC zMCxNx9RFmxzi6qI4yJB4CoMLKhrBvtSSQJGHPVUedhxrUCDByurJNzpVJgl5Q0QTKcz /x4UIDy91I8FGK0knJdeG9Z3ldoMfts5Y27ixiYbYFjg2vJmxGMEmDAKle9APuEZZ/NO F93o8Vw6H4WoTV+RMzhCB6N+7/qNDvLXr1k/op93IGLdQUNTwxCzxthxHrUdkfpps74i gq8X0GNB97I9HuWAVUX2/Q7O1yk+ooPfMHzFcjvXaH57X2hahZQbRjLbWXNGu6B896mE hsOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690441819; x=1691046619; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JYep43itLi484JjMyR1Wqkn5aeEi0wNHqtDvsnoQYt4=; b=kE0Dab8Q3DJX/6uuOqO6cxLOFNjeGuyZ/OwLVkTnlnyAAsvputOJIRUfOwc5dzJcj8 TFrVja652ktWh1RQCvoZmwCFoTBrxGM9fd/6ynSpwHDn7JhzLYG0bR2VSICWEtqS2/yO GSUE9ADPBWPc6caCtyWyn+cW5qZ3ZnR52iIShWIf+Yx/7ynr7alcxgDjizaR0MEtio2y otFROjGqA8LAjVIWcs4xF2c5Yna02dzHlS5EEWfLz6ZdOvlKt2V/fqNas9aVi4iWpdaG flyh5DfFeNm0/2PUL5zXIyri4i8midTy5FjeogKt7h5KwJepLzL4nnB8uoKueDhZ/8Qz OqsQ== X-Gm-Message-State: ABy/qLaD9qM8S25skQyGAvnYj8Bn9sVHCRWYV02fU3775EKHQVNT/oNv fSd1vRkC9ESldxpZKYAQ87JmGg== X-Google-Smtp-Source: APBJJlFreRkEmmdoQULIo/F/9SCFJqDWq8XA7O8D6UDXTNRm9pXQfR/6rmweX5nXwqD4Bz+951NBMA== X-Received: by 2002:aa7:d689:0:b0:521:d23b:f2c5 with SMTP id d9-20020aa7d689000000b00521d23bf2c5mr1110718edr.14.1690441819273; Thu, 27 Jul 2023 00:10:19 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id a18-20020aa7d752000000b0051dd16f7e50sm310445eds.44.2023.07.27.00.10.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 00:10:18 -0700 (PDT) Message-ID: <2fa3f27d-ff08-b923-2fb1-cf7cc888e5d5@linaro.org> Date: Thu, 27 Jul 2023 09:10:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/2] dt-bindings: input: qcom,pm8xxx-vib: add more PMIC support Content-Language: en-US From: Krzysztof Kozlowski To: Fenglin Wu , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , linux-input@vger.kernel.org, devicetree@vger.kernel.org Cc: quic_collinsd@quicinc.com, quic_subbaram@quicinc.com, quic_kamalw@quicinc.com, jestar@qti.qualcomm.com, quic_huliu@quicinc.com References: <20230718062639.2339589-1-quic_fenglinw@quicinc.com> <20230718062639.2339589-2-quic_fenglinw@quicinc.com> <4cb9f443-bdea-695a-f1b7-3963747e9a17@quicinc.com> <5b7e624b-5d06-826d-92d1-2a721b7c83b7@quicinc.com> <4210b137-2d5d-a467-ea8c-d047701fdcc2@quicinc.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/07/2023 10:02, Krzysztof Kozlowski wrote: > On 18/07/2023 09:59, Fenglin Wu wrote: > >>>> Just FYI,the change log was updated in the cover letter here: >>>> https://lore.kernel.org/linux-arm-msm/20230718062639.2339589-1-quic_fenglinw@quicinc.com/T/#m3819b50503ef19e0933a10bf797351a4af35537f >>>> >>>> Also the commit text and the driver change were also updated accordingly >>>> to address your review comment by removing 'pm7550ba-vib' compatible string. >>> >>> Removing compatible was never my feedback. Did you read: >>> https://elixir.bootlin.com/linux/v6.1-rc1/source/Documentation/devicetree/bindings/writing-bindings.rst#L42 >>> ? >>> >> Okay, so do you want me to add 'pm7550ba-vib' as a fallback compatible >> like this? >> >> properties: >> compatible: >> - enum: >> - - qcom,pm8058-vib >> - - qcom,pm8916-vib >> - - qcom,pm8921-vib >> - - qcom,pmi632-vib >> - - qcom,pm7250b-vib >> - - qcom,pm7325b-vib >> + oneOf: >> + - enum: >> + - qcom,pm8058-vib >> + - qcom,pm8916-vib >> + - qcom,pm8921-vib >> + - qcom,pmi632-vib >> + - qcom,pm7250b-vib >> + - qcom,pm7325b-vib >> + - items: >> + - enum: >> + - qcom,pm7550ba-vib >> + - const: qcom,pm7325b-vib >> > > Yes I wonder why this approved change turned out to something incorrect in your v3 patch... Best regards, Krzysztof