From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tanmay Shah <tanmay.shah@amd.com>, Conor Dooley <conor@kernel.org>
Cc: andersson@kernel.org, mathieu.poirier@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, michal.simek@amd.com, ben.levinsky@amd.com,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: remoteproc: add Versal platform support
Date: Tue, 19 Mar 2024 06:40:11 +0100 [thread overview]
Message-ID: <2fbb3c68-568d-40f5-9f48-139db9a1d7f9@linaro.org> (raw)
In-Reply-To: <1197b7f7-c43b-4ae6-b914-9e3f547810bb@amd.com>
On 19/03/2024 01:37, Tanmay Shah wrote:
> Hello,
>
> Thanks for reviews, please find my comments below.
>
> On 3/17/24 9:50 AM, Conor Dooley wrote:
>> On Fri, Mar 15, 2024 at 02:15:31PM -0700, Tanmay Shah wrote:
>>> AMD-Xilinx Versal platform is successor of ZynqMP platform. Real-time
>>> Processor Unit R5 cluster IP on Versal is same as of ZynqMP Platform.
>>
>>> Only difference is power-domains ID needed by power management firmware.
>>> Hence, keeping the compatible property same as of zynqmp node.
>>
>> No, don't be lazy. Add a compatible with a fallback please.
>
> It's same IP on different platform. I am not sure how adding compatible string
> adds value. I will refactor this series based on other comments provided.
Judging by your other thread, it would add value. Also writing bindings
asks you for this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-19 5:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 21:15 [PATCH 0/3] Add Versal and Versal-NET platform support Tanmay Shah
2024-03-15 21:15 ` [PATCH 1/3] dt-bindings: remoteproc: add Versal " Tanmay Shah
2024-03-17 14:50 ` Conor Dooley
2024-03-17 14:52 ` Conor Dooley
2024-03-19 0:37 ` Tanmay Shah
2024-03-19 5:40 ` Krzysztof Kozlowski [this message]
2024-03-17 18:50 ` Krzysztof Kozlowski
2024-03-19 0:39 ` Tanmay Shah
2024-03-15 21:15 ` [PATCH 2/3] dt-bindings: remoteproc: add Versal-NET platform Tanmay Shah
2024-03-17 18:53 ` Krzysztof Kozlowski
2024-03-19 0:51 ` Tanmay Shah
2024-03-19 5:30 ` Krzysztof Kozlowski
2024-03-19 14:42 ` Tanmay Shah
2024-03-20 7:40 ` Krzysztof Kozlowski
2024-03-20 15:14 ` Tanmay Shah
2024-03-21 7:39 ` Krzysztof Kozlowski
2024-03-21 15:13 ` Tanmay Shah
2024-03-22 5:44 ` Krzysztof Kozlowski
2024-03-22 18:28 ` Tanmay Shah
2024-03-15 21:15 ` [PATCH 3/3] drivers: remoteproc: add Versal and Versal-NET support Tanmay Shah
2024-03-17 18:55 ` Krzysztof Kozlowski
2024-03-19 1:06 ` Tanmay Shah
2024-03-19 5:25 ` Krzysztof Kozlowski
2024-03-19 14:50 ` Tanmay Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fbb3c68-568d-40f5-9f48-139db9a1d7f9@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=ben.levinsky@amd.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@amd.com \
--cc=robh+dt@kernel.org \
--cc=tanmay.shah@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox